1. Patchew
  2. QEMU
  3. [PATCH 0/5] Implement port 92 in south bridges
  4. View patch

[PATCH 1/5] hw/isa/meson.build: Sort alphabetically

Bernhard Beschow posted 5 patches 8 months, 4 weeks ago
Maintainers: Paolo Bonzini <pbonzini@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, Richard Henderson <richard.henderson@linaro.org>, Eduardo Habkost <eduardo@habkost.net>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Aurelien Jarno <aurelien@aurel32.net>, "Hervé Poussineau" <hpoussin@reactos.org>, BALATON Zoltan <balaton@eik.bme.hu>, Jiaxun Yang <jiaxun.yang@flygoat.com>
[PATCH 1/5] hw/isa/meson.build: Sort alphabetically
Posted by Bernhard Beschow 8 months, 4 weeks ago 
Fixes: fbd758008f0f "hw/isa: extract FDC37M81X to a separate file"

Signed-off-by: Bernhard Beschow <shentey@gmail.com>
---
 hw/isa/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/isa/meson.build b/hw/isa/meson.build
index f650b39507..3219282217 100644
--- a/hw/isa/meson.build
+++ b/hw/isa/meson.build
@@ -1,10 +1,10 @@
 system_ss.add(when: 'CONFIG_APM', if_true: files('apm.c'))
+system_ss.add(when: 'CONFIG_FDC37M81X', if_true: files('fdc37m81x-superio.c'))
 system_ss.add(when: 'CONFIG_I82378', if_true: files('i82378.c'))
 system_ss.add(when: 'CONFIG_ISA_BUS', if_true: files('isa-bus.c'))
 system_ss.add(when: 'CONFIG_ISA_SUPERIO', if_true: files('isa-superio.c'))
 system_ss.add(when: 'CONFIG_PC87312', if_true: files('pc87312.c'))
 system_ss.add(when: 'CONFIG_PIIX', if_true: files('piix.c'))
-system_ss.add(when: 'CONFIG_FDC37M81X', if_true: files('fdc37m81x-superio.c'))
 system_ss.add(when: 'CONFIG_SMC37C669', if_true: files('smc37c669-superio.c'))
 system_ss.add(when: 'CONFIG_VT82C686', if_true: files('vt82c686.c'))
 
-- 
2.43.2
Re: [PATCH 1/5] hw/isa/meson.build: Sort alphabetically
Posted by Mark Cave-Ayland 8 months, 3 weeks ago 
On 18/02/2024 13:16, Bernhard Beschow wrote:

> Fixes: fbd758008f0f "hw/isa: extract FDC37M81X to a separate file"
> 
> Signed-off-by: Bernhard Beschow <shentey@gmail.com>
> ---
>   hw/isa/meson.build | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/isa/meson.build b/hw/isa/meson.build
> index f650b39507..3219282217 100644
> --- a/hw/isa/meson.build
> +++ b/hw/isa/meson.build
> @@ -1,10 +1,10 @@
>   system_ss.add(when: 'CONFIG_APM', if_true: files('apm.c'))
> +system_ss.add(when: 'CONFIG_FDC37M81X', if_true: files('fdc37m81x-superio.c'))
>   system_ss.add(when: 'CONFIG_I82378', if_true: files('i82378.c'))
>   system_ss.add(when: 'CONFIG_ISA_BUS', if_true: files('isa-bus.c'))
>   system_ss.add(when: 'CONFIG_ISA_SUPERIO', if_true: files('isa-superio.c'))
>   system_ss.add(when: 'CONFIG_PC87312', if_true: files('pc87312.c'))
>   system_ss.add(when: 'CONFIG_PIIX', if_true: files('piix.c'))
> -system_ss.add(when: 'CONFIG_FDC37M81X', if_true: files('fdc37m81x-superio.c'))
>   system_ss.add(when: 'CONFIG_SMC37C669', if_true: files('smc37c669-superio.c'))
>   system_ss.add(when: 'CONFIG_VT82C686', if_true: files('vt82c686.c'))

Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>


ATB,

Mark.
Re: [PATCH 1/5] hw/isa/meson.build: Sort alphabetically
Posted by Philippe Mathieu-Daudé 8 months, 3 weeks ago 
On 18/2/24 14:16, Bernhard Beschow wrote:
> Fixes: fbd758008f0f "hw/isa: extract FDC37M81X to a separate file"
> 
> Signed-off-by: Bernhard Beschow <shentey@gmail.com>
> ---
>   hw/isa/meson.build | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

$ git grep -i alphab docs/devel/build-system.rst
$

Should we document this?

Patchew 2.1-devel-b67e4c2

© 2016 - 2024 Red Hat, Inc.