[v2] Misc: Make watchdog devices using qemu_system_reset_request() use watchdog_perfom_action()

[PATCH v2 0/2] Misc: Make watchdog devices using qemu_system_reset_request() use watchdog_perfom_action()

Abhiram Tilak posted 2 patches 8 months, 2 weeks ago

Diff against v1
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20240216192612.30838-2-atp.exp@gmail.com

Maintainers: Peter Maydell <peter.maydell@linaro.org>

hw/rtc/m48t59.c         | 4 ++--
hw/timer/pxa2xx_timer.c | 3 ++-
2 files changed, 4 insertions(+), 3 deletions(-)

Expand all Fold all

[PATCH v2 0/2] Misc: Make watchdog devices using qemu_system_reset_request() use watchdog_perfom_action()

Posted by Abhiram Tilak 8 months, 2 weeks ago

A few watchdog devices use qemu_system_reset_request(). This is not ideal since
behaviour of watchdog-expiry can't be changed by QMP using `watchdog_action`.
As stated in BiteSizedTasks wiki page, instead of using qemu_system_reset_request()
to reset when a watchdog timer expires, let watchdog_perform_action() decide
what to do.

v2:
 - Remove redundant comment in patch1 in m48t59.
 - Exclude patch 3 from patch series due to current call being more preferable.

Abhiram Tilak (2):
  misc: m48t59: replace qemu_system_reset_request() call with
    watchdog_perform_action()
  misc: pxa2xx_timer: replace qemu_system_reset_request() call with
    watchdog_perform_action()

 hw/rtc/m48t59.c         | 4 ++--
 hw/timer/pxa2xx_timer.c | 3 ++-
 2 files changed, 4 insertions(+), 3 deletions(-)

-- 
2.42.1

Re: [PATCH v2 0/2] Misc: Make watchdog devices using qemu_system_reset_request() use watchdog_perfom_action()

Posted by Peter Maydell 8 months, 1 week ago

On Fri, 16 Feb 2024 at 19:27, Abhiram Tilak <atp.exp@gmail.com> wrote:
>
> A few watchdog devices use qemu_system_reset_request(). This is not ideal since
> behaviour of watchdog-expiry can't be changed by QMP using `watchdog_action`.
> As stated in BiteSizedTasks wiki page, instead of using qemu_system_reset_request()
> to reset when a watchdog timer expires, let watchdog_perform_action() decide
> what to do.
>
> v2:
>  - Remove redundant comment in patch1 in m48t59.
>  - Exclude patch 3 from patch series due to current call being more preferable.

Thanks for sending this contribution; I've applied it to target-arm.next
and it should get into git either this week or early next week.

-- PMM