[v1] Misc: Make watchdog devices using qemu_system_reset_request() use watchdog_perfom_action()

[PATCH 0/3] Misc: Make watchdog devices using qemu_system_reset_request() use watchdog_perfom_action()

Abhiram Tilak posted 3 patches 8 months, 2 weeks ago

Diff against v2
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20240216135137.8668-3-atp.exp@gmail.com

Maintainers: Peter Maydell <peter.maydell@linaro.org>, Nicholas Piggin <npiggin@gmail.com>, Daniel Henrique Barboza <danielhb413@gmail.com>, "Cédric Le Goater" <clg@kaod.org>, David Gibson <david@gibson.dropbear.id.au>, Harsh Prateek Bora <harshpb@linux.ibm.com>

There is a newer version of this series

hw/rtc/m48t59.c              | 4 ++--
hw/timer/pxa2xx_timer.c      | 3 ++-
hw/watchdog/spapr_watchdog.c | 3 ++-
3 files changed, 6 insertions(+), 4 deletions(-)

Expand all Fold all

[PATCH 0/3] Misc: Make watchdog devices using qemu_system_reset_request() use watchdog_perfom_action()

Posted by Abhiram Tilak 8 months, 2 weeks ago

A few watchdog devices use qemu_system_reset_request(). This is not ideal since
behaviour of watchdog-expiry can't be changed by QMP using `watchdog_action`.
As stated in BiteSizedTasks wiki page, instead of using qemu_system_reset_request()
to reset when a watchdog timer expires, let watchdog_perform_action() decide
what to do.

I am unsure about the changes in `spapr_watchdog.c` in patch 3, it would be great
if any of the maintainers review it.

Abhiram Tilak (3):
  misc: m48t59: replace qemu_system_reset_request() call with
    watchdog_perform_action()
  misc: pxa2xx_timer: replace qemu_system_reset_request() call with
    watchdog_perform_action()
  misc: ppc/spapr: replace qemu_system_reset_request() calls with
    watchdog_perform_action()

 hw/rtc/m48t59.c              | 4 ++--
 hw/timer/pxa2xx_timer.c      | 3 ++-
 hw/watchdog/spapr_watchdog.c | 3 ++-
 3 files changed, 6 insertions(+), 4 deletions(-)

--
2.42.1