[v3] mips: do not list individual devices from configs/

[PATCH v3 0/9] mips: do not list individual devices from configs/

Paolo Bonzini posted 9 patches 9 months, 2 weeks ago

Diff against v1 v1 v2
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20240213155005.109954-1-pbonzini@redhat.com

Maintainers: "Alex Bennée" <alex.bennee@linaro.org>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Thomas Huth <thuth@redhat.com>, Wainer dos Santos Moschetta <wainersm@redhat.com>, Beraldo Leal <bleal@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, Richard Henderson <richard.henderson@linaro.org>, Huacai Chen <chenhuacai@kernel.org>, Jiaxun Yang <jiaxun.yang@flygoat.com>, Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>, Gerd Hoffmann <kraxel@redhat.com>, Aurelien Jarno <aurelien@aurel32.net>

configs/devices/mips-softmmu/common.mak      | 28 +++--------------
configs/devices/mips64el-softmmu/default.mak |  3 --
include/hw/usb.h                             | 27 +++++++++++++++--
target/mips/tcg/translate.h                  |  1 +
target/mips/tcg/sysemu_helper.h.inc          | 19 ++++++++----
hw/isa/fdc37m81x-superio.c                   | 32 ++++++++++++++++++++
hw/isa/isa-superio.c                         | 18 -----------
hw/isa/smc37c669-superio.c                   |  1 -
hw/mips/loongson3_virt.c                     |  5 +--
hw/mips/mipssim.c                            |  7 +++--
hw/usb/bus.c                                 | 23 --------------
target/mips/tcg/sysemu/cp0_helper.c          |  8 +++++
target/mips/tcg/translate.c                  | 10 ++++++
.gitlab-ci.d/buildtest.yml                   |  2 +-
hw/display/Kconfig                           |  2 +-
hw/isa/Kconfig                               | 20 ++++++------
hw/isa/meson.build                           |  1 +
hw/mips/Kconfig                              | 25 ++++++++++++---
18 files changed, 134 insertions(+), 98 deletions(-)
create mode 100644 hw/isa/fdc37m81x-superio.c

Expand all Fold all

[PATCH v3 0/9] mips: do not list individual devices from configs/

Posted by Paolo Bonzini 9 months, 2 weeks ago

Back when Kconfig was introduced, the individual dependencies for MIPS
boards were never added to hw/mips/Kconfig.  Do it now.

To simplify the task, include a couple cleanups to the SuperIO chip
configuration symbols, as well as a change that makes USB device
creation available even when building without default devices.

Tested by comparing old and new kconfigs; and also by building each of
the boards one by one, with default devices disabled, and checking that
the board can be started.

Paolo

v2->v3:
- add a comment in mipssim.c
- reimplement "mips: allow compiling out CONFIG_MIPS_ITU"
- extract patch 8 ("mips/loongson3_virt: do not require CONFIG_USB")

Bernhard Beschow (1):
  hw/mips/Kconfig: Remove ISA dependencies from MIPSsim board

Paolo Bonzini (8):
  usb: inline device creation functions
  isa: clean up Kconfig selections for ISA_SUPERIO
  isa: fix ISA_SUPERIO dependencies
  isa: specify instance_size in isa_superio_type_info
  isa: extract FDC37M81X to a separate file
  mips: allow compiling out CONFIG_MIPS_ITU
  mips/loongson3_virt: do not require CONFIG_USB
  mips: do not list individual devices from configs/

 configs/devices/mips-softmmu/common.mak      | 28 +++--------------
 configs/devices/mips64el-softmmu/default.mak |  3 --
 include/hw/usb.h                             | 27 +++++++++++++++--
 target/mips/tcg/translate.h                  |  1 +
 target/mips/tcg/sysemu_helper.h.inc          | 19 ++++++++----
 hw/isa/fdc37m81x-superio.c                   | 32 ++++++++++++++++++++
 hw/isa/isa-superio.c                         | 18 -----------
 hw/isa/smc37c669-superio.c                   |  1 -
 hw/mips/loongson3_virt.c                     |  5 +--
 hw/mips/mipssim.c                            |  7 +++--
 hw/usb/bus.c                                 | 23 --------------
 target/mips/tcg/sysemu/cp0_helper.c          |  8 +++++
 target/mips/tcg/translate.c                  | 10 ++++++
 .gitlab-ci.d/buildtest.yml                   |  2 +-
 hw/display/Kconfig                           |  2 +-
 hw/isa/Kconfig                               | 20 ++++++------
 hw/isa/meson.build                           |  1 +
 hw/mips/Kconfig                              | 25 ++++++++++++---
 18 files changed, 134 insertions(+), 98 deletions(-)
 create mode 100644 hw/isa/fdc37m81x-superio.c

-- 
2.43.0

Re: [PATCH v3 0/9] mips: do not list individual devices from configs/

Posted by Philippe Mathieu-Daudé 9 months, 2 weeks ago

Hi,

On 13/2/24 16:49, Paolo Bonzini wrote:

> Bernhard Beschow (1):
>    hw/mips/Kconfig: Remove ISA dependencies from MIPSsim board
> 
> Paolo Bonzini (8):

>    isa: clean up Kconfig selections for ISA_SUPERIO
>    isa: fix ISA_SUPERIO dependencies
>    isa: specify instance_size in isa_superio_type_info
>    isa: extract FDC37M81X to a separate file

I'm a bit reluctant with the USB changes so far, so I'm queuing
these 5 patches meanwhile.

Regards,

Phil.