ci: Fix again build-previous-qemu

[PATCH] ci: Fix again build-previous-qemu

Posted by Paolo Bonzini 9 months, 2 weeks ago

The build-previous-qemu job is now trying to fetch from the upstream
repository, but the tag is only fetched into FETCH_HEAD:

$ git remote add upstream https://gitlab.com/qemu-project/qemu 00:00
$ git fetch upstream $QEMU_PREV_VERSION 00:02
warning: redirecting to https://gitlab.com/qemu-project/qemu.git/
From https://gitlab.com/qemu-project/qemu
 * tag                     v8.2.0     -> FETCH_HEAD
$ git checkout $QEMU_PREV_VERSION 00:02
error: pathspec v8.2.0 did not match any file(s) known to git

Fix by fetching the tag into the checkout itself.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 .gitlab-ci.d/buildtest.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml
index 3aead277246..901265af95d 100644
--- a/.gitlab-ci.d/buildtest.yml
+++ b/.gitlab-ci.d/buildtest.yml
@@ -190,7 +190,7 @@ build-previous-qemu:
   before_script:
     - export QEMU_PREV_VERSION="$(sed 's/\([0-9.]*\)\.[0-9]*/v\1.0/' VERSION)"
     - git remote add upstream https://gitlab.com/qemu-project/qemu
-    - git fetch upstream $QEMU_PREV_VERSION
+    - git fetch upstream refs/tags/$QEMU_PREV_VERSION:refs/tags/$QEMU_PREV_VERSION
     - git checkout $QEMU_PREV_VERSION
   after_script:
     - mv build build-previous
-- 
2.43.0

Re: [PATCH] ci: Fix again build-previous-qemu

Posted by Peter Xu 9 months, 1 week ago

On Tue, Feb 13, 2024 at 04:49:01PM +0100, Paolo Bonzini wrote:
> The build-previous-qemu job is now trying to fetch from the upstream
> repository, but the tag is only fetched into FETCH_HEAD:
> 
> $ git remote add upstream https://gitlab.com/qemu-project/qemu 00:00
> $ git fetch upstream $QEMU_PREV_VERSION 00:02
> warning: redirecting to https://gitlab.com/qemu-project/qemu.git/
> From https://gitlab.com/qemu-project/qemu
>  * tag                     v8.2.0     -> FETCH_HEAD
> $ git checkout $QEMU_PREV_VERSION 00:02
> error: pathspec v8.2.0 did not match any file(s) known to git
> 
> Fix by fetching the tag into the checkout itself.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Oops..  queued, thanks!

-- 
Peter Xu

Re: [PATCH] ci: Fix again build-previous-qemu

Posted by Fabiano Rosas 9 months, 2 weeks ago

Paolo Bonzini <pbonzini@redhat.com> writes:

> The build-previous-qemu job is now trying to fetch from the upstream
> repository, but the tag is only fetched into FETCH_HEAD:
>
> $ git remote add upstream https://gitlab.com/qemu-project/qemu 00:00
> $ git fetch upstream $QEMU_PREV_VERSION 00:02
> warning: redirecting to https://gitlab.com/qemu-project/qemu.git/
> From https://gitlab.com/qemu-project/qemu
>  * tag                     v8.2.0     -> FETCH_HEAD
> $ git checkout $QEMU_PREV_VERSION 00:02
> error: pathspec v8.2.0 did not match any file(s) known to git
>
> Fix by fetching the tag into the checkout itself.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Reviewed-by: Fabiano Rosas <farosas@suse.de>