1. Patchew
  2. QEMU
  3. [PATCH 0/9] hw/ide/ahci: Housekeeping
  4. View patch

[PATCH 9/9] hw/ide/ahci: Move SysBus definitions to 'ahci-sysbus.h'

Philippe Mathieu-Daudé posted 9 patches 1 year, 12 months ago
Maintainers: Rob Herring <robh@kernel.org>, Peter Maydell <peter.maydell@linaro.org>, Radoslaw Biernacki <rad@semihalf.com>, Leif Lindholm <quic_llindhol@quicinc.com>, Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>, Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <richard.henderson@linaro.org>, Eduardo Habkost <eduardo@habkost.net>, "Michael S. Tsirkin" <mst@redhat.com>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, John Snow <jsnow@redhat.com>, Paul Burton <paulburton@kernel.org>, Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Beniamino Galvani <b.galvani@gmail.com>, Strahinja Jankovic <strahinja.p.jankovic@gmail.com>, Alistair Francis <alistair@alistair23.me>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
[PATCH 9/9] hw/ide/ahci: Move SysBus definitions to 'ahci-sysbus.h'
Posted by Philippe Mathieu-Daudé 1 year, 12 months ago 
Keep "hw/ide/ahci.h" AHCI-generic.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 include/hw/arm/allwinner-a10.h |  2 +-
 include/hw/arm/allwinner-r40.h |  2 +-
 include/hw/arm/xlnx-zynqmp.h   |  2 +-
 include/hw/ide/ahci-sysbus.h   | 35 ++++++++++++++++++++++++++++++++++
 include/hw/ide/ahci.h          | 29 +---------------------------
 hw/arm/highbank.c              |  2 +-
 hw/arm/sbsa-ref.c              |  1 +
 hw/ide/ahci-allwinner.c        |  3 +--
 hw/ide/ahci.c                  |  1 +
 9 files changed, 43 insertions(+), 34 deletions(-)
 create mode 100644 include/hw/ide/ahci-sysbus.h

diff --git a/include/hw/arm/allwinner-a10.h b/include/hw/arm/allwinner-a10.h
index 2eb83a17ea..67a9a17b86 100644
--- a/include/hw/arm/allwinner-a10.h
+++ b/include/hw/arm/allwinner-a10.h
@@ -5,7 +5,7 @@
 #include "hw/intc/allwinner-a10-pic.h"
 #include "hw/net/allwinner_emac.h"
 #include "hw/sd/allwinner-sdhost.h"
-#include "hw/ide/ahci.h"
+#include "hw/ide/ahci-sysbus.h"
 #include "hw/usb/hcd-ohci.h"
 #include "hw/usb/hcd-ehci.h"
 #include "hw/rtc/allwinner-rtc.h"
diff --git a/include/hw/arm/allwinner-r40.h b/include/hw/arm/allwinner-r40.h
index 66c38e7d90..614e74b7ed 100644
--- a/include/hw/arm/allwinner-r40.h
+++ b/include/hw/arm/allwinner-r40.h
@@ -22,7 +22,7 @@
 
 #include "qom/object.h"
 #include "hw/timer/allwinner-a10-pit.h"
-#include "hw/ide/ahci.h"
+#include "hw/ide/ahci-sysbus.h"
 #include "hw/intc/arm_gic.h"
 #include "hw/sd/allwinner-sdhost.h"
 #include "hw/misc/allwinner-r40-ccu.h"
diff --git a/include/hw/arm/xlnx-zynqmp.h b/include/hw/arm/xlnx-zynqmp.h
index 96358d51eb..48f7948092 100644
--- a/include/hw/arm/xlnx-zynqmp.h
+++ b/include/hw/arm/xlnx-zynqmp.h
@@ -22,7 +22,7 @@
 #include "hw/net/cadence_gem.h"
 #include "hw/char/cadence_uart.h"
 #include "hw/net/xlnx-zynqmp-can.h"
-#include "hw/ide/ahci.h"
+#include "hw/ide/ahci-sysbus.h"
 #include "hw/sd/sdhci.h"
 #include "hw/ssi/xilinx_spips.h"
 #include "hw/dma/xlnx_dpdma.h"
diff --git a/include/hw/ide/ahci-sysbus.h b/include/hw/ide/ahci-sysbus.h
new file mode 100644
index 0000000000..7ed6cad496
--- /dev/null
+++ b/include/hw/ide/ahci-sysbus.h
@@ -0,0 +1,35 @@
+/*
+ * QEMU AHCI Emulation (MMIO-mapped devices)
+ *
+ * SPDX-License-Identifier: GPL-2.0-or-later
+ */
+#ifndef HW_IDE_AHCI_SYSBUS_H
+#define HW_IDE_AHCI_SYSBUS_H
+
+#include "qom/object.h"
+#include "hw/sysbus.h"
+#include "hw/ide/ahci.h"
+
+#define TYPE_SYSBUS_AHCI "sysbus-ahci"
+OBJECT_DECLARE_SIMPLE_TYPE(SysbusAHCIState, SYSBUS_AHCI)
+
+struct SysbusAHCIState {
+    SysBusDevice parent_obj;
+
+    AHCIState ahci;
+};
+
+#define TYPE_ALLWINNER_AHCI "allwinner-ahci"
+OBJECT_DECLARE_SIMPLE_TYPE(AllwinnerAHCIState, ALLWINNER_AHCI)
+
+#define ALLWINNER_AHCI_MMIO_OFF  0x80
+#define ALLWINNER_AHCI_MMIO_SIZE 0x80
+
+struct AllwinnerAHCIState {
+    SysbusAHCIState parent_obj;
+
+    MemoryRegion mmio;
+    uint32_t regs[ALLWINNER_AHCI_MMIO_SIZE/4];
+};
+
+#endif
diff --git a/include/hw/ide/ahci.h b/include/hw/ide/ahci.h
index c0b10c2bb4..ba31e75ff9 100644
--- a/include/hw/ide/ahci.h
+++ b/include/hw/ide/ahci.h
@@ -24,8 +24,7 @@
 #ifndef HW_IDE_AHCI_H
 #define HW_IDE_AHCI_H
 
-#include "hw/sysbus.h"
-#include "qom/object.h"
+#include "exec/memory.h"
 
 typedef struct AHCIDevice AHCIDevice;
 
@@ -54,30 +53,4 @@ typedef struct AHCIState {
 
 void ahci_ide_create_devs(AHCIState *ahci, DriveInfo **hd);
 
-#define TYPE_SYSBUS_AHCI "sysbus-ahci"
-OBJECT_DECLARE_SIMPLE_TYPE(SysbusAHCIState, SYSBUS_AHCI)
-
-struct SysbusAHCIState {
-    /*< private >*/
-    SysBusDevice parent_obj;
-    /*< public >*/
-
-    AHCIState ahci;
-};
-
-#define TYPE_ALLWINNER_AHCI "allwinner-ahci"
-OBJECT_DECLARE_SIMPLE_TYPE(AllwinnerAHCIState, ALLWINNER_AHCI)
-
-#define ALLWINNER_AHCI_MMIO_OFF  0x80
-#define ALLWINNER_AHCI_MMIO_SIZE 0x80
-
-struct AllwinnerAHCIState {
-    /*< private >*/
-    SysbusAHCIState parent_obj;
-    /*< public >*/
-
-    MemoryRegion mmio;
-    uint32_t regs[ALLWINNER_AHCI_MMIO_SIZE/4];
-};
-
 #endif /* HW_IDE_AHCI_H */
diff --git a/hw/arm/highbank.c b/hw/arm/highbank.c
index 9fdac1cc81..c71b1a8db3 100644
--- a/hw/arm/highbank.c
+++ b/hw/arm/highbank.c
@@ -30,7 +30,7 @@
 #include "hw/boards.h"
 #include "qemu/error-report.h"
 #include "hw/char/pl011.h"
-#include "hw/ide/ahci.h"
+#include "hw/ide/ahci-sysbus.h"
 #include "hw/cpu/a9mpcore.h"
 #include "hw/cpu/a15mpcore.h"
 #include "qemu/log.h"
diff --git a/hw/arm/sbsa-ref.c b/hw/arm/sbsa-ref.c
index f2adf30337..5d3a574664 100644
--- a/hw/arm/sbsa-ref.c
+++ b/hw/arm/sbsa-ref.c
@@ -38,6 +38,7 @@
 #include "hw/boards.h"
 #include "hw/ide/internal.h"
 #include "hw/ide/ahci_internal.h"
+#include "hw/ide/ahci-sysbus.h"
 #include "hw/intc/arm_gicv3_common.h"
 #include "hw/intc/arm_gicv3_its_common.h"
 #include "hw/loader.h"
diff --git a/hw/ide/ahci-allwinner.c b/hw/ide/ahci-allwinner.c
index b173121006..9620de8ce8 100644
--- a/hw/ide/ahci-allwinner.c
+++ b/hw/ide/ahci-allwinner.c
@@ -19,9 +19,8 @@
 #include "qemu/error-report.h"
 #include "qemu/module.h"
 #include "sysemu/dma.h"
-#include "hw/ide/internal.h"
 #include "migration/vmstate.h"
-#include "ahci_internal.h"
+#include "hw/ide/ahci-sysbus.h"
 
 #include "trace.h"
 
diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
index 041cc87c11..54c9685495 100644
--- a/hw/ide/ahci.c
+++ b/hw/ide/ahci.c
@@ -37,6 +37,7 @@
 #include "hw/ide/internal.h"
 #include "hw/ide/pci.h"
 #include "hw/ide/ahci-pci.h"
+#include "hw/ide/ahci-sysbus.h"
 #include "ahci_internal.h"
 
 #include "trace.h"
-- 
2.41.0
Re: [PATCH 9/9] hw/ide/ahci: Move SysBus definitions to 'ahci-sysbus.h'
Posted by Leif Lindholm 1 year, 12 months ago 
On 2024-02-13 08:12, Philippe Mathieu-Daudé wrote:
> Keep "hw/ide/ahci.h" AHCI-generic.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   include/hw/arm/allwinner-a10.h |  2 +-
>   include/hw/arm/allwinner-r40.h |  2 +-
>   include/hw/arm/xlnx-zynqmp.h   |  2 +-
>   include/hw/ide/ahci-sysbus.h   | 35 ++++++++++++++++++++++++++++++++++
>   include/hw/ide/ahci.h          | 29 +---------------------------
>   hw/arm/highbank.c              |  2 +-
>   hw/arm/sbsa-ref.c              |  1 +

Obviously, if the actual functional change happens, I'd be happy for 
sbsa-ref to keep building, so for that aspect:
Reviewed-by: Leif Lindholm <quic_llindhol@quicinc.com>

/
     Leif

>   hw/ide/ahci-allwinner.c        |  3 +--
>   hw/ide/ahci.c                  |  1 +
>   9 files changed, 43 insertions(+), 34 deletions(-)
>   create mode 100644 include/hw/ide/ahci-sysbus.h
> 
> diff --git a/include/hw/arm/allwinner-a10.h b/include/hw/arm/allwinner-a10.h
> index 2eb83a17ea..67a9a17b86 100644
> --- a/include/hw/arm/allwinner-a10.h
> +++ b/include/hw/arm/allwinner-a10.h
> @@ -5,7 +5,7 @@
>   #include "hw/intc/allwinner-a10-pic.h"
>   #include "hw/net/allwinner_emac.h"
>   #include "hw/sd/allwinner-sdhost.h"
> -#include "hw/ide/ahci.h"
> +#include "hw/ide/ahci-sysbus.h"
>   #include "hw/usb/hcd-ohci.h"
>   #include "hw/usb/hcd-ehci.h"
>   #include "hw/rtc/allwinner-rtc.h"
> diff --git a/include/hw/arm/allwinner-r40.h b/include/hw/arm/allwinner-r40.h
> index 66c38e7d90..614e74b7ed 100644
> --- a/include/hw/arm/allwinner-r40.h
> +++ b/include/hw/arm/allwinner-r40.h
> @@ -22,7 +22,7 @@
>   
>   #include "qom/object.h"
>   #include "hw/timer/allwinner-a10-pit.h"
> -#include "hw/ide/ahci.h"
> +#include "hw/ide/ahci-sysbus.h"
>   #include "hw/intc/arm_gic.h"
>   #include "hw/sd/allwinner-sdhost.h"
>   #include "hw/misc/allwinner-r40-ccu.h"
> diff --git a/include/hw/arm/xlnx-zynqmp.h b/include/hw/arm/xlnx-zynqmp.h
> index 96358d51eb..48f7948092 100644
> --- a/include/hw/arm/xlnx-zynqmp.h
> +++ b/include/hw/arm/xlnx-zynqmp.h
> @@ -22,7 +22,7 @@
>   #include "hw/net/cadence_gem.h"
>   #include "hw/char/cadence_uart.h"
>   #include "hw/net/xlnx-zynqmp-can.h"
> -#include "hw/ide/ahci.h"
> +#include "hw/ide/ahci-sysbus.h"
>   #include "hw/sd/sdhci.h"
>   #include "hw/ssi/xilinx_spips.h"
>   #include "hw/dma/xlnx_dpdma.h"
> diff --git a/include/hw/ide/ahci-sysbus.h b/include/hw/ide/ahci-sysbus.h
> new file mode 100644
> index 0000000000..7ed6cad496
> --- /dev/null
> +++ b/include/hw/ide/ahci-sysbus.h
> @@ -0,0 +1,35 @@
> +/*
> + * QEMU AHCI Emulation (MMIO-mapped devices)
> + *
> + * SPDX-License-Identifier: GPL-2.0-or-later
> + */
> +#ifndef HW_IDE_AHCI_SYSBUS_H
> +#define HW_IDE_AHCI_SYSBUS_H
> +
> +#include "qom/object.h"
> +#include "hw/sysbus.h"
> +#include "hw/ide/ahci.h"
> +
> +#define TYPE_SYSBUS_AHCI "sysbus-ahci"
> +OBJECT_DECLARE_SIMPLE_TYPE(SysbusAHCIState, SYSBUS_AHCI)
> +
> +struct SysbusAHCIState {
> +    SysBusDevice parent_obj;
> +
> +    AHCIState ahci;
> +};
> +
> +#define TYPE_ALLWINNER_AHCI "allwinner-ahci"
> +OBJECT_DECLARE_SIMPLE_TYPE(AllwinnerAHCIState, ALLWINNER_AHCI)
> +
> +#define ALLWINNER_AHCI_MMIO_OFF  0x80
> +#define ALLWINNER_AHCI_MMIO_SIZE 0x80
> +
> +struct AllwinnerAHCIState {
> +    SysbusAHCIState parent_obj;
> +
> +    MemoryRegion mmio;
> +    uint32_t regs[ALLWINNER_AHCI_MMIO_SIZE/4];
> +};
> +
> +#endif
> diff --git a/include/hw/ide/ahci.h b/include/hw/ide/ahci.h
> index c0b10c2bb4..ba31e75ff9 100644
> --- a/include/hw/ide/ahci.h
> +++ b/include/hw/ide/ahci.h
> @@ -24,8 +24,7 @@
>   #ifndef HW_IDE_AHCI_H
>   #define HW_IDE_AHCI_H
>   
> -#include "hw/sysbus.h"
> -#include "qom/object.h"
> +#include "exec/memory.h"
>   
>   typedef struct AHCIDevice AHCIDevice;
>   
> @@ -54,30 +53,4 @@ typedef struct AHCIState {
>   
>   void ahci_ide_create_devs(AHCIState *ahci, DriveInfo **hd);
>   
> -#define TYPE_SYSBUS_AHCI "sysbus-ahci"
> -OBJECT_DECLARE_SIMPLE_TYPE(SysbusAHCIState, SYSBUS_AHCI)
> -
> -struct SysbusAHCIState {
> -    /*< private >*/
> -    SysBusDevice parent_obj;
> -    /*< public >*/
> -
> -    AHCIState ahci;
> -};
> -
> -#define TYPE_ALLWINNER_AHCI "allwinner-ahci"
> -OBJECT_DECLARE_SIMPLE_TYPE(AllwinnerAHCIState, ALLWINNER_AHCI)
> -
> -#define ALLWINNER_AHCI_MMIO_OFF  0x80
> -#define ALLWINNER_AHCI_MMIO_SIZE 0x80
> -
> -struct AllwinnerAHCIState {
> -    /*< private >*/
> -    SysbusAHCIState parent_obj;
> -    /*< public >*/
> -
> -    MemoryRegion mmio;
> -    uint32_t regs[ALLWINNER_AHCI_MMIO_SIZE/4];
> -};
> -
>   #endif /* HW_IDE_AHCI_H */
> diff --git a/hw/arm/highbank.c b/hw/arm/highbank.c
> index 9fdac1cc81..c71b1a8db3 100644
> --- a/hw/arm/highbank.c
> +++ b/hw/arm/highbank.c
> @@ -30,7 +30,7 @@
>   #include "hw/boards.h"
>   #include "qemu/error-report.h"
>   #include "hw/char/pl011.h"
> -#include "hw/ide/ahci.h"
> +#include "hw/ide/ahci-sysbus.h"
>   #include "hw/cpu/a9mpcore.h"
>   #include "hw/cpu/a15mpcore.h"
>   #include "qemu/log.h"
> diff --git a/hw/arm/sbsa-ref.c b/hw/arm/sbsa-ref.c
> index f2adf30337..5d3a574664 100644
> --- a/hw/arm/sbsa-ref.c
> +++ b/hw/arm/sbsa-ref.c
> @@ -38,6 +38,7 @@
>   #include "hw/boards.h"
>   #include "hw/ide/internal.h"
>   #include "hw/ide/ahci_internal.h"
> +#include "hw/ide/ahci-sysbus.h"
>   #include "hw/intc/arm_gicv3_common.h"
>   #include "hw/intc/arm_gicv3_its_common.h"
>   #include "hw/loader.h"
> diff --git a/hw/ide/ahci-allwinner.c b/hw/ide/ahci-allwinner.c
> index b173121006..9620de8ce8 100644
> --- a/hw/ide/ahci-allwinner.c
> +++ b/hw/ide/ahci-allwinner.c
> @@ -19,9 +19,8 @@
>   #include "qemu/error-report.h"
>   #include "qemu/module.h"
>   #include "sysemu/dma.h"
> -#include "hw/ide/internal.h"
>   #include "migration/vmstate.h"
> -#include "ahci_internal.h"
> +#include "hw/ide/ahci-sysbus.h"
>   
>   #include "trace.h"
>   
> diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
> index 041cc87c11..54c9685495 100644
> --- a/hw/ide/ahci.c
> +++ b/hw/ide/ahci.c
> @@ -37,6 +37,7 @@
>   #include "hw/ide/internal.h"
>   #include "hw/ide/pci.h"
>   #include "hw/ide/ahci-pci.h"
> +#include "hw/ide/ahci-sysbus.h"
>   #include "ahci_internal.h"
>   
>   #include "trace.h"

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.