hw/ide/ahci: Housekeeping

[PATCH 0/9] hw/ide/ahci: Housekeeping

Philippe Mathieu-Daudé posted 9 patches 9 months, 2 weeks ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20240213081201.78951-1-philmd@linaro.org

Maintainers: Rob Herring <robh@kernel.org>, Peter Maydell <peter.maydell@linaro.org>, Radoslaw Biernacki <rad@semihalf.com>, Leif Lindholm <quic_llindhol@quicinc.com>, Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>, Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <richard.henderson@linaro.org>, Eduardo Habkost <eduardo@habkost.net>, "Michael S. Tsirkin" <mst@redhat.com>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, John Snow <jsnow@redhat.com>, Paul Burton <paulburton@kernel.org>, Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Beniamino Galvani <b.galvani@gmail.com>, Strahinja Jankovic <strahinja.p.jankovic@gmail.com>, Alistair Francis <alistair@alistair23.me>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>

hw/ide/ahci_internal.h         | 10 +--------
include/hw/arm/allwinner-a10.h |  2 +-
include/hw/arm/allwinner-r40.h |  2 +-
include/hw/arm/xlnx-zynqmp.h   |  2 +-
include/hw/ide/ahci-pci.h      | 22 ++++++++++++++++++++
include/hw/ide/ahci-sysbus.h   | 35 +++++++++++++++++++++++++++++++
include/hw/ide/ahci.h          | 38 +++-------------------------------
hw/arm/highbank.c              |  2 +-
hw/arm/sbsa-ref.c              |  1 +
hw/i386/pc_q35.c               | 19 ++++++++++-------
hw/ide/ahci-allwinner.c        |  3 +--
hw/ide/ahci.c                  | 29 +++++++++-----------------
hw/ide/ich.c                   |  4 +++-
hw/mips/boston.c               | 14 +++++++------
14 files changed, 99 insertions(+), 84 deletions(-)
create mode 100644 include/hw/ide/ahci-pci.h
create mode 100644 include/hw/ide/ahci-sysbus.h

Expand all Fold all

[PATCH 0/9] hw/ide/ahci: Housekeeping

Posted by Philippe Mathieu-Daudé 9 months, 2 weeks ago

- Split 'ahci.h' as sysbus / pci
- Inline ahci_get_num_ports()
- Directly use AHCIState::ports instead of SysbusAHCIState::num_ports

Philippe Mathieu-Daudé (9):
  hw/i386/q35: Use DEVICE() cast macro with PCIDevice object
  hw/ide/ahci: Expose AHCIPCIState structure
  hw/ide/ahci: Rename AHCI PCI function as 'pdev'
  hw/ide/ahci: Inline ahci_get_num_ports()
  hw/ide/ahci: Pass AHCI context to ahci_ide_create_devs()
  hw/ide/ahci: Convert AHCIState::ports to unsigned
  hw/ide/ahci: Do not pass 'ports' argument to ahci_realize()
  hw/ide/ahci: Remove SysbusAHCIState::num_ports field
  hw/ide/ahci: Move SysBus definitions to 'ahci-sysbus.h'

 hw/ide/ahci_internal.h         | 10 +--------
 include/hw/arm/allwinner-a10.h |  2 +-
 include/hw/arm/allwinner-r40.h |  2 +-
 include/hw/arm/xlnx-zynqmp.h   |  2 +-
 include/hw/ide/ahci-pci.h      | 22 ++++++++++++++++++++
 include/hw/ide/ahci-sysbus.h   | 35 +++++++++++++++++++++++++++++++
 include/hw/ide/ahci.h          | 38 +++-------------------------------
 hw/arm/highbank.c              |  2 +-
 hw/arm/sbsa-ref.c              |  1 +
 hw/i386/pc_q35.c               | 19 ++++++++++-------
 hw/ide/ahci-allwinner.c        |  3 +--
 hw/ide/ahci.c                  | 29 +++++++++-----------------
 hw/ide/ich.c                   |  4 +++-
 hw/mips/boston.c               | 14 +++++++------
 14 files changed, 99 insertions(+), 84 deletions(-)
 create mode 100644 include/hw/ide/ahci-pci.h
 create mode 100644 include/hw/ide/ahci-sysbus.h

-- 
2.41.0

Re: [PATCH 0/9] hw/ide/ahci: Housekeeping

Posted by Michael S. Tsirkin 9 months, 2 weeks ago

On Tue, Feb 13, 2024 at 09:11:51AM +0100, Philippe Mathieu-Daudé wrote:
> - Split 'ahci.h' as sysbus / pci
> - Inline ahci_get_num_ports()
> - Directly use AHCIState::ports instead of SysbusAHCIState::num_ports


PC part:

Reviewed-by: Michael S. Tsirkin <mst@redhat.com>

feel free to merge with rest of patches.


> Philippe Mathieu-Daudé (9):
>   hw/i386/q35: Use DEVICE() cast macro with PCIDevice object
>   hw/ide/ahci: Expose AHCIPCIState structure
>   hw/ide/ahci: Rename AHCI PCI function as 'pdev'
>   hw/ide/ahci: Inline ahci_get_num_ports()
>   hw/ide/ahci: Pass AHCI context to ahci_ide_create_devs()
>   hw/ide/ahci: Convert AHCIState::ports to unsigned
>   hw/ide/ahci: Do not pass 'ports' argument to ahci_realize()
>   hw/ide/ahci: Remove SysbusAHCIState::num_ports field
>   hw/ide/ahci: Move SysBus definitions to 'ahci-sysbus.h'
> 
>  hw/ide/ahci_internal.h         | 10 +--------
>  include/hw/arm/allwinner-a10.h |  2 +-
>  include/hw/arm/allwinner-r40.h |  2 +-
>  include/hw/arm/xlnx-zynqmp.h   |  2 +-
>  include/hw/ide/ahci-pci.h      | 22 ++++++++++++++++++++
>  include/hw/ide/ahci-sysbus.h   | 35 +++++++++++++++++++++++++++++++
>  include/hw/ide/ahci.h          | 38 +++-------------------------------
>  hw/arm/highbank.c              |  2 +-
>  hw/arm/sbsa-ref.c              |  1 +
>  hw/i386/pc_q35.c               | 19 ++++++++++-------
>  hw/ide/ahci-allwinner.c        |  3 +--
>  hw/ide/ahci.c                  | 29 +++++++++-----------------
>  hw/ide/ich.c                   |  4 +++-
>  hw/mips/boston.c               | 14 +++++++------
>  14 files changed, 99 insertions(+), 84 deletions(-)
>  create mode 100644 include/hw/ide/ahci-pci.h
>  create mode 100644 include/hw/ide/ahci-sysbus.h
> 
> -- 
> 2.41.0

Re: [PATCH 0/9] hw/ide/ahci: Housekeeping

Posted by Philippe Mathieu-Daudé 9 months, 2 weeks ago

On 13/2/24 09:11, Philippe Mathieu-Daudé wrote:
> - Split 'ahci.h' as sysbus / pci
> - Inline ahci_get_num_ports()
> - Directly use AHCIState::ports instead of SysbusAHCIState::num_ports
> 
> Philippe Mathieu-Daudé (9):
>    hw/i386/q35: Use DEVICE() cast macro with PCIDevice object
>    hw/ide/ahci: Expose AHCIPCIState structure
>    hw/ide/ahci: Rename AHCI PCI function as 'pdev'
>    hw/ide/ahci: Inline ahci_get_num_ports()
>    hw/ide/ahci: Pass AHCI context to ahci_ide_create_devs()
>    hw/ide/ahci: Convert AHCIState::ports to unsigned
>    hw/ide/ahci: Do not pass 'ports' argument to ahci_realize()
>    hw/ide/ahci: Remove SysbusAHCIState::num_ports field
>    hw/ide/ahci: Move SysBus definitions to 'ahci-sysbus.h'

Series queued.