[v1] Hppa64 patches

[PULL 00/12] Hppa64 patches

Posted by deller@kernel.org 11 months, 1 week ago

From: Helge Deller <deller@gmx.de>

The following changes since commit 39a6e4f87e7b75a45b08d6dc8b8b7c2954c87440:

  Merge tag 'pull-qapi-2024-02-03' of https://repo.or.cz/qemu/armbru into staging (2024-02-03 13:31:58 +0000)

are available in the Git repository at:

  https://github.com/hdeller/qemu-hppa.git tags/hppa64-pull-request

for you to fetch changes up to a9314795f068515ff5925d0f68adf0a3215f6d2d:

  hw/hppa/machine: Load 64-bit firmware on 64-bit machines (2024-02-13 00:44:06 +0100)

----------------------------------------------------------------
target/hppa: Enhancements and fixes

Some enhancements and fixes for the hppa target.

The major change is, that this patchset adds a new SeaBIOS-hppa firmware
which is built as 32- and 64-bit firmware.
The new 64-bit firmware is necessary to fully support 64-bit operating systems
(HP-UX, Linux, NetBSD,...).

----------------------------------------------------------------

Helge Deller (11):
  disas/hppa: Add disassembly for qemu specific instructions
  target/hppa: Add "diag 0x101" for console output support
  hw/pci-host/astro: Avoid aborting on access failure
  hw/pci-host/astro: Implement Hard Fail and Soft Fail mode
  lasi: allow access to LAN MAC address registers
  target/hppa: Implement do_transaction_failed handler for I/O errors
  lasi: Add reset I/O ports for LASI audio and FDC
  target/hppa: Allow read-access to PSW with rsm 0,reg instruction
  target/hppa: PDC_BTLB_INFO uses 32-bit ints
  target/hppa: Update SeaBIOS-hppa to version 16
  hw/hppa/machine: Load 64-bit firmware on 64-bit machines

Sven Schnelle (1):
  hw/net/tulip: add chip status register values

 disas/hppa.c                |   4 +++
 hw/hppa/machine.c           |  52 +++++++++++++++++++++---------------
 hw/misc/lasi.c              |  13 +++++++++
 hw/net/tulip.c              |   4 +--
 hw/pci-host/astro.c         |  36 ++++++++++++++-----------
 include/hw/misc/lasi.h      |   2 ++
 include/hw/pci-host/astro.h |   2 ++
 pc-bios/hppa-firmware.img   | Bin 163324 -> 167820 bytes
 pc-bios/hppa-firmware64.img | Bin 0 -> 206024 bytes
 roms/seabios-hppa           |   2 +-
 target/hppa/cpu.c           |   1 +
 target/hppa/cpu.h           |   5 ++++
 target/hppa/helper.h        |   1 +
 target/hppa/mem_helper.c    |  21 ++++++++++++++-
 target/hppa/sys_helper.c    |  36 +++++++++++++++++++++++++
 target/hppa/translate.c     |  14 +++++++++-
 16 files changed, 150 insertions(+), 43 deletions(-)
 mode change 100644 => 100755 pc-bios/hppa-firmware.img
 create mode 100755 pc-bios/hppa-firmware64.img

-- 
2.43.0

Re: [PULL 00/12] Hppa64 patches

Posted by Peter Maydell 11 months, 1 week ago

On Mon, 12 Feb 2024 at 23:49, <deller@kernel.org> wrote:
>
> From: Helge Deller <deller@gmx.de>
>
> The following changes since commit 39a6e4f87e7b75a45b08d6dc8b8b7c2954c87440:
>
>   Merge tag 'pull-qapi-2024-02-03' of https://repo.or.cz/qemu/armbru into staging (2024-02-03 13:31:58 +0000)
>
> are available in the Git repository at:
>
>   https://github.com/hdeller/qemu-hppa.git tags/hppa64-pull-request
>
> for you to fetch changes up to a9314795f068515ff5925d0f68adf0a3215f6d2d:
>
>   hw/hppa/machine: Load 64-bit firmware on 64-bit machines (2024-02-13 00:44:06 +0100)
>
> ----------------------------------------------------------------
> target/hppa: Enhancements and fixes
>
> Some enhancements and fixes for the hppa target.
>
> The major change is, that this patchset adds a new SeaBIOS-hppa firmware
> which is built as 32- and 64-bit firmware.
> The new 64-bit firmware is necessary to fully support 64-bit operating systems
> (HP-UX, Linux, NetBSD,...).
>


Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/9.0
for any user-visible changes.

-- PMM

Re: [PULL 00/12] Hppa64 patches

Posted by Michael Tokarev 11 months, 1 week ago

13.02.2024 02:47, deller@kernel.org пишет:
> From: Helge Deller <deller@gmx.de>
> 
> The following changes since commit 39a6e4f87e7b75a45b08d6dc8b8b7c2954c87440:
> 
>    Merge tag 'pull-qapi-2024-02-03' of https://repo.or.cz/qemu/armbru into staging (2024-02-03 13:31:58 +0000)
> 
> are available in the Git repository at:
> 
>    https://github.com/hdeller/qemu-hppa.git tags/hppa64-pull-request
> 
> for you to fetch changes up to a9314795f068515ff5925d0f68adf0a3215f6d2d:
> 
>    hw/hppa/machine: Load 64-bit firmware on 64-bit machines (2024-02-13 00:44:06 +0100)
> 
> ----------------------------------------------------------------
> target/hppa: Enhancements and fixes
> 
> Some enhancements and fixes for the hppa target.
> 
> The major change is, that this patchset adds a new SeaBIOS-hppa firmware
> which is built as 32- and 64-bit firmware.
> The new 64-bit firmware is necessary to fully support 64-bit operating systems
> (HP-UX, Linux, NetBSD,...).
> 
> ----------------------------------------------------------------
> 
> Helge Deller (11):
>    disas/hppa: Add disassembly for qemu specific instructions
>    target/hppa: Add "diag 0x101" for console output support
>    hw/pci-host/astro: Avoid aborting on access failure
>    hw/pci-host/astro: Implement Hard Fail and Soft Fail mode
>    lasi: allow access to LAN MAC address registers
>    target/hppa: Implement do_transaction_failed handler for I/O errors
>    lasi: Add reset I/O ports for LASI audio and FDC
>    target/hppa: Allow read-access to PSW with rsm 0,reg instruction
>    target/hppa: PDC_BTLB_INFO uses 32-bit ints
>    target/hppa: Update SeaBIOS-hppa to version 16
>    hw/hppa/machine: Load 64-bit firmware on 64-bit machines
> 
> Sven Schnelle (1):
>    hw/net/tulip: add chip status register values

Is there anything in there which is relevant for -stable?
The seabios-hppa update gives quite some hints.

Thanks,

/mjt

Re: [PULL 00/12] Hppa64 patches

Posted by Helge Deller 11 months, 1 week ago

On 2/13/24 19:09, Michael Tokarev wrote:
> 13.02.2024 02:47, deller@kernel.org пишет:
>> From: Helge Deller <deller@gmx.de>
>>
>> The following changes since commit 39a6e4f87e7b75a45b08d6dc8b8b7c2954c87440:
>>
>>    Merge tag 'pull-qapi-2024-02-03' of https://repo.or.cz/qemu/armbru into staging (2024-02-03 13:31:58 +0000)
>>
>> are available in the Git repository at:
>>
>>    https://github.com/hdeller/qemu-hppa.git tags/hppa64-pull-request
>>
>> for you to fetch changes up to a9314795f068515ff5925d0f68adf0a3215f6d2d:
>>
>>    hw/hppa/machine: Load 64-bit firmware on 64-bit machines (2024-02-13 00:44:06 +0100)
>>
>> ----------------------------------------------------------------
>> target/hppa: Enhancements and fixes
>>
>> Some enhancements and fixes for the hppa target.
>>
>> The major change is, that this patchset adds a new SeaBIOS-hppa firmware
>> which is built as 32- and 64-bit firmware.
>> The new 64-bit firmware is necessary to fully support 64-bit operating systems
>> (HP-UX, Linux, NetBSD,...).
>>
>> ----------------------------------------------------------------
>>
>> Helge Deller (11):
>>    disas/hppa: Add disassembly for qemu specific instructions
>>    target/hppa: Add "diag 0x101" for console output support
>>    hw/pci-host/astro: Avoid aborting on access failure
>>    hw/pci-host/astro: Implement Hard Fail and Soft Fail mode
>>    lasi: allow access to LAN MAC address registers
>>    target/hppa: Implement do_transaction_failed handler for I/O errors
>>    lasi: Add reset I/O ports for LASI audio and FDC
>>    target/hppa: Allow read-access to PSW with rsm 0,reg instruction
>>    target/hppa: PDC_BTLB_INFO uses 32-bit ints
>>    target/hppa: Update SeaBIOS-hppa to version 16
>>    hw/hppa/machine: Load 64-bit firmware on 64-bit machines
>>
>> Sven Schnelle (1):
>>    hw/net/tulip: add chip status register values
>
> Is there anything in there which is relevant for -stable?

Ideally all patches.
At minimum the tulip patch.

Helge

Re: [PULL 00/12] Hppa64 patches

Posted by Michael Tokarev 11 months, 1 week ago

13.02.2024 22:16, Helge Deller:
> On 2/13/24 19:09, Michael Tokarev wrote:
>> 13.02.2024 02:47, deller@kernel.org:

>>> Helge Deller (11):
>>>    disas/hppa: Add disassembly for qemu specific instructions
>>>    target/hppa: Add "diag 0x101" for console output support
>>>    hw/pci-host/astro: Avoid aborting on access failure
>>>    hw/pci-host/astro: Implement Hard Fail and Soft Fail mode
>>>    lasi: allow access to LAN MAC address registers
>>>    target/hppa: Implement do_transaction_failed handler for I/O errors
>>>    lasi: Add reset I/O ports for LASI audio and FDC
>>>    target/hppa: Allow read-access to PSW with rsm 0,reg instruction
>>>    target/hppa: PDC_BTLB_INFO uses 32-bit ints
>>>    target/hppa: Update SeaBIOS-hppa to version 16
>>>    hw/hppa/machine: Load 64-bit firmware on 64-bit machines
>>>
>>> Sven Schnelle (1):
>>>    hw/net/tulip: add chip status register values
>>
>> Is there anything in there which is relevant for -stable?
> 
> Ideally all patches.
> At minimum the tulip patch.

Heh.

Ideally there's no bugs and everyone knows everything ;)
In reality though, you know this area *much* better than
me, and I rely on your judgement here.

Still the whole lot seems a bit too much here, while some fixes
in seabios-hppa (so whole new release of it, maybe without the
separate 64bit firmware variant) looks worth to have.

It's a mix of features and bugfixes, and some features (like
this tulip thing for example) actually *are* bugfixes :)

Thanks,

/mjt

Re: [PULL 00/12] Hppa64 patches

Posted by Helge Deller 11 months, 1 week ago

On 2/14/24 10:07, Michael Tokarev wrote:
> 13.02.2024 22:16, Helge Deller:
>> On 2/13/24 19:09, Michael Tokarev wrote:
>>> 13.02.2024 02:47, deller@kernel.org:
>
>>>> Helge Deller (11):
>>>>    disas/hppa: Add disassembly for qemu specific instructions
>>>>    target/hppa: Add "diag 0x101" for console output support
>>>>    hw/pci-host/astro: Avoid aborting on access failure
>>>>    hw/pci-host/astro: Implement Hard Fail and Soft Fail mode
>>>>    lasi: allow access to LAN MAC address registers
>>>>    target/hppa: Implement do_transaction_failed handler for I/O errors
>>>>    lasi: Add reset I/O ports for LASI audio and FDC
>>>>    target/hppa: Allow read-access to PSW with rsm 0,reg instruction
>>>>    target/hppa: PDC_BTLB_INFO uses 32-bit ints
>>>>    target/hppa: Update SeaBIOS-hppa to version 16
>>>>    hw/hppa/machine: Load 64-bit firmware on 64-bit machines
>>>>
>>>> Sven Schnelle (1):
>>>>    hw/net/tulip: add chip status register values
>>>
>>> Is there anything in there which is relevant for -stable?
>>
>> Ideally all patches.
>> At minimum the tulip patch.
>
> Heh.
>
> Ideally there's no bugs and everyone knows everything ;)
> In reality though, you know this area *much* better than
> me, and I rely on your judgement here.
>
> Still the whole lot seems a bit too much here, while some fixes
> in seabios-hppa (so whole new release of it, maybe without the
> separate 64bit firmware variant) looks worth to have.
>
> It's a mix of features and bugfixes, and some features (like
> this tulip thing for example) actually *are* bugfixes :)

I suggest to just downport the tulip patch.
32-bit currently works in stable series as-is.

Most current fixes in SeaBIOS and hppa code are to fix & enable the 64-bit
Linux kernel & HP-UX. I don't think we want to completely back port those,
as they aren't yet fully functional either. So, this 64-bit is stuff which
should be limited to upcoming versions.

In case we want the newer SeaBIOS in stable, I suggest to additionally downport:
- target/hppa: Add "diag 0x101" for console output support
- target/hppa: Update SeaBIOS-hppa to version 16 (minus the 64-bit binary)

Helge