qemu-nbd: mention --tls-hostname option in qemu-nbd --help

[PATCH trivial] qemu-nbd: mention --tls-hostname option in qemu-nbd --help

Michael Tokarev posted 1 patch 9 months, 3 weeks ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20240207073231.271198-1-mjt@tls.msk.ru

Maintainers: Eric Blake <eblake@redhat.com>, Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>, Michael Tokarev <mjt@tls.msk.ru>, Laurent Vivier <laurent@vivier.eu>

qemu-nbd.c | 1 +
1 file changed, 1 insertion(+)

Expand all Fold all

[PATCH trivial] qemu-nbd: mention --tls-hostname option in qemu-nbd --help

Posted by Michael Tokarev 9 months, 3 weeks ago

This option was not documented.

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1240
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
 qemu-nbd.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/qemu-nbd.c b/qemu-nbd.c
index bac0b5e3ec..d7b3ccab21 100644
--- a/qemu-nbd.c
+++ b/qemu-nbd.c
@@ -114,6 +114,7 @@ static void usage(const char *name)
 "  --tls-creds=ID            use id of an earlier --object to provide TLS\n"
 "  --tls-authz=ID            use id of an earlier --object to provide\n"
 "                            authorization\n"
+"  --tls-hostname=HOSTNAME   override hostname used to check x509 certificate\n"
 "  -T, --trace [[enable=]<pattern>][,events=<file>][,file=<file>]\n"
 "                            specify tracing options\n"
 "  --fork                    fork off the server process and exit the parent\n"
-- 
2.39.2

Re: [PATCH trivial] qemu-nbd: mention --tls-hostname option in qemu-nbd --help

Posted by Daniel P. Berrangé 9 months, 3 weeks ago

On Wed, Feb 07, 2024 at 10:32:31AM +0300, Michael Tokarev wrote:
> This option was not documented.
> 
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1240
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
>  qemu-nbd.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/qemu-nbd.c b/qemu-nbd.c
> index bac0b5e3ec..d7b3ccab21 100644
> --- a/qemu-nbd.c
> +++ b/qemu-nbd.c
> @@ -114,6 +114,7 @@ static void usage(const char *name)
>  "  --tls-creds=ID            use id of an earlier --object to provide TLS\n"
>  "  --tls-authz=ID            use id of an earlier --object to provide\n"
>  "                            authorization\n"
> +"  --tls-hostname=HOSTNAME   override hostname used to check x509 certificate\n"
>  "  -T, --trace [[enable=]<pattern>][,events=<file>][,file=<file>]\n"
>  "                            specify tracing options\n"
>  "  --fork                    fork off the server process and exit the parent\n"

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|