Fix issues with npcm7xx and recent NIC cleanup

[PATCH 0/2] Fix issues with npcm7xx and recent NIC cleanup

Peter Maydell posted 2 patches 9 months, 3 weeks ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20240206171231.396392-1-peter.maydell@linaro.org

Maintainers: Tyrone Ting <kfting@nuvoton.com>, Hao Wu <wuhaotsh@google.com>, Peter Maydell <peter.maydell@linaro.org>, Thomas Huth <thuth@redhat.com>, Laurent Vivier <lvivier@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>

hw/arm/npcm7xx.c               | 1 +
tests/qtest/npcm7xx_emc-test.c | 5 ++++-
2 files changed, 5 insertions(+), 1 deletion(-)

Expand all Fold all

[PATCH 0/2] Fix issues with npcm7xx and recent NIC cleanup

Posted by Peter Maydell 9 months, 3 weeks ago

The changes to the NPCM7xx to add the GMAC devices crossed in the mail
with the NIC cleanup patchset, which had a couple of unfortunate results:
 * no qemu_configure_nic_device() call for the GMAC modules
 * the npcm7xx_emc-test produces some spurious warnings

This patchset fixes both of those. Arguably patch 2 shouldn't
be necessary, as the "nic foo has no peer" warning is a bit
overzealous for NICs that always exist on the board, but I preferred
the simple approach of silencing it rather than spending ages trying
to figure out what the "right" condition for the warning should be.

thanks
-- PMM

Peter Maydell (2):
  hw/arm/npcm7xx: Call qemu_configure_nic_device() for GMAC modules
  tests/qtest/npcm7xx_emc-test: Connect all NICs to a backend

 hw/arm/npcm7xx.c               | 1 +
 tests/qtest/npcm7xx_emc-test.c | 5 ++++-
 2 files changed, 5 insertions(+), 1 deletion(-)

-- 
2.34.1