tests/qtest/meson.build: Don't include qtests_npcm7xx in qtests_aarch64

[PATCH] tests/qtest/meson.build: Don't include qtests_npcm7xx in qtests_aarch64

Peter Maydell posted 1 patch 9 months, 3 weeks ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20240206163043.315535-1-peter.maydell@linaro.org

Maintainers: Thomas Huth <thuth@redhat.com>, Laurent Vivier <lvivier@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>

tests/qtest/meson.build | 1 -
1 file changed, 1 deletion(-)

Expand all Fold all

[PATCH] tests/qtest/meson.build: Don't include qtests_npcm7xx in qtests_aarch64

Posted by Peter Maydell 9 months, 3 weeks ago

We deliberately don't include qtests_npcm7xx in qtests_aarch64,
because we already get the coverage of those tests via qtests_arm,
and we don't want to use extra CI minutes testing them twice.

In commit 327b680877b79c4b we added it to qtests_aarch64; revert
that change.

Fixes: 327b680877b79c4b ("tests/qtest: Creating qtest for GMAC Module")
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 tests/qtest/meson.build | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build
index 39557d5ecbb..663338ae124 100644
--- a/tests/qtest/meson.build
+++ b/tests/qtest/meson.build
@@ -231,7 +231,6 @@ qtests_aarch64 = \
   (config_all_devices.has_key('CONFIG_RASPI') ? ['bcm2835-dma-test'] : []) +  \
   (config_all_accel.has_key('CONFIG_TCG') and                                            \
    config_all_devices.has_key('CONFIG_TPM_TIS_I2C') ? ['tpm-tis-i2c-test'] : []) + \
-  (config_all_devices.has_key('CONFIG_NPCM7XX') ? qtests_npcm7xx : []) + \
   ['arm-cpu-features',
    'numa-test',
    'boot-serial-test',
-- 
2.34.1

Re: [PATCH] tests/qtest/meson.build: Don't include qtests_npcm7xx in qtests_aarch64

Posted by Philippe Mathieu-Daudé 9 months, 3 weeks ago

On 6/2/24 17:30, Peter Maydell wrote:
> We deliberately don't include qtests_npcm7xx in qtests_aarch64,
> because we already get the coverage of those tests via qtests_arm,
> and we don't want to use extra CI minutes testing them twice.
> 
> In commit 327b680877b79c4b we added it to qtests_aarch64; revert
> that change.
> 
> Fixes: 327b680877b79c4b ("tests/qtest: Creating qtest for GMAC Module")
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>   tests/qtest/meson.build | 1 -
>   1 file changed, 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>