[v3] make vm-build-freebsd fixes

[PATCH v3 0/4] make vm-build-freebsd fixes

Ilya Leoshkevich posted 4 patches 9 months, 3 weeks ago

Diff against v1 v2
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20240206002344.12372-1-iii@linux.ibm.com

Maintainers: Paolo Bonzini <pbonzini@redhat.com>, "Marc-André Lureau" <marcandre.lureau@redhat.com>, "Daniel P. Berrangé" <berrange@redhat.com>, Thomas Huth <thuth@redhat.com>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, "Alex Bennée" <alex.bennee@linaro.org>, Wainer dos Santos Moschetta <wainersm@redhat.com>, Beraldo Leal <bleal@redhat.com>, Warner Losh <imp@bsdimp.com>, Kyle Evans <kevans@freebsd.org>, Ed Maste <emaste@freebsd.org>, Li-Wen Hsu <lwhsu@freebsd.org>

meson.build                        | 23 +++++++++++++++++++----
tests/unit/test-util-filemonitor.c |  8 ++++++++
tests/vm/basevm.py                 |  2 ++
tests/vm/freebsd                   |  1 +
util/meson.build                   |  6 +++++-
5 files changed, 35 insertions(+), 5 deletions(-)

Expand all Fold all

[PATCH v3 0/4] make vm-build-freebsd fixes

Posted by Ilya Leoshkevich 9 months, 3 weeks ago

v2: https://lists.gnu.org/archive/html/qemu-devel/2024-02/msg00890.html
v2 -> v3: Structure the meson check similar to have_asan_fiber;
          Reduce the context size a little (Philippe).

v1: https://lists.gnu.org/archive/html/qemu-devel/2024-01/msg05155.html
v1 -> v2: Link with libinotify instead of disabling the inotify
          support (Daniel).
          Use a bit more context lines in order to prevent the
          incorrect application of the test patch.

Hi,

I needed to verify that my qemu-user changes didn't break BSD, and
Daniel Berrange suggested vm-build-freebsd on IRC. I had several
problems with it, which this series resolves.

Best regards,
Ilya

Ilya Leoshkevich (4):
  tests/vm: Set UseDNS=no in the sshd configuration
  tests/vm/freebsd: Reload the sshd configuration
  test-util-filemonitor: Adapt to the FreeBSD inotify rename semantics
  meson: Link with libinotify on FreeBSD

 meson.build                        | 23 +++++++++++++++++++----
 tests/unit/test-util-filemonitor.c |  8 ++++++++
 tests/vm/basevm.py                 |  2 ++
 tests/vm/freebsd                   |  1 +
 util/meson.build                   |  6 +++++-
 5 files changed, 35 insertions(+), 5 deletions(-)

-- 
2.43.0

Re: [PATCH v3 0/4] make vm-build-freebsd fixes

Posted by Alex Bennée 9 months, 3 weeks ago

Ilya Leoshkevich <iii@linux.ibm.com> writes:

> v2: https://lists.gnu.org/archive/html/qemu-devel/2024-02/msg00890.html
> v2 -> v3: Structure the meson check similar to have_asan_fiber;
>           Reduce the context size a little (Philippe).
>
> v1: https://lists.gnu.org/archive/html/qemu-devel/2024-01/msg05155.html
> v1 -> v2: Link with libinotify instead of disabling the inotify
>           support (Daniel).
>           Use a bit more context lines in order to prevent the
>           incorrect application of the test patch.
>
> Hi,
>
> I needed to verify that my qemu-user changes didn't break BSD, and
> Daniel Berrange suggested vm-build-freebsd on IRC. I had several
> problems with it, which this series resolves.

Queued to testing/next, thanks.

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro

Re: [PATCH v3 0/4] make vm-build-freebsd fixes

Posted by Ilya Leoshkevich 9 months, 3 weeks ago

On Wed, 2024-02-07 at 15:02 +0000, Alex Bennée wrote:
> Ilya Leoshkevich <iii@linux.ibm.com> writes:
> 
> > v2:
> > https://lists.gnu.org/archive/html/qemu-devel/2024-02/msg00890.html
> > v2 -> v3: Structure the meson check similar to have_asan_fiber;
> >           Reduce the context size a little (Philippe).
> > 
> > v1:
> > https://lists.gnu.org/archive/html/qemu-devel/2024-01/msg05155.html
> > v1 -> v2: Link with libinotify instead of disabling the inotify
> >           support (Daniel).
> >           Use a bit more context lines in order to prevent the
> >           incorrect application of the test patch.
> > 
> > Hi,
> > 
> > I needed to verify that my qemu-user changes didn't break BSD, and
> > Daniel Berrange suggested vm-build-freebsd on IRC. I had several
> > problems with it, which this series resolves.
> 
> Queued to testing/next, thanks.

Hi Alex,

thanks! But I think Thomas already took it into his tree:

https://lists.gnu.org/archive/html/qemu-devel/2024-02/msg01015.html

Best regards,
Ilya

Re: [PATCH v3 0/4] make vm-build-freebsd fixes

Posted by Alex Bennée 9 months, 3 weeks ago

Ilya Leoshkevich <iii@linux.ibm.com> writes:

> On Wed, 2024-02-07 at 15:02 +0000, Alex Bennée wrote:
>> Ilya Leoshkevich <iii@linux.ibm.com> writes:
>> 
>> > v2:
>> > https://lists.gnu.org/archive/html/qemu-devel/2024-02/msg00890.html
>> > v2 -> v3: Structure the meson check similar to have_asan_fiber;
>> >           Reduce the context size a little (Philippe).
>> > 
>> > v1:
>> > https://lists.gnu.org/archive/html/qemu-devel/2024-01/msg05155.html
>> > v1 -> v2: Link with libinotify instead of disabling the inotify
>> >           support (Daniel).
>> >           Use a bit more context lines in order to prevent the
>> >           incorrect application of the test patch.
>> > 
>> > Hi,
>> > 
>> > I needed to verify that my qemu-user changes didn't break BSD, and
>> > Daniel Berrange suggested vm-build-freebsd on IRC. I had several
>> > problems with it, which this series resolves.
>> 
>> Queued to testing/next, thanks.
>
> Hi Alex,
>
> thanks! But I think Thomas already took it into his tree:
>
> https://lists.gnu.org/archive/html/qemu-devel/2024-02/msg01015.html

Ahh I missed that Thomas had pulled it. It should all rectify itself
when I create the PR tomorrow.

>
> Best regards,
> Ilya

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro