1. Patchew
  2. QEMU
  3. View series

[PATCH v9 0/5] eBPF RSS through QMP support.

Andrew Melnychenko posted 5 patches 2 months, 3 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20240205165437.1965981-1-andrew@daynix.com
Maintainers: Jason Wang <jasowang@redhat.com>, Andrew Melnychenko <andrew@daynix.com>, Yuri Benditovich <yuri.benditovich@daynix.com>, "Michael S. Tsirkin" <mst@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, "Marc-André Lureau" <marcandre.lureau@redhat.com>, "Daniel P. Berrangé" <berrange@redhat.com>, Thomas Huth <thuth@redhat.com>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Eric Blake <eblake@redhat.com>, Markus Armbruster <armbru@redhat.com>, Michael Roth <michael.roth@amd.com>
ebpf/ebpf.c                    |   69 ++
ebpf/ebpf.h                    |   29 +
ebpf/ebpf_rss-stub.c           |    6 +
ebpf/ebpf_rss.c                |  150 +++-
ebpf/ebpf_rss.h                |   10 +
ebpf/meson.build               |    2 +-
ebpf/rss.bpf.skeleton.h        | 1343 ++++++++++++++++----------------
hw/net/virtio-net.c            |   54 +-
include/hw/virtio/virtio-net.h |    2 +
meson.build                    |   10 +-
qapi/ebpf.json                 |   66 ++
qapi/meson.build               |    1 +
qapi/qapi-schema.json          |    1 +
tools/ebpf/rss.bpf.c           |    7 +-
14 files changed, 1047 insertions(+), 703 deletions(-)
create mode 100644 ebpf/ebpf.c
create mode 100644 ebpf/ebpf.h
create mode 100644 qapi/ebpf.json
[PATCH v9 0/5] eBPF RSS through QMP support.
Posted by Andrew Melnychenko 2 months, 3 weeks ago 
This series of patches provides the ability to retrieve eBPF program
through qmp, so management application may load bpf blob with proper capabilities.
Now, virtio-net devices can accept eBPF programs and maps through properties
as external file descriptors. Access to the eBPF map is direct through mmap()
call, so it should not require additional capabilities to bpf* calls.
eBPF file descriptors can be passed to QEMU from parent process or by unix
socket with sendfd() qmp command.

Changes since v8:
 * rebased and refactored QMP interface
 * license SPDX id only for new files

Changes since v7:
 * rebased and refactored
 * used SPDX license identifier
 * used DEFINE_PROP_ARRAY() for virtio-net "ebpf-rss-fds" property

Changes since v6:
 * added comments to ebpf.json
 * added libbpf version requirements to meson script with BPF_F_MMAPABLE check

Changes since v5:
 * refactored ebpf.json

Changes since v4:
 * refactored commit hunks
 * added explicit BPF_F_MMAPABLE declaration

Changes since v3:
 * fixed issue with the build if bpf disabled
 * rebased to the last master
 * refactored according to review

Changes since v2:
 * moved/refactored QMP command
 * refactored virtio-net

Changes since v1:
 * refactored virtio-net
 * moved hunks for ebpf mmap()
 * added qmp enum for eBPF id.

Andrew Melnychenko (5):
  ebpf: Added eBPF map update through mmap.
  ebpf: Added eBPF initialization by fds.
  virtio-net: Added property to load eBPF RSS with fds.
  qmp: Added new command to retrieve eBPF blob.
  ebpf: Updated eBPF program and skeleton.

 ebpf/ebpf.c                    |   69 ++
 ebpf/ebpf.h                    |   29 +
 ebpf/ebpf_rss-stub.c           |    6 +
 ebpf/ebpf_rss.c                |  150 +++-
 ebpf/ebpf_rss.h                |   10 +
 ebpf/meson.build               |    2 +-
 ebpf/rss.bpf.skeleton.h        | 1343 ++++++++++++++++----------------
 hw/net/virtio-net.c            |   54 +-
 include/hw/virtio/virtio-net.h |    2 +
 meson.build                    |   10 +-
 qapi/ebpf.json                 |   66 ++
 qapi/meson.build               |    1 +
 qapi/qapi-schema.json          |    1 +
 tools/ebpf/rss.bpf.c           |    7 +-
 14 files changed, 1047 insertions(+), 703 deletions(-)
 create mode 100644 ebpf/ebpf.c
 create mode 100644 ebpf/ebpf.h
 create mode 100644 qapi/ebpf.json

-- 
2.43.0
Re: [PATCH v9 0/5] eBPF RSS through QMP support.
Posted by Andrew Melnichenko 2 months ago 
Hi all,
Jason, can you please review the patch set, thank you.

On Mon, Feb 5, 2024 at 6:54 PM Andrew Melnychenko <andrew@daynix.com> wrote:
>
> This series of patches provides the ability to retrieve eBPF program
> through qmp, so management application may load bpf blob with proper capabilities.
> Now, virtio-net devices can accept eBPF programs and maps through properties
> as external file descriptors. Access to the eBPF map is direct through mmap()
> call, so it should not require additional capabilities to bpf* calls.
> eBPF file descriptors can be passed to QEMU from parent process or by unix
> socket with sendfd() qmp command.
>
> Changes since v8:
>  * rebased and refactored QMP interface
>  * license SPDX id only for new files
>
> Changes since v7:
>  * rebased and refactored
>  * used SPDX license identifier
>  * used DEFINE_PROP_ARRAY() for virtio-net "ebpf-rss-fds" property
>
> Changes since v6:
>  * added comments to ebpf.json
>  * added libbpf version requirements to meson script with BPF_F_MMAPABLE check
>
> Changes since v5:
>  * refactored ebpf.json
>
> Changes since v4:
>  * refactored commit hunks
>  * added explicit BPF_F_MMAPABLE declaration
>
> Changes since v3:
>  * fixed issue with the build if bpf disabled
>  * rebased to the last master
>  * refactored according to review
>
> Changes since v2:
>  * moved/refactored QMP command
>  * refactored virtio-net
>
> Changes since v1:
>  * refactored virtio-net
>  * moved hunks for ebpf mmap()
>  * added qmp enum for eBPF id.
>
> Andrew Melnychenko (5):
>   ebpf: Added eBPF map update through mmap.
>   ebpf: Added eBPF initialization by fds.
>   virtio-net: Added property to load eBPF RSS with fds.
>   qmp: Added new command to retrieve eBPF blob.
>   ebpf: Updated eBPF program and skeleton.
>
>  ebpf/ebpf.c                    |   69 ++
>  ebpf/ebpf.h                    |   29 +
>  ebpf/ebpf_rss-stub.c           |    6 +
>  ebpf/ebpf_rss.c                |  150 +++-
>  ebpf/ebpf_rss.h                |   10 +
>  ebpf/meson.build               |    2 +-
>  ebpf/rss.bpf.skeleton.h        | 1343 ++++++++++++++++----------------
>  hw/net/virtio-net.c            |   54 +-
>  include/hw/virtio/virtio-net.h |    2 +
>  meson.build                    |   10 +-
>  qapi/ebpf.json                 |   66 ++
>  qapi/meson.build               |    1 +
>  qapi/qapi-schema.json          |    1 +
>  tools/ebpf/rss.bpf.c           |    7 +-
>  14 files changed, 1047 insertions(+), 703 deletions(-)
>  create mode 100644 ebpf/ebpf.c
>  create mode 100644 ebpf/ebpf.h
>  create mode 100644 qapi/ebpf.json
>
> --
> 2.43.0
>
Re: [PATCH v9 0/5] eBPF RSS through QMP support.
Posted by Jason Wang 1 month, 3 weeks ago 
On Mon, Feb 26, 2024 at 6:23 PM Andrew Melnichenko <andrew@daynix.com> wrote:
>
> Hi all,
> Jason, can you please review the patch set, thank you.

Queued.

Thanks
Re: [PATCH v9 0/5] eBPF RSS through QMP support.
Posted by Jason Wang 1 month, 3 weeks ago 
On Fri, Mar 8, 2024 at 2:30 PM Jason Wang <jasowang@redhat.com> wrote:
>
> On Mon, Feb 26, 2024 at 6:23 PM Andrew Melnichenko <andrew@daynix.com> wrote:
> >
> > Hi all,
> > Jason, can you please review the patch set, thank you.
>
> Queued.
>
> Thanks

This seems to fail CI at:

https://gitlab.com/jasowang/qemu/-/jobs/6348725269

Please fix this.

Thanks
Re: [PATCH v9 0/5] eBPF RSS through QMP support.
Posted by Andrew Melnichenko 1 month, 2 weeks ago 
Hi all,
Apparently, eBPF code from ebpf/* can't be a part of the 'common'
library - that breaks non-system/user build. I'll change it to be a
'system' library.

On Fri, Mar 8, 2024 at 10:06 AM Jason Wang <jasowang@redhat.com> wrote:
>
> On Fri, Mar 8, 2024 at 2:30 PM Jason Wang <jasowang@redhat.com> wrote:
> >
> > On Mon, Feb 26, 2024 at 6:23 PM Andrew Melnichenko <andrew@daynix.com> wrote:
> > >
> > > Hi all,
> > > Jason, can you please review the patch set, thank you.
> >
> > Queued.
> >
> > Thanks
>
> This seems to fail CI at:
>
> https://gitlab.com/jasowang/qemu/-/jobs/6348725269
>
> Please fix this.
>
> Thanks
>
Re: [PATCH v9 0/5] eBPF RSS through QMP support.
Posted by Jason Wang 1 month, 2 weeks ago 
Hi Andrew:

On Wed, Mar 13, 2024 at 7:11 AM Andrew Melnichenko <andrew@daynix.com> wrote:
>
> Hi all,
> Apparently, eBPF code from ebpf/* can't be a part of the 'common'
> library - that breaks non-system/user build. I'll change it to be a
> 'system' library.

I've dropped some of the tracing as a workaround (due to schedule
pressure) since yesterday was a soft freeze and I don't want to miss
it again.

The pull request has been merged. Please fix that on top (add some
tracing back probably).

Thanks

>
> On Fri, Mar 8, 2024 at 10:06 AM Jason Wang <jasowang@redhat.com> wrote:
> >
> > On Fri, Mar 8, 2024 at 2:30 PM Jason Wang <jasowang@redhat.com> wrote:
> > >
> > > On Mon, Feb 26, 2024 at 6:23 PM Andrew Melnichenko <andrew@daynix.com> wrote:
> > > >
> > > > Hi all,
> > > > Jason, can you please review the patch set, thank you.
> > >
> > > Queued.
> > >
> > > Thanks
> >
> > This seems to fail CI at:
> >
> > https://gitlab.com/jasowang/qemu/-/jobs/6348725269
> >
> > Please fix this.
> >
> > Thanks
> >
>

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.