iotests: give tempdir an identifying name

[PATCH] iotests: give tempdir an identifying name

Posted by Daniel P. Berrangé 9 months, 3 weeks ago

If something goes wrong causing the iotests not to cleanup their
temporary directory, it is useful if the dir had an identifying
name to show what is to blame.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 tests/qemu-iotests/testenv.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/qemu-iotests/testenv.py b/tests/qemu-iotests/testenv.py
index 3ff38f2661..588f30a4f1 100644
--- a/tests/qemu-iotests/testenv.py
+++ b/tests/qemu-iotests/testenv.py
@@ -126,7 +126,7 @@ def init_directories(self) -> None:
             self.tmp_sock_dir = False
             Path(self.sock_dir).mkdir(parents=True, exist_ok=True)
         except KeyError:
-            self.sock_dir = tempfile.mkdtemp()
+            self.sock_dir = tempfile.mkdtemp(prefix="qemu-iotests-")
             self.tmp_sock_dir = True
 
         self.sample_img_dir = os.getenv('SAMPLE_IMG_DIR',
-- 
2.43.0

Re: [PATCH] iotests: give tempdir an identifying name

Posted by Kevin Wolf 9 months, 3 weeks ago

Am 05.02.2024 um 16:51 hat Daniel P. Berrangé geschrieben:
> If something goes wrong causing the iotests not to cleanup their
> temporary directory, it is useful if the dir had an identifying
> name to show what is to blame.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

Thanks, applied to the block branch.

Kevin

Re: [PATCH] iotests: give tempdir an identifying name

Posted by Michael Tokarev 9 months, 3 weeks ago

05.02.2024 18:51, Daniel P. Berrangé wrote:
> If something goes wrong causing the iotests not to cleanup their
> temporary directory, it is useful if the dir had an identifying
> name to show what is to blame.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

Revieved-by: Michael Tokarev <mjt@tls.msk.ru>

Thank you again for the quick good work!

/mjt

>   tests/qemu-iotests/testenv.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/qemu-iotests/testenv.py b/tests/qemu-iotests/testenv.py
> index 3ff38f2661..588f30a4f1 100644
> --- a/tests/qemu-iotests/testenv.py
> +++ b/tests/qemu-iotests/testenv.py
> @@ -126,7 +126,7 @@ def init_directories(self) -> None:
>               self.tmp_sock_dir = False
>               Path(self.sock_dir).mkdir(parents=True, exist_ok=True)
>           except KeyError:
> -            self.sock_dir = tempfile.mkdtemp()
> +            self.sock_dir = tempfile.mkdtemp(prefix="qemu-iotests-")
>               self.tmp_sock_dir = True
>   
>           self.sample_img_dir = os.getenv('SAMPLE_IMG_DIR',