The upcoming follow-fork-mode child support requires post-fork message
exchange between the parent and the child. Prepare gdbserver_fork() for
this purpose. Rename it to gdbserver_fork_end() to better reflect its
purpose.
Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
---
bsd-user/main.c | 3 ++-
gdbstub/user.c | 5 ++---
include/gdbstub/user.h | 6 +++---
linux-user/main.c | 2 +-
4 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/bsd-user/main.c b/bsd-user/main.c
index e8c658eda5d..1890d6365f7 100644
--- a/bsd-user/main.c
+++ b/bsd-user/main.c
@@ -131,10 +131,11 @@ void fork_end(abi_long pid)
*/
qemu_init_cpu_list();
((TaskState *)thread_cpu->opaque)->ts_tid = qemu_get_thread_id();
- gdbserver_fork(pid);
+ gdbserver_fork_end(pid);
} else {
mmap_fork_end(child);
cpu_list_unlock();
+ gdbserver_fork_end(pid);
end_exclusive();
}
}
diff --git a/gdbstub/user.c b/gdbstub/user.c
index d3a749f3e7e..df5a618e789 100644
--- a/gdbstub/user.c
+++ b/gdbstub/user.c
@@ -374,10 +374,9 @@ static void disable_gdbstub(void)
}
}
-/* Disable gdb stub for child processes. */
-void gdbserver_fork(pid_t pid)
+void gdbserver_fork_end(pid_t pid)
{
- if (!gdbserver_state.init || gdbserver_user_state.fd < 0) {
+ if (pid != 0 || !gdbserver_state.init || gdbserver_user_state.fd < 0) {
return;
}
disable_gdbstub();
diff --git a/include/gdbstub/user.h b/include/gdbstub/user.h
index 66dd0d319cf..dd03dbdd6df 100644
--- a/include/gdbstub/user.h
+++ b/include/gdbstub/user.h
@@ -51,10 +51,10 @@ void gdb_signalled(CPUArchState *as, int sig);
void gdbserver_fork_start(void);
/**
- * gdbserver_fork() - disable gdb stub for child processes.
- * @cs: CPU
+ * gdbserver_fork_end() - inform gdb of the completed fork()
+ * @pid: 0 if in child process, -1 if fork failed, child process pid otherwise
*/
-void gdbserver_fork(pid_t pid);
+void gdbserver_fork_end(pid_t pid);
/**
* gdb_syscall_entry() - inform gdb of syscall entry and yield control to it
diff --git a/linux-user/main.c b/linux-user/main.c
index ad1c6394520..dde5081e2f4 100644
--- a/linux-user/main.c
+++ b/linux-user/main.c
@@ -164,10 +164,10 @@ void fork_end(abi_long pid)
}
qemu_init_cpu_list();
((TaskState *)thread_cpu->opaque)->ts_tid = qemu_get_thread_id();
- gdbserver_fork(pid);
} else {
cpu_list_unlock();
}
+ gdbserver_fork_end(pid);
/*
* qemu_init_cpu_list() reinitialized the child exclusive state, but we
* also need to keep current_cpu consistent, so call end_exclusive() for
--
2.43.0