backends/hostmem.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-)
While re-indenting code in host_memory_backend_memory_complete(),
we triggered various "Block comments use a leading /* on a separate
line" warnings from checkpatch.pl. Correct the comments style.
Fixes: e199f7ad4d ("backends: Simplify host_memory_backend_memory_complete()")
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
backends/hostmem.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/backends/hostmem.c b/backends/hostmem.c
index 30f69b2cb5..987f6f591e 100644
--- a/backends/hostmem.c
+++ b/backends/hostmem.c
@@ -344,9 +344,11 @@ host_memory_backend_memory_complete(UserCreatable *uc, Error **errp)
unsigned long lastbit = find_last_bit(backend->host_nodes, MAX_NODES);
/* lastbit == MAX_NODES means maxnode = 0 */
unsigned long maxnode = (lastbit + 1) % (MAX_NODES + 1);
- /* ensure policy won't be ignored in case memory is preallocated
+ /*
+ * Ensure policy won't be ignored in case memory is preallocated
* before mbind(). note: MPOL_MF_STRICT is ignored on hugepages so
- * this doesn't catch hugepage case. */
+ * this doesn't catch hugepage case.
+ */
unsigned flags = MPOL_MF_STRICT | MPOL_MF_MOVE;
int mode = backend->policy;
@@ -363,7 +365,8 @@ host_memory_backend_memory_complete(UserCreatable *uc, Error **errp)
return;
}
- /* We can have up to MAX_NODES nodes, but we need to pass maxnode+1
+ /*
+ * We can have up to MAX_NODES nodes, but we need to pass maxnode+1
* as argument to mbind() due to an old Linux bug (feature?) which
* cuts off the last specified node. This means backend->host_nodes
* must have MAX_NODES+1 bits available.
@@ -391,7 +394,8 @@ host_memory_backend_memory_complete(UserCreatable *uc, Error **errp)
}
}
#endif
- /* Preallocate memory after the NUMA policy has been instantiated.
+ /*
+ * Preallocate memory after the NUMA policy has been instantiated.
* This is necessary to guarantee memory is allocated with
* specified NUMA policy in place.
*/
--
2.41.0
On 1/30/2024 2:31 AM, Philippe Mathieu-Daudé wrote: > While re-indenting code in host_memory_backend_memory_complete(), > we triggered various "Block comments use a leading /* on a separate > line" warnings from checkpatch.pl. Correct the comments style. > > Fixes: e199f7ad4d ("backends: Simplify host_memory_backend_memory_complete()") > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> Reviewed-by: Xiaoyao Li <xiaoyao.li@intel.com> > --- > backends/hostmem.c | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) > > diff --git a/backends/hostmem.c b/backends/hostmem.c > index 30f69b2cb5..987f6f591e 100644 > --- a/backends/hostmem.c > +++ b/backends/hostmem.c > @@ -344,9 +344,11 @@ host_memory_backend_memory_complete(UserCreatable *uc, Error **errp) > unsigned long lastbit = find_last_bit(backend->host_nodes, MAX_NODES); > /* lastbit == MAX_NODES means maxnode = 0 */ > unsigned long maxnode = (lastbit + 1) % (MAX_NODES + 1); > - /* ensure policy won't be ignored in case memory is preallocated > + /* > + * Ensure policy won't be ignored in case memory is preallocated > * before mbind(). note: MPOL_MF_STRICT is ignored on hugepages so > - * this doesn't catch hugepage case. */ > + * this doesn't catch hugepage case. > + */ > unsigned flags = MPOL_MF_STRICT | MPOL_MF_MOVE; > int mode = backend->policy; > > @@ -363,7 +365,8 @@ host_memory_backend_memory_complete(UserCreatable *uc, Error **errp) > return; > } > > - /* We can have up to MAX_NODES nodes, but we need to pass maxnode+1 > + /* > + * We can have up to MAX_NODES nodes, but we need to pass maxnode+1 > * as argument to mbind() due to an old Linux bug (feature?) which > * cuts off the last specified node. This means backend->host_nodes > * must have MAX_NODES+1 bits available. > @@ -391,7 +394,8 @@ host_memory_backend_memory_complete(UserCreatable *uc, Error **errp) > } > } > #endif > - /* Preallocate memory after the NUMA policy has been instantiated. > + /* > + * Preallocate memory after the NUMA policy has been instantiated. > * This is necessary to guarantee memory is allocated with > * specified NUMA policy in place. > */
© 2016 - 2024 Red Hat, Inc.