[PATCH 0/4] mips: do not list individual devices from configs/

Paolo Bonzini posted 4 patches 10 months ago
Failed in applying to current master (apply log)
There is a newer version of this series
configs/devices/mips-softmmu/common.mak      | 28 +++------------
configs/devices/mips64el-softmmu/default.mak |  3 --
include/hw/usb.h                             | 26 ++++++++++++--
hw/isa/fdc37m81x-superio.c                   | 37 ++++++++++++++++++++
hw/isa/isa-superio.c                         | 19 ----------
hw/mips/loongson3_virt.c                     |  5 +--
hw/usb/bus.c                                 | 23 ------------
hw/display/Kconfig                           |  2 +-
hw/isa/Kconfig                               | 18 +++++-----
hw/isa/meson.build                           |  1 +
hw/mips/Kconfig                              | 25 ++++++++++---
11 files changed, 99 insertions(+), 88 deletions(-)
create mode 100644 hw/isa/fdc37m81x-superio.c
[PATCH 0/4] mips: do not list individual devices from configs/
Posted by Paolo Bonzini 10 months ago
Back when Kconfig was introduced, the individual dependencies for MIPS
boards were never added to hw/mips/Kconfig.  Do it now.

To simplify the task, include a couple cleanups to the SuperIO chip
configuration symbols, as well as a change that makes USB device
creation available even when building without default devices.

Tested by comparing old and new kconfigs; and also by building each of
the boards one by one, with default devices disabled, and checking that
the board can be started.

Paolo

Paolo Bonzini (4):
  isa: clean up Kconfig selections for ISA_SUPERIO
  isa: extract FDC37M81X to a separate file
  usb: inline device creation functions
  mips: do not list individual devices from configs/

 configs/devices/mips-softmmu/common.mak      | 28 +++------------
 configs/devices/mips64el-softmmu/default.mak |  3 --
 include/hw/usb.h                             | 26 ++++++++++++--
 hw/isa/fdc37m81x-superio.c                   | 37 ++++++++++++++++++++
 hw/isa/isa-superio.c                         | 19 ----------
 hw/mips/loongson3_virt.c                     |  5 +--
 hw/usb/bus.c                                 | 23 ------------
 hw/display/Kconfig                           |  2 +-
 hw/isa/Kconfig                               | 18 +++++-----
 hw/isa/meson.build                           |  1 +
 hw/mips/Kconfig                              | 25 ++++++++++---
 11 files changed, 99 insertions(+), 88 deletions(-)
 create mode 100644 hw/isa/fdc37m81x-superio.c

-- 
2.43.0
Re: [PATCH 0/4] mips: do not list individual devices from configs/
Posted by Bernhard Beschow 10 months ago

Am 29. Januar 2024 13:37:44 UTC schrieb Paolo Bonzini <pbonzini@redhat.com>:
>Back when Kconfig was introduced, the individual dependencies for MIPS
>boards were never added to hw/mips/Kconfig.  Do it now.

There is also: https://patchew.org/QEMU/20230109204124.102592-1-shentey@gmail.com/

Best regards,
Bernhard

>
>To simplify the task, include a couple cleanups to the SuperIO chip
>configuration symbols, as well as a change that makes USB device
>creation available even when building without default devices.
>
>Tested by comparing old and new kconfigs; and also by building each of
>the boards one by one, with default devices disabled, and checking that
>the board can be started.
>
>Paolo
>
>Paolo Bonzini (4):
>  isa: clean up Kconfig selections for ISA_SUPERIO
>  isa: extract FDC37M81X to a separate file
>  usb: inline device creation functions
>  mips: do not list individual devices from configs/
>
> configs/devices/mips-softmmu/common.mak      | 28 +++------------
> configs/devices/mips64el-softmmu/default.mak |  3 --
> include/hw/usb.h                             | 26 ++++++++++++--
> hw/isa/fdc37m81x-superio.c                   | 37 ++++++++++++++++++++
> hw/isa/isa-superio.c                         | 19 ----------
> hw/mips/loongson3_virt.c                     |  5 +--
> hw/usb/bus.c                                 | 23 ------------
> hw/display/Kconfig                           |  2 +-
> hw/isa/Kconfig                               | 18 +++++-----
> hw/isa/meson.build                           |  1 +
> hw/mips/Kconfig                              | 25 ++++++++++---
> 11 files changed, 99 insertions(+), 88 deletions(-)
> create mode 100644 hw/isa/fdc37m81x-superio.c
>
Re: [PATCH 0/4] mips: do not list individual devices from configs/
Posted by Paolo Bonzini 10 months ago
On Mon, Jan 29, 2024 at 6:48 PM Bernhard Beschow <shentey@gmail.com> wrote:
> Am 29. Januar 2024 13:37:44 UTC schrieb Paolo Bonzini <pbonzini@redhat.com>:
> >Back when Kconfig was introduced, the individual dependencies for MIPS
> >boards were never added to hw/mips/Kconfig.  Do it now.
>
> There is also: https://patchew.org/QEMU/20230109204124.102592-1-shentey@gmail.com/

Oh, that's a pity. Looks like your version doesn't apply anymore, but
we can salvage "[PATCH 2/4] hw/mips/Kconfig: Remove ISA dependencies
from MIPSsim board" which is slightly more complete than my version.

Paolo
Re: [PATCH 0/4] mips: do not list individual devices from configs/
Posted by Bernhard Beschow 10 months ago

Am 29. Januar 2024 18:16:08 UTC schrieb Paolo Bonzini <pbonzini@redhat.com>:
>On Mon, Jan 29, 2024 at 6:48 PM Bernhard Beschow <shentey@gmail.com> wrote:
>> Am 29. Januar 2024 13:37:44 UTC schrieb Paolo Bonzini <pbonzini@redhat.com>:
>> >Back when Kconfig was introduced, the individual dependencies for MIPS
>> >boards were never added to hw/mips/Kconfig.  Do it now.
>>
>> There is also: https://patchew.org/QEMU/20230109204124.102592-1-shentey@gmail.com/
>
>Oh, that's a pity. Looks like your version doesn't apply anymore, but
>we can salvage "[PATCH 2/4] hw/mips/Kconfig: Remove ISA dependencies
>from MIPSsim board" which is slightly more complete than my version.

Sounds good to me!

Bernhard
>
>Paolo
>