[PATCH 4/5] qga: Move type description right after type name

Markus Armbruster posted 5 patches 2 years ago
Maintainers: Eric Blake <eblake@redhat.com>, Markus Armbruster <armbru@redhat.com>, Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>, Michael Roth <michael.roth@amd.com>, Konstantin Kostiuk <kkostiuk@redhat.com>
[PATCH 4/5] qga: Move type description right after type name
Posted by Markus Armbruster 2 years ago
Documentation of type BlockdevOptionsIscsi describes the type's
purpose after its members.  Everywhere else, we do it the other way
round.  Move it for consistency.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 qapi/block-core.json | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/qapi/block-core.json b/qapi/block-core.json
index 530c4af50f..781c9bd03e 100644
--- a/qapi/block-core.json
+++ b/qapi/block-core.json
@@ -4070,6 +4070,8 @@
 ##
 # @BlockdevOptionsIscsi:
 #
+# Driver specific block device options for iscsi
+#
 # @transport: The iscsi transport type
 #
 # @portal: The address of the iscsi portal
@@ -4094,8 +4096,6 @@
 # @timeout: Timeout in seconds after which a request will timeout.  0
 #     means no timeout and is the default.
 #
-# Driver specific block device options for iscsi
-#
 # Since: 2.9
 ##
 { 'struct': 'BlockdevOptionsIscsi',
-- 
2.43.0
Re: [PATCH 4/5] qga: Move type description right after type name
Posted by Konstantin Kostiuk 2 years ago
Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com>

On Mon, Jan 29, 2024 at 1:50 PM Markus Armbruster <armbru@redhat.com> wrote:

> Documentation of type BlockdevOptionsIscsi describes the type's
> purpose after its members.  Everywhere else, we do it the other way
> round.  Move it for consistency.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  qapi/block-core.json | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index 530c4af50f..781c9bd03e 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -4070,6 +4070,8 @@
>  ##
>  # @BlockdevOptionsIscsi:
>  #
> +# Driver specific block device options for iscsi
> +#
>  # @transport: The iscsi transport type
>  #
>  # @portal: The address of the iscsi portal
> @@ -4094,8 +4096,6 @@
>  # @timeout: Timeout in seconds after which a request will timeout.  0
>  #     means no timeout and is the default.
>  #
> -# Driver specific block device options for iscsi
> -#
>  # Since: 2.9
>  ##
>  { 'struct': 'BlockdevOptionsIscsi',
> --
> 2.43.0
>
>