target/arm: Reinstate "vfp" property on AArch32 CPUs

[PATCH] target/arm: Reinstate "vfp" property on AArch32 CPUs

Peter Maydell posted 1 patch 10 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20240126193432.2210558-1-peter.maydell@linaro.org

Maintainers: Peter Maydell <peter.maydell@linaro.org>

target/arm/cpu.c | 4 ++++
1 file changed, 4 insertions(+)

Expand all Fold all

[PATCH] target/arm: Reinstate "vfp" property on AArch32 CPUs

Posted by Peter Maydell 10 months ago

In commit 4315f7c614743 we restructured the logic for creating the
VFP related properties to avoid testing the aa32_simd_r32 feature on
AArch64 CPUs.  However in the process we accidentally stopped
exposing the "vfp" QOM property on AArch32 TCG CPUs.

This mostly hasn't had any ill effects because not many people want
to disable VFP, but it wasn't intentional.  Reinstate the property.

Cc: qemu-stable@nongnu.org
Fixes: 4315f7c614743 ("target/arm: Restructure has_vfp_d32 test")
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2098
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 target/arm/cpu.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/target/arm/cpu.c b/target/arm/cpu.c
index 593695b4247..2bed5987619 100644
--- a/target/arm/cpu.c
+++ b/target/arm/cpu.c
@@ -1620,6 +1620,10 @@ void arm_cpu_post_init(Object *obj)
         }
     } else if (cpu_isar_feature(aa32_vfp, cpu)) {
         cpu->has_vfp = true;
+        if (tcg_enabled() || qtest_enabled()) {
+            qdev_property_add_static(DEVICE(obj),
+                                     &arm_cpu_has_vfp_property);
+        }
         if (cpu_isar_feature(aa32_simd_r32, cpu)) {
             cpu->has_vfp_d32 = true;
             /*
-- 
2.34.1

Re: [PATCH] target/arm: Reinstate "vfp" property on AArch32 CPUs

Posted by Richard Henderson 10 months ago

On 1/27/24 05:34, Peter Maydell wrote:
> In commit 4315f7c614743 we restructured the logic for creating the
> VFP related properties to avoid testing the aa32_simd_r32 feature on
> AArch64 CPUs.  However in the process we accidentally stopped
> exposing the "vfp" QOM property on AArch32 TCG CPUs.
> 
> This mostly hasn't had any ill effects because not many people want
> to disable VFP, but it wasn't intentional.  Reinstate the property.
> 
> Cc:qemu-stable@nongnu.org
> Fixes: 4315f7c614743 ("target/arm: Restructure has_vfp_d32 test")
> Resolves:https://gitlab.com/qemu-project/qemu/-/issues/2098
> Signed-off-by: Peter Maydell<peter.maydell@linaro.org>
> ---
>   target/arm/cpu.c | 4 ++++
>   1 file changed, 4 insertions(+)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~