[PULL v3 00/18] Block layer patches

Kevin Wolf posted 18 patches 10 months ago
Only 0 patches received!
There is a newer version of this series
qapi/block-core.json                          |  17 +-
hw/block/dataplane/trace.h                    |   1 -
hw/block/dataplane/virtio-blk.h               |  34 ---
include/block/block-global-state.h            |   3 +-
include/block/block_int-common.h              |   4 +-
include/block/block_int-global-state.h        |   6 +
include/hw/virtio/virtio-blk.h                |  16 +-
block.c                                       |  37 ++-
block/blklogwrites.c                          | 120 ++++++--
block/commit.c                                |   6 +-
block/monitor/block-hmp-cmds.c                |   2 +-
block/stream.c                                |  10 +-
blockdev.c                                    |  13 +
hw/block/dataplane/virtio-blk.c               | 404 -------------------------
hw/block/virtio-blk.c                         | 412 ++++++++++++++++++++++++--
monitor/qmp.c                                 |  17 --
qapi/qmp-dispatch.c                           |  24 +-
qapi/string-output-visitor.c                  |  46 +++
tests/unit/test-bdrv-drain.c                  |   3 +-
tests/qemu-iotests/iotests.py                 |   7 +
hw/block/dataplane/meson.build                |   1 -
hw/block/dataplane/trace-events               |   5 -
meson.build                                   |   1 -
tests/qemu-iotests/060.out                    |   4 +-
tests/qemu-iotests/071.out                    |   4 +-
tests/qemu-iotests/081.out                    |  16 +-
tests/qemu-iotests/087.out                    |  12 +-
tests/qemu-iotests/108.out                    |   2 +-
tests/qemu-iotests/109                        |   4 +-
tests/qemu-iotests/109.out                    |  78 +++--
tests/qemu-iotests/117.out                    |   2 +-
tests/qemu-iotests/120.out                    |   2 +-
tests/qemu-iotests/127.out                    |   2 +-
tests/qemu-iotests/140.out                    |   2 +-
tests/qemu-iotests/141                        | 307 ++++++++-----------
tests/qemu-iotests/141.out                    | 200 +++----------
tests/qemu-iotests/143.out                    |   2 +-
tests/qemu-iotests/156.out                    |   2 +-
tests/qemu-iotests/176.out                    |  16 +-
tests/qemu-iotests/182.out                    |   2 +-
tests/qemu-iotests/183.out                    |   4 +-
tests/qemu-iotests/184.out                    |  32 +-
tests/qemu-iotests/185                        |   6 +-
tests/qemu-iotests/185.out                    |  45 ++-
tests/qemu-iotests/191.out                    |  16 +-
tests/qemu-iotests/195.out                    |  16 +-
tests/qemu-iotests/223.out                    |  12 +-
tests/qemu-iotests/227.out                    |  32 +-
tests/qemu-iotests/247.out                    |   2 +-
tests/qemu-iotests/264                        |   3 +-
tests/qemu-iotests/273.out                    |   8 +-
tests/qemu-iotests/277                        |   3 +-
tests/qemu-iotests/308                        |   4 +-
tests/qemu-iotests/308.out                    |   4 +-
tests/qemu-iotests/tests/file-io-error        |   5 +-
tests/qemu-iotests/tests/iothreads-resize.out |   2 +-
tests/qemu-iotests/tests/iothreads-stream     |   3 +-
tests/qemu-iotests/tests/qsd-jobs.out         |   4 +-
tests/unit/meson.build                        |   3 +-
59 files changed, 1022 insertions(+), 1028 deletions(-)
delete mode 100644 hw/block/dataplane/trace.h
delete mode 100644 hw/block/dataplane/virtio-blk.h
delete mode 100644 hw/block/dataplane/virtio-blk.c
delete mode 100644 hw/block/dataplane/trace-events
[PULL v3 00/18] Block layer patches
Posted by Kevin Wolf 10 months ago
The following changes since commit 5bab95dc74d43bbb28c6a96d24c810a664432057:

  Merge tag 'pull-request-2024-01-24' of https://gitlab.com/thuth/qemu into staging (2024-01-25 12:33:42 +0000)

are available in the Git repository at:

  https://repo.or.cz/qemu/kevin.git tags/for-upstream

for you to fetch changes up to acf2b9fce9f402b070a65bea584582df0378da9e:

  iotests/277: Use iotests.sock_dir for socket creation (2024-01-26 12:27:41 +0100)

----------------------------------------------------------------
Block layer patches

- virtio-blk: Multiqueue fixes and cleanups
- blklogwrites: Fixes for write_zeroes and superblock update races
- commit/stream: Allow users to request only format driver names in
  backing file format
- monitor: only run coroutine commands in qemu_aio_context
- Some iotest fixes

----------------------------------------------------------------
Andrey Drobyshev (2):
      iotests/264: Use iotests.sock_dir for socket creation
      iotests/277: Use iotests.sock_dir for socket creation

Ari Sundholm (2):
      block/blklogwrites: Fix a bug when logging "write zeroes" operations.
      block/blklogwrites: Protect mutable driver state with a mutex.

Kevin Wolf (3):
      string-output-visitor: Fix (pseudo) struct handling
      tests/unit: Bump test-replication timeout to 60 seconds
      iotests/iothreads-stream: Use the right TimeoutError

Peter Krempa (2):
      commit: Allow users to request only format driver names in backing file format
      stream: Allow users to request only format driver names in backing file format

Stefan Hajnoczi (9):
      iotests: add filter_qmp_generated_node_ids()
      iotests: port 141 to Python for reliable QMP testing
      monitor: only run coroutine commands in qemu_aio_context
      virtio-blk: move dataplane code into virtio-blk.c
      virtio-blk: rename dataplane create/destroy functions
      virtio-blk: rename dataplane to ioeventfd
      virtio-blk: restart s->rq reqs in vq AioContexts
      virtio-blk: tolerate failure to set BlockBackend AioContext
      virtio-blk: always set ioeventfd during startup

 qapi/block-core.json                          |  17 +-
 hw/block/dataplane/trace.h                    |   1 -
 hw/block/dataplane/virtio-blk.h               |  34 ---
 include/block/block-global-state.h            |   3 +-
 include/block/block_int-common.h              |   4 +-
 include/block/block_int-global-state.h        |   6 +
 include/hw/virtio/virtio-blk.h                |  16 +-
 block.c                                       |  37 ++-
 block/blklogwrites.c                          | 120 ++++++--
 block/commit.c                                |   6 +-
 block/monitor/block-hmp-cmds.c                |   2 +-
 block/stream.c                                |  10 +-
 blockdev.c                                    |  13 +
 hw/block/dataplane/virtio-blk.c               | 404 -------------------------
 hw/block/virtio-blk.c                         | 412 ++++++++++++++++++++++++--
 monitor/qmp.c                                 |  17 --
 qapi/qmp-dispatch.c                           |  24 +-
 qapi/string-output-visitor.c                  |  46 +++
 tests/unit/test-bdrv-drain.c                  |   3 +-
 tests/qemu-iotests/iotests.py                 |   7 +
 hw/block/dataplane/meson.build                |   1 -
 hw/block/dataplane/trace-events               |   5 -
 meson.build                                   |   1 -
 tests/qemu-iotests/060.out                    |   4 +-
 tests/qemu-iotests/071.out                    |   4 +-
 tests/qemu-iotests/081.out                    |  16 +-
 tests/qemu-iotests/087.out                    |  12 +-
 tests/qemu-iotests/108.out                    |   2 +-
 tests/qemu-iotests/109                        |   4 +-
 tests/qemu-iotests/109.out                    |  78 +++--
 tests/qemu-iotests/117.out                    |   2 +-
 tests/qemu-iotests/120.out                    |   2 +-
 tests/qemu-iotests/127.out                    |   2 +-
 tests/qemu-iotests/140.out                    |   2 +-
 tests/qemu-iotests/141                        | 307 ++++++++-----------
 tests/qemu-iotests/141.out                    | 200 +++----------
 tests/qemu-iotests/143.out                    |   2 +-
 tests/qemu-iotests/156.out                    |   2 +-
 tests/qemu-iotests/176.out                    |  16 +-
 tests/qemu-iotests/182.out                    |   2 +-
 tests/qemu-iotests/183.out                    |   4 +-
 tests/qemu-iotests/184.out                    |  32 +-
 tests/qemu-iotests/185                        |   6 +-
 tests/qemu-iotests/185.out                    |  45 ++-
 tests/qemu-iotests/191.out                    |  16 +-
 tests/qemu-iotests/195.out                    |  16 +-
 tests/qemu-iotests/223.out                    |  12 +-
 tests/qemu-iotests/227.out                    |  32 +-
 tests/qemu-iotests/247.out                    |   2 +-
 tests/qemu-iotests/264                        |   3 +-
 tests/qemu-iotests/273.out                    |   8 +-
 tests/qemu-iotests/277                        |   3 +-
 tests/qemu-iotests/308                        |   4 +-
 tests/qemu-iotests/308.out                    |   4 +-
 tests/qemu-iotests/tests/file-io-error        |   5 +-
 tests/qemu-iotests/tests/iothreads-resize.out |   2 +-
 tests/qemu-iotests/tests/iothreads-stream     |   3 +-
 tests/qemu-iotests/tests/qsd-jobs.out         |   4 +-
 tests/unit/meson.build                        |   3 +-
 59 files changed, 1022 insertions(+), 1028 deletions(-)
 delete mode 100644 hw/block/dataplane/trace.h
 delete mode 100644 hw/block/dataplane/virtio-blk.h
 delete mode 100644 hw/block/dataplane/virtio-blk.c
 delete mode 100644 hw/block/dataplane/trace-events
Re: [PULL v3 00/18] Block layer patches
Posted by Peter Maydell 10 months ago
On Fri, 26 Jan 2024 at 12:28, Kevin Wolf <kwolf@redhat.com> wrote:
>
> The following changes since commit 5bab95dc74d43bbb28c6a96d24c810a664432057:
>
>   Merge tag 'pull-request-2024-01-24' of https://gitlab.com/thuth/qemu into staging (2024-01-25 12:33:42 +0000)
>
> are available in the Git repository at:
>
>   https://repo.or.cz/qemu/kevin.git tags/for-upstream
>
> for you to fetch changes up to acf2b9fce9f402b070a65bea584582df0378da9e:
>
>   iotests/277: Use iotests.sock_dir for socket creation (2024-01-26 12:27:41 +0100)
>
> ----------------------------------------------------------------
> Block layer patches
>
> - virtio-blk: Multiqueue fixes and cleanups
> - blklogwrites: Fixes for write_zeroes and superblock update races
> - commit/stream: Allow users to request only format driver names in
>   backing file format
> - monitor: only run coroutine commands in qemu_aio_context
> - Some iotest fixes
>


Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/9.0
for any user-visible changes.

-- PMM
Re: [PULL v3 00/18] Block layer patches
Posted by Peter Maydell 10 months ago
On Fri, 26 Jan 2024 at 12:28, Kevin Wolf <kwolf@redhat.com> wrote:
>
> The following changes since commit 5bab95dc74d43bbb28c6a96d24c810a664432057:
>
>   Merge tag 'pull-request-2024-01-24' of https://gitlab.com/thuth/qemu into staging (2024-01-25 12:33:42 +0000)
>
> are available in the Git repository at:
>
>   https://repo.or.cz/qemu/kevin.git tags/for-upstream
>
> for you to fetch changes up to acf2b9fce9f402b070a65bea584582df0378da9e:
>
>   iotests/277: Use iotests.sock_dir for socket creation (2024-01-26 12:27:41 +0100)
>
> ----------------------------------------------------------------
> Block layer patches
>
> - virtio-blk: Multiqueue fixes and cleanups
> - blklogwrites: Fixes for write_zeroes and superblock update races
> - commit/stream: Allow users to request only format driver names in
>   backing file format
> - monitor: only run coroutine commands in qemu_aio_context
> - Some iotest fixes
>
> ----------------------------------------------------------------

Not specific to this pullreq, but I've started seeing occasional
failures of iotest 144, apparently due to a '{"return": {}}'
line in the output not always appearing at the same point:

https://gitlab.com/qemu-project/qemu/-/issues/2126

Could you (or some other block person) have a look, please?

(In the meantime, I'm still testing this pullreq.)

-- PMM