[v11] Introduce model for IBM's FSI

[PATCH v11 00/11] Introduce model for IBM's FSI

Ninad Palsule posted 11 patches 10 months ago

Diff against v2 v3 v4 v5 v6 v7 v8 v9 v10 v12
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20240126034026.31068-1-ninad@linux.ibm.com

Maintainers: Ninad Palsule <ninad@linux.ibm.com>, "Cédric Le Goater" <clg@kaod.org>, Paolo Bonzini <pbonzini@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, Andrew Jeffery <andrew@codeconstruct.com.au>, Joel Stanley <joel@jms.id.au>, "Marc-André Lureau" <marcandre.lureau@redhat.com>, "Daniel P. Berrangé" <berrange@redhat.com>, Thomas Huth <thuth@redhat.com>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Laurent Vivier <lvivier@redhat.com>

There is a newer version of this series

MAINTAINERS                     |   9 +
docs/specs/fsi.rst              | 138 ++++++++++++++
docs/specs/index.rst            |   1 +
meson.build                     |   1 +
hw/fsi/trace.h                  |   1 +
include/hw/arm/aspeed_soc.h     |   4 +
include/hw/fsi/aspeed_apb2opb.h |  46 +++++
include/hw/fsi/cfam.h           |  34 ++++
include/hw/fsi/fsi-master.h     |  32 ++++
include/hw/fsi/fsi.h            |  38 ++++
include/hw/fsi/lbus.h           |  43 +++++
hw/arm/aspeed_ast2600.c         |  19 ++
hw/fsi/aspeed_apb2opb.c         | 322 ++++++++++++++++++++++++++++++++
hw/fsi/cfam.c                   | 168 +++++++++++++++++
hw/fsi/fsi-master.c             | 170 +++++++++++++++++
hw/fsi/fsi.c                    | 105 +++++++++++
hw/fsi/lbus.c                   | 112 +++++++++++
tests/qtest/aspeed-fsi-test.c   | 205 ++++++++++++++++++++
hw/Kconfig                      |   1 +
hw/arm/Kconfig                  |   1 +
hw/fsi/Kconfig                  |   7 +
hw/fsi/meson.build              |   2 +
hw/fsi/trace-events             |  13 ++
hw/meson.build                  |   1 +
tests/qtest/meson.build         |   1 +
25 files changed, 1474 insertions(+)
create mode 100644 docs/specs/fsi.rst
create mode 100644 hw/fsi/trace.h
create mode 100644 include/hw/fsi/aspeed_apb2opb.h
create mode 100644 include/hw/fsi/cfam.h
create mode 100644 include/hw/fsi/fsi-master.h
create mode 100644 include/hw/fsi/fsi.h
create mode 100644 include/hw/fsi/lbus.h
create mode 100644 hw/fsi/aspeed_apb2opb.c
create mode 100644 hw/fsi/cfam.c
create mode 100644 hw/fsi/fsi-master.c
create mode 100644 hw/fsi/fsi.c
create mode 100644 hw/fsi/lbus.c
create mode 100644 tests/qtest/aspeed-fsi-test.c
create mode 100644 hw/fsi/Kconfig
create mode 100644 hw/fsi/meson.build
create mode 100644 hw/fsi/trace-events

Expand all Fold all

[PATCH v11 00/11] Introduce model for IBM's FSI

Posted by Ninad Palsule 10 months ago

Hello,
 
Please review the patch-set version 11. 
I have incorporated review comments from Cedric.
v10:
  - Moved aspeed-apb2opb to hw/fsi directory
  - Split some patches.
  - Fixed crash.
  - make check
    Ok:                 319 
    Expected Fail:      0   
    Fail:               0   
    Unexpected Pass:    0   
    Skipped:            9   
    Timeout:            0   


Ninad Palsule (11):
  hw/fsi: Introduce IBM's Local bus
  hw/fsi: Introduce IBM's scratchpad device
  hw/fsi: Introduce IBM's FSI Bus
  hw/fsi: Introduce IBM's fsi-slave model
  hw/fsi: Introduce IBM's cfam
  hw/fsi: Introduce IBM's FSI master
  hw/fsi: Aspeed APB2OPB & On-chip peripheral bus
  hw/arm: Hook up FSI module in AST2600
  hw/fsi: Added qtest
  hw/fsi: Added FSI documentation
  hw/fsi: Update MAINTAINER list

 MAINTAINERS                     |   9 +
 docs/specs/fsi.rst              | 138 ++++++++++++++
 docs/specs/index.rst            |   1 +
 meson.build                     |   1 +
 hw/fsi/trace.h                  |   1 +
 include/hw/arm/aspeed_soc.h     |   4 +
 include/hw/fsi/aspeed_apb2opb.h |  46 +++++
 include/hw/fsi/cfam.h           |  34 ++++
 include/hw/fsi/fsi-master.h     |  32 ++++
 include/hw/fsi/fsi.h            |  38 ++++
 include/hw/fsi/lbus.h           |  43 +++++
 hw/arm/aspeed_ast2600.c         |  19 ++
 hw/fsi/aspeed_apb2opb.c         | 322 ++++++++++++++++++++++++++++++++
 hw/fsi/cfam.c                   | 168 +++++++++++++++++
 hw/fsi/fsi-master.c             | 170 +++++++++++++++++
 hw/fsi/fsi.c                    | 105 +++++++++++
 hw/fsi/lbus.c                   | 112 +++++++++++
 tests/qtest/aspeed-fsi-test.c   | 205 ++++++++++++++++++++
 hw/Kconfig                      |   1 +
 hw/arm/Kconfig                  |   1 +
 hw/fsi/Kconfig                  |   7 +
 hw/fsi/meson.build              |   2 +
 hw/fsi/trace-events             |  13 ++
 hw/meson.build                  |   1 +
 tests/qtest/meson.build         |   1 +
 25 files changed, 1474 insertions(+)
 create mode 100644 docs/specs/fsi.rst
 create mode 100644 hw/fsi/trace.h
 create mode 100644 include/hw/fsi/aspeed_apb2opb.h
 create mode 100644 include/hw/fsi/cfam.h
 create mode 100644 include/hw/fsi/fsi-master.h
 create mode 100644 include/hw/fsi/fsi.h
 create mode 100644 include/hw/fsi/lbus.h
 create mode 100644 hw/fsi/aspeed_apb2opb.c
 create mode 100644 hw/fsi/cfam.c
 create mode 100644 hw/fsi/fsi-master.c
 create mode 100644 hw/fsi/fsi.c
 create mode 100644 hw/fsi/lbus.c
 create mode 100644 tests/qtest/aspeed-fsi-test.c
 create mode 100644 hw/fsi/Kconfig
 create mode 100644 hw/fsi/meson.build
 create mode 100644 hw/fsi/trace-events

-- 
2.39.2

Re: [PATCH v11 00/11] Introduce model for IBM's FSI

Posted by Cédric Le Goater 10 months ago

Hello Ninad,

On 1/26/24 04:40, Ninad Palsule wrote:
> Hello,
>   
> Please review the patch-set version 11.
> I have incorporated review comments from Cedric.
> v10:
>    - Moved aspeed-apb2opb to hw/fsi directory
>    - Split some patches.
>    - Fixed crash.
>    - make check
>      Ok:                 319
>      Expected Fail:      0
>      Fail:               0
>      Unexpected Pass:    0
>      Skipped:            9
>      Timeout:            0

I did some minor comments. v12 should be queued for upstream. I will
reorder the Signed-off (mine) trailers.

Thanks,

C.

> 
> 
> Ninad Palsule (11):
>    hw/fsi: Introduce IBM's Local bus
>    hw/fsi: Introduce IBM's scratchpad device
>    hw/fsi: Introduce IBM's FSI Bus
>    hw/fsi: Introduce IBM's fsi-slave model
>    hw/fsi: Introduce IBM's cfam
>    hw/fsi: Introduce IBM's FSI master
>    hw/fsi: Aspeed APB2OPB & On-chip peripheral bus
>    hw/arm: Hook up FSI module in AST2600
>    hw/fsi: Added qtest
>    hw/fsi: Added FSI documentation
>    hw/fsi: Update MAINTAINER list
> 
>   MAINTAINERS                     |   9 +
>   docs/specs/fsi.rst              | 138 ++++++++++++++
>   docs/specs/index.rst            |   1 +
>   meson.build                     |   1 +
>   hw/fsi/trace.h                  |   1 +
>   include/hw/arm/aspeed_soc.h     |   4 +
>   include/hw/fsi/aspeed_apb2opb.h |  46 +++++
>   include/hw/fsi/cfam.h           |  34 ++++
>   include/hw/fsi/fsi-master.h     |  32 ++++
>   include/hw/fsi/fsi.h            |  38 ++++
>   include/hw/fsi/lbus.h           |  43 +++++
>   hw/arm/aspeed_ast2600.c         |  19 ++
>   hw/fsi/aspeed_apb2opb.c         | 322 ++++++++++++++++++++++++++++++++
>   hw/fsi/cfam.c                   | 168 +++++++++++++++++
>   hw/fsi/fsi-master.c             | 170 +++++++++++++++++
>   hw/fsi/fsi.c                    | 105 +++++++++++
>   hw/fsi/lbus.c                   | 112 +++++++++++
>   tests/qtest/aspeed-fsi-test.c   | 205 ++++++++++++++++++++
>   hw/Kconfig                      |   1 +
>   hw/arm/Kconfig                  |   1 +
>   hw/fsi/Kconfig                  |   7 +
>   hw/fsi/meson.build              |   2 +
>   hw/fsi/trace-events             |  13 ++
>   hw/meson.build                  |   1 +
>   tests/qtest/meson.build         |   1 +
>   25 files changed, 1474 insertions(+)
>   create mode 100644 docs/specs/fsi.rst
>   create mode 100644 hw/fsi/trace.h
>   create mode 100644 include/hw/fsi/aspeed_apb2opb.h
>   create mode 100644 include/hw/fsi/cfam.h
>   create mode 100644 include/hw/fsi/fsi-master.h
>   create mode 100644 include/hw/fsi/fsi.h
>   create mode 100644 include/hw/fsi/lbus.h
>   create mode 100644 hw/fsi/aspeed_apb2opb.c
>   create mode 100644 hw/fsi/cfam.c
>   create mode 100644 hw/fsi/fsi-master.c
>   create mode 100644 hw/fsi/fsi.c
>   create mode 100644 hw/fsi/lbus.c
>   create mode 100644 tests/qtest/aspeed-fsi-test.c
>   create mode 100644 hw/fsi/Kconfig
>   create mode 100644 hw/fsi/meson.build
>   create mode 100644 hw/fsi/trace-events
>

Re: [PATCH v11 00/11] Introduce model for IBM's FSI

Posted by Ninad Palsule 10 months ago

Hello Cedric,


> I did some minor comments. v12 should be queued for upstream. I will
> reorder the Signed-off (mine) trailers.

Thanks a lot for detailed review.

Regards,

Ninad