[PATCH] configure: run plugin TCG tests again

Paolo Bonzini posted 1 patch 10 months, 1 week ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20240124115332.612162-1-pbonzini@redhat.com
Maintainers: Paolo Bonzini <pbonzini@redhat.com>, "Alex Bennée" <alex.bennee@linaro.org>, Thomas Huth <thuth@redhat.com>
configure | 3 +++
1 file changed, 3 insertions(+)
[PATCH] configure: run plugin TCG tests again
Posted by Paolo Bonzini 10 months, 1 week ago
Commit 39fb3cfc28b ("configure: clean up plugin option handling", 2023-10-18)
dropped the CONFIG_PLUGIN line from tests/tcg/config-host.mak, due to confusion
caused by the shadowing of $config_host_mak.  However, TCG tests were still
expecting it.  Oops.

Put it back, in the meanwhile the shadowing is gone so it's clear that it goes
in the tests/tcg configuration.

Cc: alex.bennee@linaro.org
Fixes: 39fb3cfc28b ("configure: clean up plugin option handling", 2023-10-18)
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 configure | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/configure b/configure
index 3d8e24ae011..ff058d6c486 100755
--- a/configure
+++ b/configure
@@ -1644,6 +1644,9 @@ fi
 mkdir -p tests/tcg
 echo "# Automatically generated by configure - do not modify" > tests/tcg/$config_host_mak
 echo "SRC_PATH=$source_path" >> tests/tcg/$config_host_mak
+if test "$plugins" = "yes" ; then
+    echo "CONFIG_PLUGIN=y" >> tests/tcg/$config_host_mak
+fi
 
 tcg_tests_targets=
 for target in $target_list; do
-- 
2.43.0
Re: [PATCH] configure: run plugin TCG tests again
Posted by Alex Bennée 10 months ago
Paolo Bonzini <pbonzini@redhat.com> writes:

> Commit 39fb3cfc28b ("configure: clean up plugin option handling", 2023-10-18)
> dropped the CONFIG_PLUGIN line from tests/tcg/config-host.mak, due to confusion
> caused by the shadowing of $config_host_mak.  However, TCG tests were still
> expecting it.  Oops.
>
> Put it back, in the meanwhile the shadowing is gone so it's clear that it goes
> in the tests/tcg configuration.

Queued to testing/next, thanks.

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro