tests/avocado: improve flaky ppc/pnv boot_linux_console.py test

[PATCH] tests/avocado: improve flaky ppc/pnv boot_linux_console.py test

Nicholas Piggin posted 1 patch 10 months, 1 week ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20240124060134.406331-1-npiggin@gmail.com

Maintainers: Cleber Rosa <crosa@redhat.com>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Wainer dos Santos Moschetta <wainersm@redhat.com>, Beraldo Leal <bleal@redhat.com>

tests/avocado/boot_linux_console.py | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

Expand all Fold all

[PATCH] tests/avocado: improve flaky ppc/pnv boot_linux_console.py test

Posted by Nicholas Piggin 10 months, 1 week ago

The expected MTD partition detection output does not always appear on
the console, despite the test reaching the boot loader and the string
appearing in dmesg. Possibly due to an init script that quietens the
console output. Using an earlier log message improves reliability.

Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
---
 tests/avocado/boot_linux_console.py | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tests/avocado/boot_linux_console.py b/tests/avocado/boot_linux_console.py
index 3f0180e1f8..922a9e7b79 100644
--- a/tests/avocado/boot_linux_console.py
+++ b/tests/avocado/boot_linux_console.py
@@ -1368,7 +1368,9 @@ def do_test_ppc64_powernv(self, proc):
         self.wait_for_console_pattern("CPU: " + proc + " generation processor")
         self.wait_for_console_pattern("zImage starting: loaded")
         self.wait_for_console_pattern("Run /init as init process")
-        self.wait_for_console_pattern("Creating 1 MTD partitions")
+        self.wait_for_console_pattern("rtc-opal opal-rtc: setting system clock")
+        # MTD partition detection output is sometimes cut off from console
+        # output, suspect S14silence-console init script.
 
     def test_ppc_powernv8(self):
         """
-- 
2.42.0

Re: [PATCH] tests/avocado: improve flaky ppc/pnv boot_linux_console.py test

Posted by Cédric Le Goater 10 months ago

On 1/24/24 07:01, Nicholas Piggin wrote:
> The expected MTD partition detection output does not always appear on
> the console, despite the test reaching the boot loader and the string
> appearing in dmesg. Possibly due to an init script that quietens the
> console output. Using an earlier log message improves reliability.
> 
> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
> ---
>   tests/avocado/boot_linux_console.py | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/avocado/boot_linux_console.py b/tests/avocado/boot_linux_console.py
> index 3f0180e1f8..922a9e7b79 100644
> --- a/tests/avocado/boot_linux_console.py
> +++ b/tests/avocado/boot_linux_console.py
> @@ -1368,7 +1368,9 @@ def do_test_ppc64_powernv(self, proc):
>           self.wait_for_console_pattern("CPU: " + proc + " generation processor")
>           self.wait_for_console_pattern("zImage starting: loaded")
>           self.wait_for_console_pattern("Run /init as init process")
> -        self.wait_for_console_pattern("Creating 1 MTD partitions")
> +        self.wait_for_console_pattern("rtc-opal opal-rtc: setting system clock")
> +        # MTD partition detection output is sometimes cut off from console
> +        # output, suspect S14silence-console init script.
>   
>       def test_ppc_powernv8(self):
>           """



Reviewed-by: Cédric Le Goater <clg@kaod.org>

Thanks,

C.