[PATCH 5/5] util/uri: Remove unused macros ISA_RESERVED() and ISA_GEN_DELIM()

Thomas Huth posted 5 patches 10 months, 1 week ago
There is a newer version of this series
[PATCH 5/5] util/uri: Remove unused macros ISA_RESERVED() and ISA_GEN_DELIM()
Posted by Thomas Huth 10 months, 1 week ago
They are not used anywhere, so there's no need to keep them around.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 util/uri.c | 13 -------------
 1 file changed, 13 deletions(-)

diff --git a/util/uri.c b/util/uri.c
index 5f5ca79792..2deab91da3 100644
--- a/util/uri.c
+++ b/util/uri.c
@@ -163,19 +163,6 @@ static void uri_clean(URI *uri);
      ((*(p) == '+')) || ((*(p) == ',')) || ((*(p) == ';')) ||                  \
      ((*(p) == '=')) || ((*(p) == '\'')))
 
-/*
- *    gen-delims    = ":" / "/" / "?" / "#" / "[" / "]" / "@"
- */
-#define ISA_GEN_DELIM(p)                                                       \
-    (((*(p) == ':')) || ((*(p) == '/')) || ((*(p) == '?')) ||                  \
-     ((*(p) == '#')) || ((*(p) == '[')) || ((*(p) == ']')) ||                  \
-     ((*(p) == '@')))
-
-/*
- *    reserved      = gen-delims / sub-delims
- */
-#define ISA_RESERVED(p) (ISA_GEN_DELIM(p) || (ISA_SUB_DELIM(p)))
-
 /*
  *    unreserved    = ALPHA / DIGIT / "-" / "." / "_" / "~"
  */
-- 
2.43.0
Re: [PATCH 5/5] util/uri: Remove unused macros ISA_RESERVED() and ISA_GEN_DELIM()
Posted by Philippe Mathieu-Daudé 10 months, 1 week ago
On 22/1/24 20:17, Thomas Huth wrote:
> They are not used anywhere, so there's no need to keep them around.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>   util/uri.c | 13 -------------
>   1 file changed, 13 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

(could be reordered as patch 1 to clarify it is not
  an effect of the uri_string_foo() cleanups)

Re: [PATCH 5/5] util/uri: Remove unused macros ISA_RESERVED() and ISA_GEN_DELIM()
Posted by Stefan Weil via 10 months, 1 week ago
Am 22.01.24 um 20:17 schrieb Thomas Huth:

> They are not used anywhere, so there's no need to keep them around.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>   util/uri.c | 13 -------------
>   1 file changed, 13 deletions(-)
>

Reviewed-by: Stefan Weil <sw@weilnetz.de>