[v1] util/uri: Simplify the code, remove unused functions

[PATCH 0/5] util/uri: Simplify the code, remove unused functions

Thomas Huth posted 5 patches 10 months, 1 week ago

Diff against v2
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20240122191753.103118-1-thuth@redhat.com

There is a newer version of this series

include/qemu/uri.h |   5 +-
util/uri.c         | 843 +--------------------------------------------
2 files changed, 16 insertions(+), 832 deletions(-)

Expand all Fold all

[PATCH 0/5] util/uri: Simplify the code, remove unused functions

Posted by Thomas Huth 10 months, 1 week ago

The URI function uri_string_unescape() has some overlap with functions
from the glib, so we can simplify our code here quite a bit.
While at it, I also noticed that there are many unused functions in
here which we likely can drop nowadays (it's better to use the functions
from glib anyway).

Thomas Huth (5):
  util/uri: Remove the unused "target" argument from
    uri_string_unescape()
  util/uri: Simplify uri_string_unescape()
  util/uri: Remove the uri_string_escape() function
  util/uri: Remove unused functions uri_resolve() and
    uri_resolve_relative()
  util/uri: Remove unused macros ISA_RESERVED() and ISA_GEN_DELIM()

 include/qemu/uri.h |   5 +-
 util/uri.c         | 843 +--------------------------------------------
 2 files changed, 16 insertions(+), 832 deletions(-)

-- 
2.43.0

Re: [PATCH 0/5] util/uri: Simplify the code, remove unused functions

Posted by Daniel P. Berrangé 10 months, 1 week ago

On Mon, Jan 22, 2024 at 08:17:48PM +0100, Thomas Huth wrote:
> The URI function uri_string_unescape() has some overlap with functions
> from the glib, so we can simplify our code here quite a bit.
> While at it, I also noticed that there are many unused functions in
> here which we likely can drop nowadays (it's better to use the functions
> from glib anyway).
> 
> Thomas Huth (5):
>   util/uri: Remove the unused "target" argument from
>     uri_string_unescape()
>   util/uri: Simplify uri_string_unescape()
>   util/uri: Remove the uri_string_escape() function
>   util/uri: Remove unused functions uri_resolve() and
>     uri_resolve_relative()
>   util/uri: Remove unused macros ISA_RESERVED() and ISA_GEN_DELIM()
> 
>  include/qemu/uri.h |   5 +-
>  util/uri.c         | 843 +--------------------------------------------
>  2 files changed, 16 insertions(+), 832 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|