[v4] migration & CI: Add a CI job for migration compat testing

[PATCH v4 0/3] migration & CI: Add a CI job for migration compat testing

Posted by Fabiano Rosas 8 months ago

Here's the second half of adding a migration compatibility test to CI.

We've already added support for running the full set of migration
tests with two QEMU binaries since commit 5050ad2a380
("tests/qtest/migration: Support more than one QEMU binary"), now
what's left is adding it to the CI.

changes since v3:

- Removed all the 'since' logic and started using the n-1 version of
  the tests.

- New patch to fix the aarch64 cpu. We shouldn't have been using
  'max'.

- New patch to disable aarch64 tests while the fix^ doesn't reach a
  released version.

v3:
https://lore.kernel.org/r/20240105180449.11562-1-farosas@suse.de
v2:
https://lore.kernel.org/r/20240104171857.20108-1-farosas@suse.de
v1:
https://lore.kernel.org/r/20231207155809.25673-1-farosas@suse.de

Fabiano Rosas (3):
  tests/qtest/migration: Don't use -cpu max for aarch64
  ci: Add a migration compatibility test job
  ci: Disable migration compatibility tests for aarch64

 .gitlab-ci.d/buildtest.yml   | 64 ++++++++++++++++++++++++++++++++++++
 tests/qtest/migration-test.c |  2 +-
 2 files changed, 65 insertions(+), 1 deletion(-)

-- 
2.35.3

Re: [PATCH v4 0/3] migration & CI: Add a CI job for migration compat testing

Posted by Peter Xu 8 months ago

Fabiano,

On Thu, Jan 18, 2024 at 01:49:48PM -0300, Fabiano Rosas wrote:
> Here's the second half of adding a migration compatibility test to CI.
> 
> We've already added support for running the full set of migration
> tests with two QEMU binaries since commit 5050ad2a380
> ("tests/qtest/migration: Support more than one QEMU binary"), now
> what's left is adding it to the CI.
> 
> changes since v3:
> 
> - Removed all the 'since' logic and started using the n-1 version of
>   the tests.
> 
> - New patch to fix the aarch64 cpu. We shouldn't have been using
>   'max'.
> 
> - New patch to disable aarch64 tests while the fix^ doesn't reach a
>   released version.
> 
> v3:
> https://lore.kernel.org/r/20240105180449.11562-1-farosas@suse.de
> v2:
> https://lore.kernel.org/r/20240104171857.20108-1-farosas@suse.de
> v1:
> https://lore.kernel.org/r/20231207155809.25673-1-farosas@suse.de

I gave it a try but build-previous-qemu somehow failed..

  https://gitlab.com/peterx/qemu/-/jobs/5965634871

You normally attach a "CI run" which I wanted to reference, but it's gone
in this v4 unfortunately.  The error:

  error: pathspec 'v8.2.0' did not match any file(s) known to git

is pretty weird, and I had a feeling it was something wrong before that.
Maybe it's because I tried to run this specific test multiple times (and
all failed), somehow the wrong thing was cached, so the real error (of the
1st run when there is no cache) could have got lost.  Not sure.

Please have a look when you have time, thanks.

> 
> Fabiano Rosas (3):
>   tests/qtest/migration: Don't use -cpu max for aarch64
>   ci: Add a migration compatibility test job
>   ci: Disable migration compatibility tests for aarch64
> 
>  .gitlab-ci.d/buildtest.yml   | 64 ++++++++++++++++++++++++++++++++++++
>  tests/qtest/migration-test.c |  2 +-
>  2 files changed, 65 insertions(+), 1 deletion(-)
> 
> -- 
> 2.35.3
> 

-- 
Peter Xu

Re: [PATCH v4 0/3] migration & CI: Add a CI job for migration compat testing

Posted by Fabiano Rosas 8 months ago

Peter Xu <peterx@redhat.com> writes:

> Fabiano,
>
> On Thu, Jan 18, 2024 at 01:49:48PM -0300, Fabiano Rosas wrote:
>> Here's the second half of adding a migration compatibility test to CI.
>> 
>> We've already added support for running the full set of migration
>> tests with two QEMU binaries since commit 5050ad2a380
>> ("tests/qtest/migration: Support more than one QEMU binary"), now
>> what's left is adding it to the CI.
>> 
>> changes since v3:
>> 
>> - Removed all the 'since' logic and started using the n-1 version of
>>   the tests.
>> 
>> - New patch to fix the aarch64 cpu. We shouldn't have been using
>>   'max'.
>> 
>> - New patch to disable aarch64 tests while the fix^ doesn't reach a
>>   released version.
>> 
>> v3:
>> https://lore.kernel.org/r/20240105180449.11562-1-farosas@suse.de
>> v2:
>> https://lore.kernel.org/r/20240104171857.20108-1-farosas@suse.de
>> v1:
>> https://lore.kernel.org/r/20231207155809.25673-1-farosas@suse.de
>
> I gave it a try but build-previous-qemu somehow failed..
>
>   https://gitlab.com/peterx/qemu/-/jobs/5965634871
>
> You normally attach a "CI run" which I wanted to reference, but it's gone
> in this v4 unfortunately.  The error:
>
>   error: pathspec 'v8.2.0' did not match any file(s) known to git

I mentioned this at the bottom of the commit message for patch 2/3. You
need to push your tags. Otherwise your fork on gitlab won't have
knowledge of v8.2.0.

Re: [PATCH v4 0/3] migration & CI: Add a CI job for migration compat testing

Posted by Peter Xu 8 months ago

On Fri, Jan 19, 2024 at 10:01:31AM -0300, Fabiano Rosas wrote:
> I mentioned this at the bottom of the commit message for patch 2/3. You
> need to push your tags. Otherwise your fork on gitlab won't have
> knowledge of v8.2.0.

Oops, my fault.  Yeah it works now; I queued this into staging.

Thanks,

-- 
Peter Xu