1. Patchew
  2. QEMU
  3. View series

[PATCH 0/8] tests/unit/test-smp-parse.c: Add more CPU topology test cases

Zhao Liu posted 8 patches 8 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20240118144857.2124034-1-zhao1.liu@linux.intel.com
Maintainers: Eduardo Habkost <eduardo@habkost.net>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Yanan Wang <wangyanan55@huawei.com>
tests/unit/test-smp-parse.c | 515 ++++++++++++++++++++++++++++++++++--
1 file changed, 494 insertions(+), 21 deletions(-)
[PATCH 0/8] tests/unit/test-smp-parse.c: Add more CPU topology test cases
Posted by Zhao Liu 8 months ago 
From: Zhao Liu <zhao1.liu@intel.com>

Hi list,

Currently, test-smp-parse lacks the following cases:
* The case to cover drawer and book parameters parsing in -smp.
* The case to cover the full topology (with total 7 levels) to ensure
  that the topology-related calculations are correct.
* The case to check smp_props.has_clusters of MachineClass.

Thus, add the above cases to improve test coverage.

In addition, people is trying to bump max_cpus to 4096 for PC machine
[1]. Without considering other changes, it's only a matter of time
before the maximum CPUs is raised. Therefore, aslo bump max_cpus to 4096
in -smp related test cases as a start.

[1]: https://lore.kernel.org/qemu-devel/20231208122611.32311-1-anisinha@redhat.com/

Regards,
Zhao

---
Zhao Liu (8):
  tests/unit/test-smp-parse.c: Use CPU number macros in invalid topology
    case
  tests/unit/test-smp-parse.c: Bump max_cpus to 4096
  tests/unit/test-smp-parse.c: Make test cases aware of the book/drawer
  tests/unit/test-smp-parse.c: Test "books" parameter in -smp
  tests/unit/test-smp-parse.c: Test "drawers" parameter in -smp
  tests/unit/test-smp-parse.c: Test "drawers" and "books" combination
    case
  tests/unit/test-smp-parse.c: Test the full 7-levels topology hierarchy
  tests/unit/test-smp-parse.c: Test smp_props.has_clusters

 tests/unit/test-smp-parse.c | 515 ++++++++++++++++++++++++++++++++++--
 1 file changed, 494 insertions(+), 21 deletions(-)

-- 
2.34.1
Re: [PATCH 0/8] tests/unit/test-smp-parse.c: Add more CPU topology test cases
Posted by Zhao Liu 7 months, 3 weeks ago 
Hi Philippe,

A kindly ping.

Thanks,
Zhao

On Thu, Jan 18, 2024 at 10:48:49PM +0800, Zhao Liu wrote:
> Date: Thu, 18 Jan 2024 22:48:49 +0800
> From: Zhao Liu <zhao1.liu@linux.intel.com>
> Subject: [PATCH 0/8] tests/unit/test-smp-parse.c: Add more CPU topology
>  test cases
> X-Mailer: git-send-email 2.34.1
> 
> From: Zhao Liu <zhao1.liu@intel.com>
> 
> Hi list,
> 
> Currently, test-smp-parse lacks the following cases:
> * The case to cover drawer and book parameters parsing in -smp.
> * The case to cover the full topology (with total 7 levels) to ensure
>   that the topology-related calculations are correct.
> * The case to check smp_props.has_clusters of MachineClass.
> 
> Thus, add the above cases to improve test coverage.
> 
> In addition, people is trying to bump max_cpus to 4096 for PC machine
> [1]. Without considering other changes, it's only a matter of time
> before the maximum CPUs is raised. Therefore, aslo bump max_cpus to 4096
> in -smp related test cases as a start.
> 
> [1]: https://lore.kernel.org/qemu-devel/20231208122611.32311-1-anisinha@redhat.com/
> 
> Regards,
> Zhao
> 
> ---
> Zhao Liu (8):
>   tests/unit/test-smp-parse.c: Use CPU number macros in invalid topology
>     case
>   tests/unit/test-smp-parse.c: Bump max_cpus to 4096
>   tests/unit/test-smp-parse.c: Make test cases aware of the book/drawer
>   tests/unit/test-smp-parse.c: Test "books" parameter in -smp
>   tests/unit/test-smp-parse.c: Test "drawers" parameter in -smp
>   tests/unit/test-smp-parse.c: Test "drawers" and "books" combination
>     case
>   tests/unit/test-smp-parse.c: Test the full 7-levels topology hierarchy
>   tests/unit/test-smp-parse.c: Test smp_props.has_clusters
> 
>  tests/unit/test-smp-parse.c | 515 ++++++++++++++++++++++++++++++++++--
>  1 file changed, 494 insertions(+), 21 deletions(-)
> 
> -- 
> 2.34.1
> 
>
Re: [PATCH 0/8] tests/unit/test-smp-parse.c: Add more CPU topology test cases
Posted by Zhao Liu 7 months ago 
Hi Philippe,

Could you pls help me review this series?

...Except you, I'm not sure the other machine core maintainers will
review this.

If this series is acceptable, next I can add module level test case,
cache topology test case and more clean up based on this.

Thanks,
Zhao

On Mon, Jan 29, 2024 at 05:38:24PM +0800, Zhao Liu wrote:
> Date: Mon, 29 Jan 2024 17:38:24 +0800
> From: Zhao Liu <zhao1.liu@linux.intel.com>
> Subject: Re: [PATCH 0/8] tests/unit/test-smp-parse.c: Add more CPU topology
>  test cases
> 
> Hi Philippe,
> 
> A kindly ping.
> 
> Thanks,
> Zhao
> 
> On Thu, Jan 18, 2024 at 10:48:49PM +0800, Zhao Liu wrote:
> > Date: Thu, 18 Jan 2024 22:48:49 +0800
> > From: Zhao Liu <zhao1.liu@linux.intel.com>
> > Subject: [PATCH 0/8] tests/unit/test-smp-parse.c: Add more CPU topology
> >  test cases
> > X-Mailer: git-send-email 2.34.1
> > 
> > From: Zhao Liu <zhao1.liu@intel.com>
> > 
> > Hi list,
> > 
> > Currently, test-smp-parse lacks the following cases:
> > * The case to cover drawer and book parameters parsing in -smp.
> > * The case to cover the full topology (with total 7 levels) to ensure
> >   that the topology-related calculations are correct.
> > * The case to check smp_props.has_clusters of MachineClass.
> > 
> > Thus, add the above cases to improve test coverage.
> > 
> > In addition, people is trying to bump max_cpus to 4096 for PC machine
> > [1]. Without considering other changes, it's only a matter of time
> > before the maximum CPUs is raised. Therefore, aslo bump max_cpus to 4096
> > in -smp related test cases as a start.
> > 
> > [1]: https://lore.kernel.org/qemu-devel/20231208122611.32311-1-anisinha@redhat.com/
> > 
> > Regards,
> > Zhao
> > 
> > ---
> > Zhao Liu (8):
> >   tests/unit/test-smp-parse.c: Use CPU number macros in invalid topology
> >     case
> >   tests/unit/test-smp-parse.c: Bump max_cpus to 4096
> >   tests/unit/test-smp-parse.c: Make test cases aware of the book/drawer
> >   tests/unit/test-smp-parse.c: Test "books" parameter in -smp
> >   tests/unit/test-smp-parse.c: Test "drawers" parameter in -smp
> >   tests/unit/test-smp-parse.c: Test "drawers" and "books" combination
> >     case
> >   tests/unit/test-smp-parse.c: Test the full 7-levels topology hierarchy
> >   tests/unit/test-smp-parse.c: Test smp_props.has_clusters
> > 
> >  tests/unit/test-smp-parse.c | 515 ++++++++++++++++++++++++++++++++++--
> >  1 file changed, 494 insertions(+), 21 deletions(-)
> > 
> > -- 
> > 2.34.1
> > 
> > 
>
Re: [PATCH 0/8] tests/unit/test-smp-parse.c: Add more CPU topology test cases
Posted by Song, Xiaoling 7 months, 3 weeks ago 
I tested the unit test cases with "make check" and result looks good.

Tested-by: Xiaoling Song <xiaoling.song@intel.com>

Regards,

Xiaoling

On 1/18/2024 10:48 PM, Zhao Liu wrote:
> From: Zhao Liu<zhao1.liu@intel.com>
>
> Hi list,
>
> Currently, test-smp-parse lacks the following cases:
> * The case to cover drawer and book parameters parsing in -smp.
> * The case to cover the full topology (with total 7 levels) to ensure
>    that the topology-related calculations are correct.
> * The case to check smp_props.has_clusters of MachineClass.
>
> Thus, add the above cases to improve test coverage.
>
> In addition, people is trying to bump max_cpus to 4096 for PC machine
> [1]. Without considering other changes, it's only a matter of time
> before the maximum CPUs is raised. Therefore, aslo bump max_cpus to 4096
> in -smp related test cases as a start.
>
> [1]:https://lore.kernel.org/qemu-devel/20231208122611.32311-1-anisinha@redhat.com/
>
> Regards,
> Zhao
>
> ---
> Zhao Liu (8):
>    tests/unit/test-smp-parse.c: Use CPU number macros in invalid topology
>      case
>    tests/unit/test-smp-parse.c: Bump max_cpus to 4096
>    tests/unit/test-smp-parse.c: Make test cases aware of the book/drawer
>    tests/unit/test-smp-parse.c: Test "books" parameter in -smp
>    tests/unit/test-smp-parse.c: Test "drawers" parameter in -smp
>    tests/unit/test-smp-parse.c: Test "drawers" and "books" combination
>      case
>    tests/unit/test-smp-parse.c: Test the full 7-levels topology hierarchy
>    tests/unit/test-smp-parse.c: Test smp_props.has_clusters
>
>   tests/unit/test-smp-parse.c | 515 ++++++++++++++++++++++++++++++++++--
>   1 file changed, 494 insertions(+), 21 deletions(-)
>

Patchew 2.1-devel-b67e4c2

© 2016 - 2024 Red Hat, Inc.