[v2] hw/core: Cleanup and reorder headers

[PATCH v2 0/9] hw/core: Cleanup and reorder headers

Zhao Liu posted 9 patches 10 months, 2 weeks ago

Diff against v1 v3
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20240116074647.3644821-1-zhao1.liu@linux.intel.com

Maintainers: Eduardo Habkost <eduardo@habkost.net>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Yanan Wang <wangyanan55@huawei.com>

There is a newer version of this series

MAINTAINERS                |  3 ++-
hw/core/cpu-common.c       | 17 +++++++----------
hw/core/cpu-sysemu.c       |  3 ++-
hw/core/machine-qmp-cmds.c |  2 +-
hw/core/machine.c          | 21 +++++++++++----------
hw/core/null-machine.c     |  5 +++--
hw/core/numa.c             | 22 ++++++++++------------
7 files changed, 36 insertions(+), 37 deletions(-)

Expand all Fold all

[PATCH v2 0/9] hw/core: Cleanup and reorder headers

Posted by Zhao Liu 10 months, 2 weeks ago

From: Zhao Liu <zhao1.liu@intel.com>

Identify unused headers by full compilation (tested by "./configure" and
then "make") and manually checking if it is a direct inclusion.

Then reorder headers in alphabetical order.

In addition, update a file entry in MAINTAINERS file.

---
Changelog:

v1: Per Peter and Philippe's comments in v1, keep directly included
    headers to avoid implicit header inclusions [1].

[1]: https://lore.kernel.org/qemu-devel/06d4179f-76b8-42f0-b147-f4bc2d1f06bd@linaro.org/#t

---
Zhao Liu (9):
  MAINTAINERS: Update hw/core/cpu.c entry
  hw/core: Cleanup unused included headers in cpu-common.c
  hw/core: Reorder included headers in cpu-common.c
  hw/core: Reorder included headers in cpu-sysemu.c
  hw/core: Cleanup unused included header in machine-qmp-cmds.c
  hw/core: Reorder included header in machine.c
  hw/core: Reorder included headers in null-machine.c
  hw/core: Cleanup unused included headers in numa.c
  hw/core: Reorder included headers in numa.c

 MAINTAINERS                |  3 ++-
 hw/core/cpu-common.c       | 17 +++++++----------
 hw/core/cpu-sysemu.c       |  3 ++-
 hw/core/machine-qmp-cmds.c |  2 +-
 hw/core/machine.c          | 21 +++++++++++----------
 hw/core/null-machine.c     |  5 +++--
 hw/core/numa.c             | 22 ++++++++++------------
 7 files changed, 36 insertions(+), 37 deletions(-)

-- 
2.34.1

Re: [PATCH v2 0/9] hw/core: Cleanup and reorder headers

Posted by Zhao Liu 10 months ago

Hi Philippe,

Thanks for picking the 1st patch. Could you take time for further review
on other patches?

Thanks,
Zhao

On Tue, Jan 16, 2024 at 03:46:38PM +0800, Zhao Liu wrote:
> Date: Tue, 16 Jan 2024 15:46:38 +0800
> From: Zhao Liu <zhao1.liu@linux.intel.com>
> Subject: [PATCH v2 0/9] hw/core: Cleanup and reorder headers
> X-Mailer: git-send-email 2.34.1
> 
> From: Zhao Liu <zhao1.liu@intel.com>
> 
> Identify unused headers by full compilation (tested by "./configure" and
> then "make") and manually checking if it is a direct inclusion.
> 
> Then reorder headers in alphabetical order.
> 
> In addition, update a file entry in MAINTAINERS file.
> 
> ---
> Changelog:
> 
> v1: Per Peter and Philippe's comments in v1, keep directly included
>     headers to avoid implicit header inclusions [1].
> 
> [1]: https://lore.kernel.org/qemu-devel/06d4179f-76b8-42f0-b147-f4bc2d1f06bd@linaro.org/#t
> 
> ---
> Zhao Liu (9):
>   MAINTAINERS: Update hw/core/cpu.c entry
>   hw/core: Cleanup unused included headers in cpu-common.c
>   hw/core: Reorder included headers in cpu-common.c
>   hw/core: Reorder included headers in cpu-sysemu.c
>   hw/core: Cleanup unused included header in machine-qmp-cmds.c
>   hw/core: Reorder included header in machine.c
>   hw/core: Reorder included headers in null-machine.c
>   hw/core: Cleanup unused included headers in numa.c
>   hw/core: Reorder included headers in numa.c
> 
>  MAINTAINERS                |  3 ++-
>  hw/core/cpu-common.c       | 17 +++++++----------
>  hw/core/cpu-sysemu.c       |  3 ++-
>  hw/core/machine-qmp-cmds.c |  2 +-
>  hw/core/machine.c          | 21 +++++++++++----------
>  hw/core/null-machine.c     |  5 +++--
>  hw/core/numa.c             | 22 ++++++++++------------
>  7 files changed, 36 insertions(+), 37 deletions(-)
> 
> -- 
> 2.34.1
> 
>