[v2] qapi: statically type schema.py

[PATCH v2 01/19] qapi: sort pylint suppressions

Posted by John Snow 8 months, 1 week ago

Suggested-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: John Snow <jsnow@redhat.com>
---
 scripts/qapi/pylintrc | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/scripts/qapi/pylintrc b/scripts/qapi/pylintrc
index 90546df5345..78b63af4df6 100644
--- a/scripts/qapi/pylintrc
+++ b/scripts/qapi/pylintrc
@@ -16,14 +16,14 @@ ignore-patterns=schema.py,
 # --enable=similarities". If you want to run only the classes checker, but have
 # no Warning level messages displayed, use "--disable=all --enable=classes
 # --disable=W".
-disable=fixme,
+disable=consider-using-f-string,
         missing-docstring,
         too-many-arguments,
         too-many-branches,
-        too-many-statements,
         too-many-instance-attributes,
-        consider-using-f-string,
+        too-many-statements,
         useless-option-value,
+        fixme,
 
 [REPORTS]
 
-- 
2.43.0

Re: [PATCH v2 01/19] qapi: sort pylint suppressions

Posted by Markus Armbruster 8 months, 1 week ago

John Snow <jsnow@redhat.com> writes:

> Suggested-by: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
>  scripts/qapi/pylintrc | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/scripts/qapi/pylintrc b/scripts/qapi/pylintrc
> index 90546df5345..78b63af4df6 100644
> --- a/scripts/qapi/pylintrc
> +++ b/scripts/qapi/pylintrc
> @@ -16,14 +16,14 @@ ignore-patterns=schema.py,
>  # --enable=similarities". If you want to run only the classes checker, but have
>  # no Warning level messages displayed, use "--disable=all --enable=classes
>  # --disable=W".
> -disable=fixme,
> +disable=consider-using-f-string,
>          missing-docstring,
>          too-many-arguments,
>          too-many-branches,
> -        too-many-statements,
>          too-many-instance-attributes,
> -        consider-using-f-string,
> +        too-many-statements,
>          useless-option-value,
> +        fixme,
>  
>  [REPORTS]

Any particular reason for putting fixme last?

Re: [PATCH v2 01/19] qapi: sort pylint suppressions

Posted by John Snow 8 months, 1 week ago

On Mon, Jan 15, 2024 at 7:18 AM Markus Armbruster <armbru@redhat.com> wrote:
>
> John Snow <jsnow@redhat.com> writes:
>
> > Suggested-by: Markus Armbruster <armbru@redhat.com>
> > Signed-off-by: John Snow <jsnow@redhat.com>
> > ---
> >  scripts/qapi/pylintrc | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/scripts/qapi/pylintrc b/scripts/qapi/pylintrc
> > index 90546df5345..78b63af4df6 100644
> > --- a/scripts/qapi/pylintrc
> > +++ b/scripts/qapi/pylintrc
> > @@ -16,14 +16,14 @@ ignore-patterns=schema.py,
> >  # --enable=similarities". If you want to run only the classes checker, but have
> >  # no Warning level messages displayed, use "--disable=all --enable=classes
> >  # --disable=W".
> > -disable=fixme,
> > +disable=consider-using-f-string,
> >          missing-docstring,
> >          too-many-arguments,
> >          too-many-branches,
> > -        too-many-statements,
> >          too-many-instance-attributes,
> > -        consider-using-f-string,
> > +        too-many-statements,
> >          useless-option-value,
> > +        fixme,
> >
> >  [REPORTS]
>
> Any particular reason for putting fixme last?
>

Uhh. You know, I have no idea? I swore I just used emacs to sort the
lines, but ... lol? You'd think I'd notice that this wasn't in
alphabetical order, but...

*cough* sorry

Re: [PATCH v2 01/19] qapi: sort pylint suppressions

Posted by Markus Armbruster 8 months, 1 week ago

John Snow <jsnow@redhat.com> writes:

> On Mon, Jan 15, 2024 at 7:18 AM Markus Armbruster <armbru@redhat.com> wrote:
>>
>> John Snow <jsnow@redhat.com> writes:
>>
>> > Suggested-by: Markus Armbruster <armbru@redhat.com>
>> > Signed-off-by: John Snow <jsnow@redhat.com>
>> > ---
>> >  scripts/qapi/pylintrc | 6 +++---
>> >  1 file changed, 3 insertions(+), 3 deletions(-)
>> >
>> > diff --git a/scripts/qapi/pylintrc b/scripts/qapi/pylintrc
>> > index 90546df5345..78b63af4df6 100644
>> > --- a/scripts/qapi/pylintrc
>> > +++ b/scripts/qapi/pylintrc
>> > @@ -16,14 +16,14 @@ ignore-patterns=schema.py,
>> >  # --enable=similarities". If you want to run only the classes checker, but have
>> >  # no Warning level messages displayed, use "--disable=all --enable=classes
>> >  # --disable=W".
>> > -disable=fixme,
>> > +disable=consider-using-f-string,
>> >          missing-docstring,
>> >          too-many-arguments,
>> >          too-many-branches,
>> > -        too-many-statements,
>> >          too-many-instance-attributes,
>> > -        consider-using-f-string,
>> > +        too-many-statements,
>> >          useless-option-value,
>> > +        fixme,
>> >
>> >  [REPORTS]
>>
>> Any particular reason for putting fixme last?
>>
>
> Uhh. You know, I have no idea? I swore I just used emacs to sort the
> lines, but ... lol? You'd think I'd notice that this wasn't in
> alphabetical order, but...
>
> *cough* sorry

No worries, happens to the best of us :)