The end of command sequences for the ICCS command are currently different
between the DMA and non-DMA versions, and also different from the description
in the datasheet.
Update the sequence so that only INTR_FC is asserted in both cases, and keep
all the logic in esp_do_dma() and esp_do_nodma() rather than having some of
it within esp_run_cmd().
Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
---
hw/scsi/esp.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/hw/scsi/esp.c b/hw/scsi/esp.c
index 824ebe9ff0..6c62417985 100644
--- a/hw/scsi/esp.c
+++ b/hw/scsi/esp.c
@@ -650,8 +650,7 @@ static void esp_do_dma(ESPState *s)
}
/* Raise end of command interrupt */
- s->rregs[ESP_RINTR] |= INTR_BS | INTR_FC;
- s->rregs[ESP_RSEQ] = SEQ_CD;
+ s->rregs[ESP_RINTR] |= INTR_FC;
esp_raise_irq(s);
}
break;
@@ -825,6 +824,8 @@ static void esp_do_nodma(ESPState *s)
case CMD_ICCS:
fifo8_push(&s->fifo, 0);
+ /* Raise end of command interrupt */
+ s->rregs[ESP_RINTR] |= INTR_FC;
esp_raise_irq(s);
break;
}
@@ -1056,8 +1057,6 @@ static void esp_run_cmd(ESPState *s)
case CMD_ICCS:
trace_esp_mem_writeb_cmd_iccs(cmd);
write_response(s);
- s->rregs[ESP_RINTR] |= INTR_FC;
- esp_set_phase(s, STAT_MI);
break;
case CMD_MSGACC:
trace_esp_mem_writeb_cmd_msgacc(cmd);
--
2.39.2