accel/tcg: Include missing headers to 'tb-jmp-cache.h'

[PATCH] accel/tcg: Include missing headers to 'tb-jmp-cache.h'

Philippe Mathieu-Daudé posted 1 patch 8 months, 1 week ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20240111162442.43755-1-philmd@linaro.org

Maintainers: Richard Henderson <richard.henderson@linaro.org>, Paolo Bonzini <pbonzini@redhat.com>

accel/tcg/tb-jmp-cache.h | 3 +++
1 file changed, 3 insertions(+)

Expand all Fold all

[PATCH] accel/tcg: Include missing headers to 'tb-jmp-cache.h'

Posted by Philippe Mathieu-Daudé 8 months, 1 week ago

Due to missing headers, when including "tb-jmp-cache.h" we might get:

  accel/tcg/tb-jmp-cache.h:21:21: error: field ‘rcu’ has incomplete type
     21 |     struct rcu_head rcu;
        |                     ^~~
  accel/tcg/tb-jmp-cache.h:24:9: error: unknown type name ‘vaddr’
     24 |         vaddr pc;
        |         ^~~~~

Add the missing "qemu/rcu.h" and "exec/cpu-common.h" headers.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 accel/tcg/tb-jmp-cache.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/accel/tcg/tb-jmp-cache.h b/accel/tcg/tb-jmp-cache.h
index bb424c8a05..b13a02e45d 100644
--- a/accel/tcg/tb-jmp-cache.h
+++ b/accel/tcg/tb-jmp-cache.h
@@ -9,6 +9,9 @@
 #ifndef ACCEL_TCG_TB_JMP_CACHE_H
 #define ACCEL_TCG_TB_JMP_CACHE_H
 
+#include "qemu/rcu.h"
+#include "exec/cpu-common.h"
+
 #define TB_JMP_CACHE_BITS 12
 #define TB_JMP_CACHE_SIZE (1 << TB_JMP_CACHE_BITS)
 
-- 
2.41.0

Re: [PATCH] accel/tcg: Include missing headers to 'tb-jmp-cache.h'

Posted by Richard Henderson 8 months, 1 week ago

On 1/12/24 03:24, Philippe Mathieu-Daudé wrote:
> Due to missing headers, when including "tb-jmp-cache.h" we might get:
> 
>    accel/tcg/tb-jmp-cache.h:21:21: error: field ‘rcu’ has incomplete type
>       21 |     struct rcu_head rcu;
>          |                     ^~~
>    accel/tcg/tb-jmp-cache.h:24:9: error: unknown type name ‘vaddr’
>       24 |         vaddr pc;
>          |         ^~~~~
> 
> Add the missing "qemu/rcu.h" and "exec/cpu-common.h" headers.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Acked-by: Richard Henderson <richard.henderson@linaro.org>


r~

> ---
>   accel/tcg/tb-jmp-cache.h | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/accel/tcg/tb-jmp-cache.h b/accel/tcg/tb-jmp-cache.h
> index bb424c8a05..b13a02e45d 100644
> --- a/accel/tcg/tb-jmp-cache.h
> +++ b/accel/tcg/tb-jmp-cache.h
> @@ -9,6 +9,9 @@
>   #ifndef ACCEL_TCG_TB_JMP_CACHE_H
>   #define ACCEL_TCG_TB_JMP_CACHE_H
>   
> +#include "qemu/rcu.h"
> +#include "exec/cpu-common.h"
> +
>   #define TB_JMP_CACHE_BITS 12
>   #define TB_JMP_CACHE_SIZE (1 << TB_JMP_CACHE_BITS)
>