1. Patchew
  2. QEMU
  3. [PATCH 0/2] Deprecate the shix machine and the TC58128 flash device
  4. View patch

[PATCH 1/2] target/sh4: Deprecate the shix machine

Samuel Tardieu posted 2 patches 10 months, 3 weeks ago
Maintainers: Yoshinori Sato <ysato@users.sourceforge.jp>, Magnus Damm <magnus.damm@gmail.com>, Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>
There is a newer version of this series
[PATCH 1/2] target/sh4: Deprecate the shix machine
Posted by Samuel Tardieu 10 months, 3 weeks ago 
The shix machine has been designed and used at Télécom Paris from 2003
to 2010. It had been added to QEMU in 2005 and has not been maintained
since. Since nobody is using the physical board anymore nor interested
in maintaining the QEMU port, it is time to deprecate it.

Signed-off-by: Samuel Tardieu <sam@rfc1149.net>
---
 docs/about/deprecated.rst | 5 +++++
 hw/sh4/shix.c             | 1 +
 2 files changed, 6 insertions(+)

diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst
index 2e15040246..e6a12c9077 100644
--- a/docs/about/deprecated.rst
+++ b/docs/about/deprecated.rst
@@ -269,6 +269,11 @@ Nios II ``10m50-ghrd`` and ``nios2-generic-nommu`` machines (since 8.2)
 
 The Nios II architecture is orphan.
 
+``shix`` (since 9.0)
+''''''''''''''''''''
+
+The machine is no longer in existence and has been long unmaintained
+in QEMU.
 
 Backend options
 ---------------
diff --git a/hw/sh4/shix.c b/hw/sh4/shix.c
index aa812512f0..58530b8ede 100644
--- a/hw/sh4/shix.c
+++ b/hw/sh4/shix.c
@@ -80,6 +80,7 @@ static void shix_machine_init(MachineClass *mc)
     mc->init = shix_init;
     mc->is_default = true;
     mc->default_cpu_type = TYPE_SH7750R_CPU;
+    mc->deprecation_reason = "old and unmaintained - use a newer machine instead";
 }
 
 DEFINE_MACHINE("shix", shix_machine_init)
-- 
2.42.0
Re: [PATCH 1/2] target/sh4: Deprecate the shix machine
Posted by Yoshinori Sato 10 months, 3 weeks ago 
On Tue, 09 Jan 2024 02:15:21 +0900,
Samuel Tardieu wrote:
> 
> The shix machine has been designed and used at Télécom Paris from 2003
> to 2010. It had been added to QEMU in 2005 and has not been maintained
> since. Since nobody is using the physical board anymore nor interested
> in maintaining the QEMU port, it is time to deprecate it.
> 
> Signed-off-by: Samuel Tardieu <sam@rfc1149.net>
> ---
>  docs/about/deprecated.rst | 5 +++++
>  hw/sh4/shix.c             | 1 +
>  2 files changed, 6 insertions(+)
> 
> diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst
> index 2e15040246..e6a12c9077 100644
> --- a/docs/about/deprecated.rst
> +++ b/docs/about/deprecated.rst
> @@ -269,6 +269,11 @@ Nios II ``10m50-ghrd`` and ``nios2-generic-nommu`` machines (since 8.2)
>  
>  The Nios II architecture is orphan.
>  
> +``shix`` (since 9.0)
> +''''''''''''''''''''
> +
> +The machine is no longer in existence and has been long unmaintained
> +in QEMU.
>  
>  Backend options
>  ---------------
> diff --git a/hw/sh4/shix.c b/hw/sh4/shix.c
> index aa812512f0..58530b8ede 100644
> --- a/hw/sh4/shix.c
> +++ b/hw/sh4/shix.c
> @@ -80,6 +80,7 @@ static void shix_machine_init(MachineClass *mc)
>      mc->init = shix_init;
>      mc->is_default = true;
>      mc->default_cpu_type = TYPE_SH7750R_CPU;
> +    mc->deprecation_reason = "old and unmaintained - use a newer machine instead";
>  }
>  
>  DEFINE_MACHINE("shix", shix_machine_init)
> -- 
> 2.42.0
> 

I can't maintain this either.
Reviewed-by: Yoshinori Sato <ysato@users.sourceforge.jp>

-- 
Yosinori Sato
Re: [PATCH 1/2] target/sh4: Deprecate the shix machine
Posted by Philippe Mathieu-Daudé 10 months, 3 weeks ago 
Hi Samuel,

On 8/1/24 18:15, Samuel Tardieu wrote:
> The shix machine has been designed and used at Télécom Paris from 2003
> to 2010. It had been added to QEMU in 2005 and has not been maintained
> since. Since nobody is using the physical board anymore nor interested
> in maintaining the QEMU port, it is time to deprecate it.
> 
> Signed-off-by: Samuel Tardieu <sam@rfc1149.net>
> ---
>   docs/about/deprecated.rst | 5 +++++
>   hw/sh4/shix.c             | 1 +
>   2 files changed, 6 insertions(+)
> 
> diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst
> index 2e15040246..e6a12c9077 100644
> --- a/docs/about/deprecated.rst
> +++ b/docs/about/deprecated.rst
> @@ -269,6 +269,11 @@ Nios II ``10m50-ghrd`` and ``nios2-generic-nommu`` machines (since 8.2)
>   
>   The Nios II architecture is orphan.
>   
> +``shix`` (since 9.0)
> +''''''''''''''''''''
> +
> +The machine is no longer in existence and has been long unmaintained
> +in QEMU.
>   
>   Backend options
>   ---------------
> diff --git a/hw/sh4/shix.c b/hw/sh4/shix.c
> index aa812512f0..58530b8ede 100644
> --- a/hw/sh4/shix.c
> +++ b/hw/sh4/shix.c
> @@ -80,6 +80,7 @@ static void shix_machine_init(MachineClass *mc)
>       mc->init = shix_init;
>       mc->is_default = true;
>       mc->default_cpu_type = TYPE_SH7750R_CPU;
> +    mc->deprecation_reason = "old and unmaintained - use a newer machine instead";

"use a newer machine instead" bugs me, what would that be?

Could we stick to "old and unmaintained"?

>   }
>   
>   DEFINE_MACHINE("shix", shix_machine_init)
Re: [PATCH 1/2] target/sh4: Deprecate the shix machine
Posted by Samuel Tardieu 10 months, 3 weeks ago 
Philippe Mathieu-Daudé <philmd@linaro.org> writes:

>>       mc->default_cpu_type = TYPE_SH7750R_CPU;
>> +    mc->deprecation_reason = "old and unmaintained - use a 
>> newer machine instead";
>
> "use a newer machine instead" bugs me, what would that be?
>
> Could we stick to "old and unmaintained"?

You're right. I removed the extra part in both the shix and the 
tc58128 deprecation messages.

  Sam
-- 
Samuel Tardieu
Re: [PATCH 1/2] target/sh4: Deprecate the shix machine
Posted by Cédric Le Goater 10 months, 3 weeks ago 
On 1/8/24 18:15, Samuel Tardieu wrote:
> The shix machine has been designed and used at Télécom Paris from 2003
> to 2010. It had been added to QEMU in 2005 and has not been maintained
> since. Since nobody is using the physical board anymore nor interested
> in maintaining the QEMU port, it is time to deprecate it.
> 
> Signed-off-by: Samuel Tardieu <sam@rfc1149.net>


Reviewed-by: Cédric Le Goater <clg@redhat.com>

Thanks,

C.



> ---
>   docs/about/deprecated.rst | 5 +++++
>   hw/sh4/shix.c             | 1 +
>   2 files changed, 6 insertions(+)
> 
> diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst
> index 2e15040246..e6a12c9077 100644
> --- a/docs/about/deprecated.rst
> +++ b/docs/about/deprecated.rst
> @@ -269,6 +269,11 @@ Nios II ``10m50-ghrd`` and ``nios2-generic-nommu`` machines (since 8.2)
>   
>   The Nios II architecture is orphan.
>   
> +``shix`` (since 9.0)
> +''''''''''''''''''''
> +
> +The machine is no longer in existence and has been long unmaintained
> +in QEMU.
>   
>   Backend options
>   ---------------
> diff --git a/hw/sh4/shix.c b/hw/sh4/shix.c
> index aa812512f0..58530b8ede 100644
> --- a/hw/sh4/shix.c
> +++ b/hw/sh4/shix.c
> @@ -80,6 +80,7 @@ static void shix_machine_init(MachineClass *mc)
>       mc->init = shix_init;
>       mc->is_default = true;
>       mc->default_cpu_type = TYPE_SH7750R_CPU;
> +    mc->deprecation_reason = "old and unmaintained - use a newer machine instead";
>   }
>   
>   DEFINE_MACHINE("shix", shix_machine_init)

Patchew 2.1-devel-b67e4c2

© 2016 - 2024 Red Hat, Inc.