[PULL 00/13] replay fixes for replay_kernel

Alex Bennée posted 13 patches 10 months, 3 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20240108151352.2199097-1-alex.bennee@linaro.org
Maintainers: Richard Henderson <richard.henderson@linaro.org>, Paolo Bonzini <pbonzini@redhat.com>, "Marc-André Lureau" <marcandre.lureau@redhat.com>, Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>, John Snow <jsnow@redhat.com>, Cleber Rosa <crosa@redhat.com>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Wainer dos Santos Moschetta <wainersm@redhat.com>, Beraldo Leal <bleal@redhat.com>
include/sysemu/replay.h        |   5 ++
replay/replay-internal.h       |  50 +++++++++++-----
accel/tcg/tcg-accel-ops-rr.c   |   2 +-
chardev/char.c                 |  12 ++++
replay/replay-char.c           |   6 +-
replay/replay-internal.c       |   5 +-
replay/replay-snapshot.c       |   7 ++-
replay/replay.c                | 132 +++++++++++++++++++++++++++++++++++++++++
scripts/replay-dump.py         |  95 ++++++++++++++++++++++++++---
tests/avocado/replay_kernel.py |  27 +++++----
tests/avocado/replay_linux.py  |   9 ++-
11 files changed, 303 insertions(+), 47 deletions(-)
[PULL 00/13] replay fixes for replay_kernel
Posted by Alex Bennée 10 months, 3 weeks ago
The following changes since commit 0c1eccd368af8805ec0fb11e6cf25d0684d37328:

  Merge tag 'hw-cpus-20240105' of https://github.com/philmd/qemu into staging (2024-01-05 16:08:58 +0000)

are available in the Git repository at:

  https://gitlab.com/stsquad/qemu.git tags/pull-replay-fixes-080124-1

for you to fetch changes up to c2ef5ee89d76f0ab77c4dd6a1c9eeed4d35d20ed:

  tests/avocado: remove skips from replay_kernel (2024-01-08 13:59:06 +0000)

----------------------------------------------------------------
Record/replay fixes for replay_kernel tests

  - add a 32 bit x86 replay test case
  - fix some typos
  - use modern snapshot setting for tests
  - update replay_dump for current ABI
  - remove stale replay variables
  - improve kdoc for ReplayState
  - introduce common error path for replay
  - always fully drain chardevs when in replay
  - catch unexpected waitio on playback
  - remove flaky tags from replay_kernel tests

----------------------------------------------------------------
Alex Bennée (13):
      tests/avocado: add a simple i386 replay kernel test
      tests/avocado: fix typo in replay_linux
      tests/avocado: modernise the drive args for replay_linux
      scripts/replay-dump: update to latest format
      scripts/replay_dump: track total number of instructions
      replay: remove host_clock_last
      replay: add proper kdoc for ReplayState
      replay: make has_unread_data a bool
      replay: introduce a central report point for sync errors
      replay/replay-char: use report_sync_error
      replay: stop us hanging in rr_wait_io_event
      chardev: force write all when recording replay logs
      tests/avocado: remove skips from replay_kernel

 include/sysemu/replay.h        |   5 ++
 replay/replay-internal.h       |  50 +++++++++++-----
 accel/tcg/tcg-accel-ops-rr.c   |   2 +-
 chardev/char.c                 |  12 ++++
 replay/replay-char.c           |   6 +-
 replay/replay-internal.c       |   5 +-
 replay/replay-snapshot.c       |   7 ++-
 replay/replay.c                | 132 +++++++++++++++++++++++++++++++++++++++++
 scripts/replay-dump.py         |  95 ++++++++++++++++++++++++++---
 tests/avocado/replay_kernel.py |  27 +++++----
 tests/avocado/replay_linux.py  |   9 ++-
 11 files changed, 303 insertions(+), 47 deletions(-)

-- 
2.39.2


Re: [PULL 00/13] replay fixes for replay_kernel
Posted by Peter Maydell 10 months, 3 weeks ago
On Mon, 8 Jan 2024 at 15:14, Alex Bennée <alex.bennee@linaro.org> wrote:
>
> The following changes since commit 0c1eccd368af8805ec0fb11e6cf25d0684d37328:
>
>   Merge tag 'hw-cpus-20240105' of https://github.com/philmd/qemu into staging (2024-01-05 16:08:58 +0000)
>
> are available in the Git repository at:
>
>   https://gitlab.com/stsquad/qemu.git tags/pull-replay-fixes-080124-1
>
> for you to fetch changes up to c2ef5ee89d76f0ab77c4dd6a1c9eeed4d35d20ed:
>
>   tests/avocado: remove skips from replay_kernel (2024-01-08 13:59:06 +0000)
>
> ----------------------------------------------------------------
> Record/replay fixes for replay_kernel tests
>
>   - add a 32 bit x86 replay test case
>   - fix some typos
>   - use modern snapshot setting for tests
>   - update replay_dump for current ABI
>   - remove stale replay variables
>   - improve kdoc for ReplayState
>   - introduce common error path for replay
>   - always fully drain chardevs when in replay
>   - catch unexpected waitio on playback
>   - remove flaky tags from replay_kernel tests



Applied to target-arm.next, thanks.

-- PMM
Re: [PULL 00/13] replay fixes for replay_kernel
Posted by Peter Maydell 10 months, 3 weeks ago
On Tue, 9 Jan 2024 at 14:23, Peter Maydell <peter.maydell@linaro.org> wrote:
>
> On Mon, 8 Jan 2024 at 15:14, Alex Bennée <alex.bennee@linaro.org> wrote:
> >
> > The following changes since commit 0c1eccd368af8805ec0fb11e6cf25d0684d37328:
> >
> >   Merge tag 'hw-cpus-20240105' of https://github.com/philmd/qemu into staging (2024-01-05 16:08:58 +0000)
> >
> > are available in the Git repository at:
> >
> >   https://gitlab.com/stsquad/qemu.git tags/pull-replay-fixes-080124-1
> >
> > for you to fetch changes up to c2ef5ee89d76f0ab77c4dd6a1c9eeed4d35d20ed:
> >
> >   tests/avocado: remove skips from replay_kernel (2024-01-08 13:59:06 +0000)
> >
> > ----------------------------------------------------------------
> > Record/replay fixes for replay_kernel tests
> >
> >   - add a 32 bit x86 replay test case
> >   - fix some typos
> >   - use modern snapshot setting for tests
> >   - update replay_dump for current ABI
> >   - remove stale replay variables
> >   - improve kdoc for ReplayState
> >   - introduce common error path for replay
> >   - always fully drain chardevs when in replay
> >   - catch unexpected waitio on playback
> >   - remove flaky tags from replay_kernel tests
>
>
>
> Applied to target-arm.next, thanks.

Whoops, wrong canned response. I meant:


Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/9.0
for any user-visible changes.

-- PMM