chardev/char.c: fix "abstract device type" error message

[PATCH trivial] chardev/char.c: fix "abstract device type" error message

Michael Tokarev posted 1 patch 10 months, 4 weeks ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20240103114221.325221-1-mjt@tls.msk.ru

Maintainers: "Marc-André Lureau" <marcandre.lureau@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Michael Tokarev <mjt@tls.msk.ru>, Laurent Vivier <laurent@vivier.eu>

chardev/char.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH trivial] chardev/char.c: fix "abstract device type" error message

Posted by Michael Tokarev 10 months, 4 weeks ago

Current error message:

 qemu-system-x86_64: -chardev spice,id=foo: Parameter 'driver' expects an abstract device type

while in fact the meaning is in reverse, -chardev expects
a non-abstract device type.

Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
Fixes: 777357d758d9 "chardev: qom-ify" (2016-12-07)
---
 chardev/char.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/chardev/char.c b/chardev/char.c
index 996a024c7a..119b548784 100644
--- a/chardev/char.c
+++ b/chardev/char.c
@@ -518,7 +518,7 @@ static const ChardevClass *char_get_class(const char *driver, Error **errp)
 
     if (object_class_is_abstract(oc)) {
         error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "driver",
-                   "an abstract device type");
+                   "a non-abstract device type");
         return NULL;
     }
 
-- 
2.39.2

Re: [PATCH trivial] chardev/char.c: fix "abstract device type" error message

Posted by Zhao Liu 10 months, 4 weeks ago

On Wed, Jan 03, 2024 at 02:42:21PM +0300, Michael Tokarev wrote:
> Date: Wed,  3 Jan 2024 14:42:21 +0300
> From: Michael Tokarev <mjt@tls.msk.ru>
> Subject: [PATCH trivial] chardev/char.c: fix "abstract device type" error
>  message
> X-Mailer: git-send-email 2.39.2
> 
> Current error message:
> 
>  qemu-system-x86_64: -chardev spice,id=foo: Parameter 'driver' expects an abstract device type
> 
> while in fact the meaning is in reverse, -chardev expects
> a non-abstract device type.
> 
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> Fixes: 777357d758d9 "chardev: qom-ify" (2016-12-07)
> ---

Reviewed-by: Zhao Liu <zhao1.liu@intel.com>

>  chardev/char.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/chardev/char.c b/chardev/char.c
> index 996a024c7a..119b548784 100644
> --- a/chardev/char.c
> +++ b/chardev/char.c
> @@ -518,7 +518,7 @@ static const ChardevClass *char_get_class(const char *driver, Error **errp)
>  
>      if (object_class_is_abstract(oc)) {
>          error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "driver",
> -                   "an abstract device type");
> +                   "a non-abstract device type");
>          return NULL;
>      }
>  
> -- 
> 2.39.2
> 
>