[v4] parallels: Add full dirty bitmap support

[PATCH v4 14/21] parallels: Make a loaded dirty bitmap persistent

Posted by Alexander Ivanov 2 years, 1 month ago

After bitmap loading the bitmap is not persistent and is removed on image
saving. Set bitmap persistence to true.

Signed-off-by: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
---
 block/parallels-ext.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/block/parallels-ext.c b/block/parallels-ext.c
index 033ca3ec3a..2a7ff6e35b 100644
--- a/block/parallels-ext.c
+++ b/block/parallels-ext.c
@@ -255,6 +255,7 @@ parallels_parse_format_extension(BlockDriverState *bs, uint8_t *ext_cluster,
             if (!bitmap) {
                 goto fail;
             }
+            bdrv_dirty_bitmap_set_persistence(bitmap, true);
             bitmaps = g_slist_append(bitmaps, bitmap);
             break;
 
-- 
2.40.1

Re: [PATCH v4 14/21] parallels: Make a loaded dirty bitmap persistent

Posted by Denis V. Lunev 2 years ago

On 12/28/23 11:12, Alexander Ivanov wrote:
> After bitmap loading the bitmap is not persistent and is removed on image
> saving. Set bitmap persistence to true.
>
> Signed-off-by: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
> ---
>   block/parallels-ext.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/block/parallels-ext.c b/block/parallels-ext.c
> index 033ca3ec3a..2a7ff6e35b 100644
> --- a/block/parallels-ext.c
> +++ b/block/parallels-ext.c
> @@ -255,6 +255,7 @@ parallels_parse_format_extension(BlockDriverState *bs, uint8_t *ext_cluster,
>               if (!bitmap) {
>                   goto fail;
>               }
> +            bdrv_dirty_bitmap_set_persistence(bitmap, true);
>               bitmaps = g_slist_append(bitmaps, bitmap);
>               break;
>   
Reviewed-by: Denis V. Lunev <den@openvz.org>