On 12/28/23 11:12, Alexander Ivanov wrote:
> Parallels format driver:
> * make some preparation
> * add dirty bitmap saving
> * make dirty bitmap RW
> * fix broken checks
> * refactor leak check
> * add parallels format support to several tests
>
> You could find these patches in my repo:
> https://github.com/AlexanderIvanov-Virtuozzo/qemu/tree/parallels-v4
>
> v4:
> 4: A new patch with limitation of search in parallels_mark_used.
> 5: Previously 4. Search is limited to (cluster_index + count).
> 6: Previously 5. Added GRAPH_RDLOCK annotation, added a note in the commit
> message.
> 11: Previously 10. Added GRAPH_RDLOCK annotation.
> 16-18: Added GRAPH_RDLOCK annotations.
>
> v3:
> 1: Fixed the order of g_free() and s->used_bmap = NULL.
> 3,4: Made mark_used() a global function before mark_unused() addition. In
> this way we can avoid compilation warnings.
> 5-9: Patches shifted.
> 11: Added GRAPH_RDLOCK annotation to parallels_inactivate(). Guard
> parallels_close() with GRAPH_RDLOCK_GUARD_MAINLOOP().
> 12-21: Patches shifted.
>
> v2:
> 1: New patch to fix double free error.
> 4: Fixed clusters leaks.
> 15: Fixed (end_off != s->used_bmap_size) handling in parallels_truncate_unused_clusters().
> 16,17: Changed the sequence of the patches - in this way we have correct leaks check.
>
> Alexander Ivanov (21):
> parallels: Set s->used_bmap to NULL in parallels_free_used_bitmap()
> parallels: Move inactivation code to a separate function
> parallels: Make mark_used() a global function
> parallels: Limit search in parallels_mark_used to the last marked
> claster
> parallels: Add parallels_mark_unused() helper
> parallels: Move host clusters allocation to a separate function
> parallels: Set data_end value in parallels_check_leak()
> parallels: Recreate used bitmap in parallels_check_leak()
> parallels: Add a note about used bitmap in parallels_check_duplicate()
> parallels: Create used bitmap even if checks needed
> parallels: Add dirty bitmaps saving
> parallels: Let image extensions work in RW mode
> parallels: Handle L1 entries equal to one
> parallels: Make a loaded dirty bitmap persistent
> parallels: Reverse a conditional in parallels_check_leak() to reduce
> indents
> parallels: Truncate images on the last used cluster
> parallels: Check unused clusters in parallels_check_leak()
> parallels: Remove unnecessary data_end field
> tests: Add parallels images support to test 165
> tests: Turned on 256, 299, 304 and block-status-cache for parallels
> format
> tests: Add parallels format support to image-fleecing
>
> block/parallels-ext.c | 183 +++++++++-
> block/parallels.c | 371 ++++++++++++--------
> block/parallels.h | 14 +-
> tests/qemu-iotests/165 | 40 ++-
> tests/qemu-iotests/256 | 2 +-
> tests/qemu-iotests/299 | 2 +-
> tests/qemu-iotests/304 | 2 +-
> tests/qemu-iotests/tests/block-status-cache | 2 +-
> tests/qemu-iotests/tests/image-fleecing | 13 +-
> 9 files changed, 453 insertions(+), 176 deletions(-)
>
I would also say that if we add parallels extension in
read-write mode, we should also add appropriates clauses
into parallels_check.
Den