include/ui/rect.h: fix qemu_rect_init() mis-assignment

[PATCH] include/ui/rect.h: fix qemu_rect_init() mis-assignment

Posted by Michael Tokarev 11 months, 1 week ago

From: Elen Avan <elen.avan@bk.ru>
Signed-off-by: Elen Avan <elen.avan@bk.ru>
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2051
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2050
Fixes: a200d53b1fde "virtio-gpu: replace PIXMAN for region/rect test"
Cc: qemu-stable@nongnu.org
Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>
---
 include/ui/rect.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(Re-sending this as a more accurate patch which actually can be applied)
Stefan: please apply it directly as an obvious bugfix

diff --git a/include/ui/rect.h b/include/ui/rect.h
index 94898f92d0..68f05d78a8 100644
--- a/include/ui/rect.h
+++ b/include/ui/rect.h
@@ -19,7 +19,7 @@ static inline void qemu_rect_init(QemuRect *rect,
                                   uint16_t width, uint16_t height)
 {
     rect->x = x;
-    rect->y = x;
+    rect->y = y;
     rect->width = width;
     rect->height = height;
 }
-- 
2.39.2

Re: [PATCH] include/ui/rect.h: fix qemu_rect_init() mis-assignment

Posted by Philippe Mathieu-Daudé 11 months ago

On 22/12/23 20:17, Michael Tokarev wrote:
> From: Elen Avan <elen.avan@bk.ru>
> Signed-off-by: Elen Avan <elen.avan@bk.ru>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2051
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2050
> Fixes: a200d53b1fde "virtio-gpu: replace PIXMAN for region/rect test"
> Cc: qemu-stable@nongnu.org
> Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
>   include/ui/rect.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Re: [PATCH] include/ui/rect.h: fix qemu_rect_init() mis-assignment

Posted by Marc-André Lureau 11 months, 1 week ago

On Fri, Dec 22, 2023 at 11:18 PM Michael Tokarev <mjt@tls.msk.ru> wrote:
>
> From: Elen Avan <elen.avan@bk.ru>
> Signed-off-by: Elen Avan <elen.avan@bk.ru>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2051
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2050
> Fixes: a200d53b1fde "virtio-gpu: replace PIXMAN for region/rect test"
> Cc: qemu-stable@nongnu.org
> Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>

brown paper bag face...
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>

thanks

> ---
>  include/ui/rect.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> (Re-sending this as a more accurate patch which actually can be applied)
> Stefan: please apply it directly as an obvious bugfix
>
> diff --git a/include/ui/rect.h b/include/ui/rect.h
> index 94898f92d0..68f05d78a8 100644
> --- a/include/ui/rect.h
> +++ b/include/ui/rect.h
> @@ -19,7 +19,7 @@ static inline void qemu_rect_init(QemuRect *rect,
>                                    uint16_t width, uint16_t height)
>  {
>      rect->x = x;
> -    rect->y = x;
> +    rect->y = y;
>      rect->width = width;
>      rect->height = height;
>  }
> --
> 2.39.2
>
>


-- 
Marc-André Lureau