[v2] meson: Fixes for dbus modules

[PATCH v2 0/4] meson: Fixes for dbus modules

Akihiko Odaki posted 4 patches 1 year, 11 months ago

Diff against v1 v3 v4 v5 v7
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20231215-dbus-v2-0-1e2e6aa02115@daynix.com

Maintainers: "Marc-André Lureau" <marcandre.lureau@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, "Daniel P. Berrangé" <berrange@redhat.com>, Thomas Huth <thuth@redhat.com>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Laurent Vivier <lvivier@redhat.com>

There is a newer version of this series

MAINTAINERS                               |  1 +
meson.build                               | 21 +++++++++++++++++++++
ui/dbus.h                                 |  2 +-
audio/dbusaudio.c                         |  2 +-
tests/qtest/dbus-display-test.c           |  2 +-
audio/meson.build                         |  3 ++-
ui/dbus-display1.xml => dbus-display1.xml |  0
tests/qtest/meson.build                   |  2 +-
ui/meson.build                            | 18 ------------------
9 files changed, 28 insertions(+), 23 deletions(-)

Expand all Fold all

[PATCH v2 0/4] meson: Fixes for dbus modules

Posted by Akihiko Odaki 1 year, 11 months ago

I found it was failing to build dbus modules when --enable-dbus so here
are fixes.

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
---
Changes in v2:
- Updated MAINTAINERS.
- Link to v1: https://lore.kernel.org/r/20231215-dbus-v1-0-349e059ac5b2@daynix.com

---
Akihiko Odaki (4):
      Move dbus-display1 out of ui
      audio: Depend on dbus_display1_dep
      meson: Explicitly specify dbus-display1.h dependency
      tests/qtest: Depend on dbus_display1_dep

 MAINTAINERS                               |  1 +
 meson.build                               | 21 +++++++++++++++++++++
 ui/dbus.h                                 |  2 +-
 audio/dbusaudio.c                         |  2 +-
 tests/qtest/dbus-display-test.c           |  2 +-
 audio/meson.build                         |  3 ++-
 ui/dbus-display1.xml => dbus-display1.xml |  0
 tests/qtest/meson.build                   |  2 +-
 ui/meson.build                            | 18 ------------------
 9 files changed, 28 insertions(+), 23 deletions(-)
---
base-commit: 4705fc0c8511d073bee4751c3c974aab2b10a970
change-id: 20231215-dbus-86876ecb7b09

Best regards,
-- 
Akihiko Odaki <akihiko.odaki@daynix.com>

Re: [PATCH v2 0/4] meson: Fixes for dbus modules

Posted by Marc-André Lureau 1 year, 9 months ago

Hi Akihiko

On Fri, Dec 15, 2023 at 3:29 PM Akihiko Odaki <akihiko.odaki@daynix.com> wrote:
>
> I found it was failing to build dbus modules when --enable-dbus so here
> are fixes.
>
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> ---
> Changes in v2:
> - Updated MAINTAINERS.
> - Link to v1: https://lore.kernel.org/r/20231215-dbus-v1-0-349e059ac5b2@daynix.com
>
> ---
> Akihiko Odaki (4):
>       Move dbus-display1 out of ui
>       audio: Depend on dbus_display1_dep
>       meson: Explicitly specify dbus-display1.h dependency
>       tests/qtest: Depend on dbus_display1_dep

Can you send a v4 which doesn't move the dbus-display.xml out of
display/ but has the rest of the dependency fixes and r-b?

thanks

>
>  MAINTAINERS                               |  1 +
>  meson.build                               | 21 +++++++++++++++++++++
>  ui/dbus.h                                 |  2 +-
>  audio/dbusaudio.c                         |  2 +-
>  tests/qtest/dbus-display-test.c           |  2 +-
>  audio/meson.build                         |  3 ++-
>  ui/dbus-display1.xml => dbus-display1.xml |  0
>  tests/qtest/meson.build                   |  2 +-
>  ui/meson.build                            | 18 ------------------
>  9 files changed, 28 insertions(+), 23 deletions(-)
> ---
> base-commit: 4705fc0c8511d073bee4751c3c974aab2b10a970
> change-id: 20231215-dbus-86876ecb7b09
>
> Best regards,
> --
> Akihiko Odaki <akihiko.odaki@daynix.com>
>
>


-- 
Marc-André Lureau