1. Patchew
  2. QEMU
  3. [PATCH 0/4] hw: Remove 'exec/exec-all.h' header when unused
  4. View patch

[PATCH 2/4] hw/misc/mips_itu: Remove unnecessary 'exec/exec-all.h' header

Philippe Mathieu-Daudé posted 4 patches 1 year, 11 months ago
Maintainers: "Philippe Mathieu-Daudé" <philmd@linaro.org>, Nicholas Piggin <npiggin@gmail.com>, Daniel Henrique Barboza <danielhb413@gmail.com>, "Cédric Le Goater" <clg@kaod.org>, David Gibson <david@gibson.dropbear.id.au>, Harsh Prateek Bora <harshpb@linux.ibm.com>, Christian Borntraeger <borntraeger@linux.ibm.com>, Thomas Huth <thuth@redhat.com>, Halil Pasic <pasic@linux.ibm.com>, Eric Farman <farman@linux.ibm.com>, Richard Henderson <richard.henderson@linaro.org>, David Hildenbrand <david@redhat.com>, Ilya Leoshkevich <iii@linux.ibm.com>, Paolo Bonzini <pbonzini@redhat.com>, Song Gao <gaosong@loongson.cn>
[PATCH 2/4] hw/misc/mips_itu: Remove unnecessary 'exec/exec-all.h' header
Posted by Philippe Mathieu-Daudé 1 year, 11 months ago 
mips_itu.c only requires declarations from "hw/core/cpu.h"
and "cpu.h". Avoid including the huge "exec/exec-all.h" header.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 hw/misc/mips_itu.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/hw/misc/mips_itu.c b/hw/misc/mips_itu.c
index 5a83ccc4e8..37aea0e737 100644
--- a/hw/misc/mips_itu.c
+++ b/hw/misc/mips_itu.c
@@ -22,9 +22,10 @@
 #include "qemu/log.h"
 #include "qemu/module.h"
 #include "qapi/error.h"
-#include "exec/exec-all.h"
+#include "hw/core/cpu.h"
 #include "hw/misc/mips_itu.h"
 #include "hw/qdev-properties.h"
+#include "target/mips/cpu.h"
 
 #define ITC_TAG_ADDRSPACE_SZ (ITC_ADDRESSMAP_NUM * 8)
 /* Initialize as 4kB area to fit all 32 cells with default 128B grain.
-- 
2.41.0
Re: [PATCH 2/4] hw/misc/mips_itu: Remove unnecessary 'exec/exec-all.h' header
Posted by Thomas Huth 1 year, 11 months ago 
On 12/12/2023 12.36, Philippe Mathieu-Daudé wrote:
> mips_itu.c only requires declarations from "hw/core/cpu.h"
> and "cpu.h". Avoid including the huge "exec/exec-all.h" header.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   hw/misc/mips_itu.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/hw/misc/mips_itu.c b/hw/misc/mips_itu.c
> index 5a83ccc4e8..37aea0e737 100644
> --- a/hw/misc/mips_itu.c
> +++ b/hw/misc/mips_itu.c
> @@ -22,9 +22,10 @@
>   #include "qemu/log.h"
>   #include "qemu/module.h"
>   #include "qapi/error.h"
> -#include "exec/exec-all.h"
> +#include "hw/core/cpu.h"
>   #include "hw/misc/mips_itu.h"
>   #include "hw/qdev-properties.h"
> +#include "target/mips/cpu.h"
>   
>   #define ITC_TAG_ADDRSPACE_SZ (ITC_ADDRESSMAP_NUM * 8)
>   /* Initialize as 4kB area to fit all 32 cells with default 128B grain.

Reviewed-by: Thomas Huth <thuth@redhat.com>

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.