[PATCH 00/24] exec: Rework of various headers (user focused)

Philippe Mathieu-Daudé posted 24 patches 1 year, 11 months ago
Failed in applying to current master (apply log)
Maintainers: Richard Henderson <richard.henderson@linaro.org>, Paolo Bonzini <pbonzini@redhat.com>, Riku Voipio <riku.voipio@iki.fi>, Warner Losh <imp@bsdimp.com>, Kyle Evans <kevans@freebsd.org>, "Alex Bennée" <alex.bennee@linaro.org>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, BALATON Zoltan <balaton@eik.bme.hu>, Nicholas Piggin <npiggin@gmail.com>, Daniel Henrique Barboza <danielhb413@gmail.com>, "Cédric Le Goater" <clg@kaod.org>, David Gibson <david@gibson.dropbear.id.au>, Harsh Prateek Bora <harshpb@linux.ibm.com>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, Christian Borntraeger <borntraeger@linux.ibm.com>, Thomas Huth <thuth@redhat.com>, Halil Pasic <pasic@linux.ibm.com>, Eric Farman <farman@linux.ibm.com>, David Hildenbrand <david@redhat.com>, Ilya Leoshkevich <iii@linux.ibm.com>, Peter Xu <peterx@redhat.com>, Laurent Vivier <laurent@vivier.eu>, "Marc-André Lureau" <marcandre.lureau@redhat.com>, "Daniel P. Berrangé" <berrange@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, Michael Rolnik <mrolnik@gmail.com>, Brian Cain <bcain@quicinc.com>, Eduardo Habkost <eduardo@habkost.net>, Song Gao <gaosong@loongson.cn>, Aurelien Jarno <aurelien@aurel32.net>, Jiaxun Yang <jiaxun.yang@flygoat.com>, Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>, Huacai Chen <chenhuacai@kernel.org>, Chris Wulff <crwulff@gmail.com>, Marek Vasut <marex@denx.de>, Stafford Horne <shorne@gmail.com>, Palmer Dabbelt <palmer@dabbelt.com>, Alistair Francis <alistair.francis@wdc.com>, Bin Meng <bin.meng@windriver.com>, Weiwei Li <liwei1518@gmail.com>, Liu Zhiwei <zhiwei_liu@linux.alibaba.com>, Yoshinori Sato <ysato@users.sourceforge.jp>, Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>, Artyom Tarasenko <atar4qemu@gmail.com>, Bastian Koppelmann <kbastian@mail.uni-paderborn.de>, Max Filippov <jcmvbkbc@gmail.com>
There is a newer version of this series
meson.build                                   |  2 +-
accel/tcg/user-retaddr.h                      | 28 ++++++++++
bsd-user/bsd-mem.h                            |  1 +
bsd-user/qemu.h                               |  1 +
host/include/generic/host/atomic128-cas.h     |  2 +
host/include/generic/host/atomic128-ldst.h    |  2 +
.../generic/host/load-extract-al16-al8.h      |  3 ++
include/exec/cpu-all.h                        | 50 +++---------------
include/exec/cpu_ldst.h                       | 51 ++++---------------
include/exec/exec-all.h                       |  1 +
include/exec/page-prot-common.h               | 38 ++++++++++++++
include/exec/ram_addr.h                       |  1 +
include/exec/translator.h                     |  5 +-
include/exec/user/abitypes.h                  |  9 +++-
include/exec/user/guest-base.h                |  6 +++
include/semihosting/uaccess.h                 |  3 +-
include/tcg/abi_ptr.h                         | 32 ++++++++++++
target/alpha/cpu-param.h                      |  3 ++
target/alpha/cpu.h                            |  3 --
target/arm/cpu-param.h                        |  8 +--
target/arm/cpu.h                              |  4 +-
target/avr/cpu-param.h                        |  2 +
target/avr/cpu.h                              |  2 -
target/hppa/cpu-param.h                       |  6 +++
target/hppa/cpu.h                             |  6 ---
target/i386/cpu-param.h                       |  3 ++
target/i386/cpu.h                             |  3 --
target/loongarch/cpu-param.h                  |  2 +
target/loongarch/cpu.h                        |  2 -
target/microblaze/cpu-param.h                 |  3 ++
target/microblaze/cpu.h                       |  3 --
target/mips/cpu-param.h                       |  2 +
target/mips/cpu.h                             |  2 -
target/openrisc/cpu-param.h                   |  2 +
target/openrisc/cpu.h                         |  2 -
target/ppc/cpu-param.h                        |  2 +
target/ppc/cpu.h                              |  2 -
target/ppc/internal.h                         |  1 +
target/ppc/mmu-radix64.h                      |  2 +
target/riscv/cpu-param.h                      |  2 +
target/riscv/cpu.h                            |  2 -
target/s390x/cpu-param.h                      |  6 +++
target/s390x/cpu.h                            |  3 --
target/sparc/cpu-param.h                      | 23 +++++++++
target/sparc/cpu.h                            | 23 ---------
target/xtensa/cpu-param.h                     |  3 ++
target/xtensa/cpu.h                           |  3 --
accel/tcg/cpu-exec.c                          |  3 ++
accel/tcg/cputlb.c                            |  2 +
accel/tcg/tb-maint.c                          |  1 +
accel/tcg/tcg-accel-ops.c                     |  2 +
accel/tcg/translator.c                        |  1 +
accel/tcg/user-exec.c                         |  2 +
bsd-user/main.c                               |  1 +
bsd-user/mmap.c                               |  1 +
bsd-user/signal.c                             |  1 +
cpu-target.c                                  |  1 +
gdbstub/gdbstub.c                             |  1 +
hw/misc/mips_itu.c                            |  3 +-
hw/ppc/ppc440_bamboo.c                        |  1 +
hw/ppc/sam460ex.c                             |  1 +
hw/ppc/spapr_hcall.c                          |  1 -
hw/ppc/virtex_ml507.c                         |  1 +
hw/s390x/ipl.c                                |  1 -
linux-user/arm/cpu_loop.c                     |  1 +
linux-user/elfload.c                          |  2 +
linux-user/main.c                             |  1 +
linux-user/mmap.c                             |  1 +
linux-user/nios2/cpu_loop.c                   |  1 +
linux-user/signal.c                           |  1 +
linux-user/syscall.c                          |  1 +
page-target.c                                 | 43 ++++++++++++++++
semihosting/guestfd.c                         |  1 -
system/physmem.c                              | 36 +------------
target/alpha/helper.c                         |  1 +
target/arm/ptw.c                              |  1 +
target/arm/tcg/m_helper.c                     |  1 +
target/arm/tcg/mte_helper.c                   |  1 +
target/arm/tcg/sve_helper.c                   |  1 +
target/avr/helper.c                           |  1 +
target/cris/mmu.c                             |  1 +
target/hexagon/translate.c                    |  1 +
target/hppa/mem_helper.c                      |  1 +
target/hppa/translate.c                       |  1 +
target/i386/cpu.c                             |  2 +-
target/i386/tcg/fpu_helper.c                  |  1 +
target/i386/tcg/sysemu/excp_helper.c          |  1 +
target/loongarch/cpu.c                        |  2 +
target/loongarch/tlb_helper.c                 |  1 +
target/m68k/helper.c                          |  1 +
target/microblaze/cpu.c                       |  1 +
target/microblaze/helper.c                    |  1 +
target/microblaze/mmu.c                       |  1 +
target/microblaze/translate.c                 |  1 +
target/mips/sysemu/physaddr.c                 |  1 +
target/mips/tcg/sysemu/tlb_helper.c           |  1 +
target/nios2/helper.c                         |  1 +
target/nios2/mmu.c                            |  1 +
target/nios2/translate.c                      |  1 +
target/openrisc/mmu.c                         |  1 +
target/ppc/excp_helper.c                      |  2 +-
target/ppc/mmu-hash32.c                       |  1 +
target/ppc/mmu-hash64.c                       |  1 +
target/ppc/mmu-radix64.c                      |  1 +
target/ppc/mmu_common.c                       |  1 +
target/ppc/mmu_helper.c                       |  1 +
target/riscv/cpu_helper.c                     |  1 +
target/riscv/pmp.c                            |  1 +
target/riscv/vector_helper.c                  |  1 +
target/rx/cpu.c                               |  1 +
target/s390x/mmu_helper.c                     |  1 +
target/s390x/tcg/mem_helper.c                 |  1 +
target/sh4/helper.c                           |  1 +
target/sparc/ldst_helper.c                    |  1 +
target/sparc/mmu_helper.c                     |  1 +
target/tricore/helper.c                       |  1 +
target/xtensa/mmu_helper.c                    |  1 +
target/xtensa/op_helper.c                     |  1 +
118 files changed, 332 insertions(+), 192 deletions(-)
create mode 100644 accel/tcg/user-retaddr.h
create mode 100644 include/exec/page-prot-common.h
create mode 100644 include/tcg/abi_ptr.h
create mode 100644 page-target.c
[PATCH 00/24] exec: Rework of various headers (user focused)
Posted by Philippe Mathieu-Daudé 1 year, 11 months ago
Hi,

These patches are extracted from a bigger work where
"exec/{exec,cpu,translate}-all.h" are split in various
specific APIs. This helped:
  - differenciate/build:
      . user VS system
      . target-specific VS generic
    which is necessary for heterogeneous build
  - reduced header pressure
  - clarify APIs

This series is focused on user (vs system) cleanups.
More useful changes will come after.

Regards,

Phil.

Philippe Mathieu-Daudé (24):
  exec: Include 'cpu.h' before validating CPUArchState placement
  exec: Expose 'target_page.h' API to user emulation
  target: Define TCG_GUEST_DEFAULT_MO in 'cpu-param.h'
  accel: Include missing 'exec/cpu_ldst.h' header
  semihosting/uaccess: Avoid including 'cpu.h'
  semihosting/guestfd: Remove unused 'semihosting/uaccess.h' header
  host/load-extract: Include missing 'qemu/atomic.h' and 'qemu/int128.h'
  host/atomic128: Include missing 'qemu/atomic.h' header
  hw/ppc/spapr_hcall: Remove unused 'exec/exec-all.h' included header
  hw/misc/mips_itu: Remove unnecessary 'exec/exec-all.h' header
  hw/s390x/ipl: Remove unused 'exec/exec-all.h' included header
  target/i386: Include missing 'exec/exec-all.h' header
  accel/tcg: Include missing 'hw/core/cpu.h' header
  gdbstub: Include missing 'hw/core/cpu.h' header
  exec/cpu-all: Remove unused headers
  exec/cpu-all: Reduce 'qemu/rcu.h' header inclusion
  target/ppc/excp_helper: Avoid 'abi_ptr' in system emulation
  accel/tcg: Un-inline retaddr helpers to 'user-retaddr.h'
  exec/user: Do not include 'cpu.h' in 'abitypes.h'
  exec: Declare abi_ptr type in its own 'tcg/abi_ptr.h' header
  exec/cpu_ldst: Avoid including 'cpu.h'
  exec/cpu-all: Restrict inclusion of 'exec/user/guest-base.h'
  exec/cpu-all: Extract page-protection definitions to
    page-prot-common.h
  target: Restrict 'sysemu/reset.h' to system emulation

 meson.build                                   |  2 +-
 accel/tcg/user-retaddr.h                      | 28 ++++++++++
 bsd-user/bsd-mem.h                            |  1 +
 bsd-user/qemu.h                               |  1 +
 host/include/generic/host/atomic128-cas.h     |  2 +
 host/include/generic/host/atomic128-ldst.h    |  2 +
 .../generic/host/load-extract-al16-al8.h      |  3 ++
 include/exec/cpu-all.h                        | 50 +++---------------
 include/exec/cpu_ldst.h                       | 51 ++++---------------
 include/exec/exec-all.h                       |  1 +
 include/exec/page-prot-common.h               | 38 ++++++++++++++
 include/exec/ram_addr.h                       |  1 +
 include/exec/translator.h                     |  5 +-
 include/exec/user/abitypes.h                  |  9 +++-
 include/exec/user/guest-base.h                |  6 +++
 include/semihosting/uaccess.h                 |  3 +-
 include/tcg/abi_ptr.h                         | 32 ++++++++++++
 target/alpha/cpu-param.h                      |  3 ++
 target/alpha/cpu.h                            |  3 --
 target/arm/cpu-param.h                        |  8 +--
 target/arm/cpu.h                              |  4 +-
 target/avr/cpu-param.h                        |  2 +
 target/avr/cpu.h                              |  2 -
 target/hppa/cpu-param.h                       |  6 +++
 target/hppa/cpu.h                             |  6 ---
 target/i386/cpu-param.h                       |  3 ++
 target/i386/cpu.h                             |  3 --
 target/loongarch/cpu-param.h                  |  2 +
 target/loongarch/cpu.h                        |  2 -
 target/microblaze/cpu-param.h                 |  3 ++
 target/microblaze/cpu.h                       |  3 --
 target/mips/cpu-param.h                       |  2 +
 target/mips/cpu.h                             |  2 -
 target/openrisc/cpu-param.h                   |  2 +
 target/openrisc/cpu.h                         |  2 -
 target/ppc/cpu-param.h                        |  2 +
 target/ppc/cpu.h                              |  2 -
 target/ppc/internal.h                         |  1 +
 target/ppc/mmu-radix64.h                      |  2 +
 target/riscv/cpu-param.h                      |  2 +
 target/riscv/cpu.h                            |  2 -
 target/s390x/cpu-param.h                      |  6 +++
 target/s390x/cpu.h                            |  3 --
 target/sparc/cpu-param.h                      | 23 +++++++++
 target/sparc/cpu.h                            | 23 ---------
 target/xtensa/cpu-param.h                     |  3 ++
 target/xtensa/cpu.h                           |  3 --
 accel/tcg/cpu-exec.c                          |  3 ++
 accel/tcg/cputlb.c                            |  2 +
 accel/tcg/tb-maint.c                          |  1 +
 accel/tcg/tcg-accel-ops.c                     |  2 +
 accel/tcg/translator.c                        |  1 +
 accel/tcg/user-exec.c                         |  2 +
 bsd-user/main.c                               |  1 +
 bsd-user/mmap.c                               |  1 +
 bsd-user/signal.c                             |  1 +
 cpu-target.c                                  |  1 +
 gdbstub/gdbstub.c                             |  1 +
 hw/misc/mips_itu.c                            |  3 +-
 hw/ppc/ppc440_bamboo.c                        |  1 +
 hw/ppc/sam460ex.c                             |  1 +
 hw/ppc/spapr_hcall.c                          |  1 -
 hw/ppc/virtex_ml507.c                         |  1 +
 hw/s390x/ipl.c                                |  1 -
 linux-user/arm/cpu_loop.c                     |  1 +
 linux-user/elfload.c                          |  2 +
 linux-user/main.c                             |  1 +
 linux-user/mmap.c                             |  1 +
 linux-user/nios2/cpu_loop.c                   |  1 +
 linux-user/signal.c                           |  1 +
 linux-user/syscall.c                          |  1 +
 page-target.c                                 | 43 ++++++++++++++++
 semihosting/guestfd.c                         |  1 -
 system/physmem.c                              | 36 +------------
 target/alpha/helper.c                         |  1 +
 target/arm/ptw.c                              |  1 +
 target/arm/tcg/m_helper.c                     |  1 +
 target/arm/tcg/mte_helper.c                   |  1 +
 target/arm/tcg/sve_helper.c                   |  1 +
 target/avr/helper.c                           |  1 +
 target/cris/mmu.c                             |  1 +
 target/hexagon/translate.c                    |  1 +
 target/hppa/mem_helper.c                      |  1 +
 target/hppa/translate.c                       |  1 +
 target/i386/cpu.c                             |  2 +-
 target/i386/tcg/fpu_helper.c                  |  1 +
 target/i386/tcg/sysemu/excp_helper.c          |  1 +
 target/loongarch/cpu.c                        |  2 +
 target/loongarch/tlb_helper.c                 |  1 +
 target/m68k/helper.c                          |  1 +
 target/microblaze/cpu.c                       |  1 +
 target/microblaze/helper.c                    |  1 +
 target/microblaze/mmu.c                       |  1 +
 target/microblaze/translate.c                 |  1 +
 target/mips/sysemu/physaddr.c                 |  1 +
 target/mips/tcg/sysemu/tlb_helper.c           |  1 +
 target/nios2/helper.c                         |  1 +
 target/nios2/mmu.c                            |  1 +
 target/nios2/translate.c                      |  1 +
 target/openrisc/mmu.c                         |  1 +
 target/ppc/excp_helper.c                      |  2 +-
 target/ppc/mmu-hash32.c                       |  1 +
 target/ppc/mmu-hash64.c                       |  1 +
 target/ppc/mmu-radix64.c                      |  1 +
 target/ppc/mmu_common.c                       |  1 +
 target/ppc/mmu_helper.c                       |  1 +
 target/riscv/cpu_helper.c                     |  1 +
 target/riscv/pmp.c                            |  1 +
 target/riscv/vector_helper.c                  |  1 +
 target/rx/cpu.c                               |  1 +
 target/s390x/mmu_helper.c                     |  1 +
 target/s390x/tcg/mem_helper.c                 |  1 +
 target/sh4/helper.c                           |  1 +
 target/sparc/ldst_helper.c                    |  1 +
 target/sparc/mmu_helper.c                     |  1 +
 target/tricore/helper.c                       |  1 +
 target/xtensa/mmu_helper.c                    |  1 +
 target/xtensa/op_helper.c                     |  1 +
 118 files changed, 332 insertions(+), 192 deletions(-)
 create mode 100644 accel/tcg/user-retaddr.h
 create mode 100644 include/exec/page-prot-common.h
 create mode 100644 include/tcg/abi_ptr.h
 create mode 100644 page-target.c

-- 
2.41.0


Re: [PATCH 00/24] exec: Rework of various headers (user focused)
Posted by Philippe Mathieu-Daudé 1 year, 11 months ago
(Forgot to Cc rev.ng folks)

On 11/12/23 22:19, Philippe Mathieu-Daudé wrote:
> Hi,
> 
> These patches are extracted from a bigger work where
> "exec/{exec,cpu,translate}-all.h" are split in various
> specific APIs. This helped:
>    - differenciate/build:
>        . user VS system
>        . target-specific VS generic
>      which is necessary for heterogeneous build
>    - reduced header pressure
>    - clarify APIs
> 
> This series is focused on user (vs system) cleanups.
> More useful changes will come after.
> 
> Regards,
> 
> Phil.
> 
> Philippe Mathieu-Daudé (24):
>    exec: Include 'cpu.h' before validating CPUArchState placement
>    exec: Expose 'target_page.h' API to user emulation
>    target: Define TCG_GUEST_DEFAULT_MO in 'cpu-param.h'
>    accel: Include missing 'exec/cpu_ldst.h' header
>    semihosting/uaccess: Avoid including 'cpu.h'
>    semihosting/guestfd: Remove unused 'semihosting/uaccess.h' header
>    host/load-extract: Include missing 'qemu/atomic.h' and 'qemu/int128.h'
>    host/atomic128: Include missing 'qemu/atomic.h' header
>    hw/ppc/spapr_hcall: Remove unused 'exec/exec-all.h' included header
>    hw/misc/mips_itu: Remove unnecessary 'exec/exec-all.h' header
>    hw/s390x/ipl: Remove unused 'exec/exec-all.h' included header
>    target/i386: Include missing 'exec/exec-all.h' header
>    accel/tcg: Include missing 'hw/core/cpu.h' header
>    gdbstub: Include missing 'hw/core/cpu.h' header
>    exec/cpu-all: Remove unused headers
>    exec/cpu-all: Reduce 'qemu/rcu.h' header inclusion
>    target/ppc/excp_helper: Avoid 'abi_ptr' in system emulation
>    accel/tcg: Un-inline retaddr helpers to 'user-retaddr.h'
>    exec/user: Do not include 'cpu.h' in 'abitypes.h'
>    exec: Declare abi_ptr type in its own 'tcg/abi_ptr.h' header
>    exec/cpu_ldst: Avoid including 'cpu.h'
>    exec/cpu-all: Restrict inclusion of 'exec/user/guest-base.h'
>    exec/cpu-all: Extract page-protection definitions to
>      page-prot-common.h
>    target: Restrict 'sysemu/reset.h' to system emulation