tests/avocado: mark ReplayKernelNormal.test_mips64el_malta as flaky

[RFC PATCH] tests/avocado: mark ReplayKernelNormal.test_mips64el_malta as flaky

Alex Bennée posted 1 patch 12 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20231201201027.2689404-1-alex.bennee@linaro.org

Maintainers: Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>, Paolo Bonzini <pbonzini@redhat.com>, Cleber Rosa <crosa@redhat.com>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Wainer dos Santos Moschetta <wainersm@redhat.com>, Beraldo Leal <bleal@redhat.com>

tests/avocado/replay_kernel.py | 3 +++
1 file changed, 3 insertions(+)

Expand all Fold all

[RFC PATCH] tests/avocado: mark ReplayKernelNormal.test_mips64el_malta as flaky

Posted by Alex Bennée 12 months ago

I missed this when going through the recent failure logs. I can run
the test 30 times without failure locally but it seems to hang pretty
reliably on GitLab's CI infra-structure.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Cc: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 tests/avocado/replay_kernel.py | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tests/avocado/replay_kernel.py b/tests/avocado/replay_kernel.py
index af086eab08..c37afa662c 100644
--- a/tests/avocado/replay_kernel.py
+++ b/tests/avocado/replay_kernel.py
@@ -119,6 +119,8 @@ def test_mips_malta(self):
 
         self.run_rr(kernel_path, kernel_command_line, console_pattern, shift=5)
 
+    # See https://gitlab.com/qemu-project/qemu/-/issues/2013
+    @skipUnless(os.getenv('QEMU_TEST_FLAKY_TESTS'), 'Test is unstable on GitLab')
     def test_mips64el_malta(self):
         """
         This test requires the ar tool to extract "data.tar.gz" from
@@ -134,6 +136,7 @@ def test_mips64el_malta(self):
 
         :avocado: tags=arch:mips64el
         :avocado: tags=machine:malta
+        :avocado: tags=flaky
         """
         deb_url = ('http://snapshot.debian.org/archive/debian/'
                    '20130217T032700Z/pool/main/l/linux-2.6/'
-- 
2.39.2

Re: [RFC PATCH] tests/avocado: mark ReplayKernelNormal.test_mips64el_malta as flaky

Posted by Philippe Mathieu-Daudé 11 months, 4 weeks ago

On 1/12/23 21:10, Alex Bennée wrote:
> I missed this when going through the recent failure logs. I can run
> the test 30 times without failure locally but it seems to hang pretty
> reliably on GitLab's CI infra-structure.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Cc: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   tests/avocado/replay_kernel.py | 3 +++
>   1 file changed, 3 insertions(+)

Thanks, queued in misc-fixes.

Re: [RFC PATCH] tests/avocado: mark ReplayKernelNormal.test_mips64el_malta as flaky

Posted by Philippe Mathieu-Daudé 12 months ago

On 1/12/23 21:10, Alex Bennée wrote:
> I missed this when going through the recent failure logs. I can run
> the test 30 times without failure locally but it seems to hang pretty
> reliably on GitLab's CI infra-structure.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Cc: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   tests/avocado/replay_kernel.py | 3 +++
>   1 file changed, 3 insertions(+)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>