[v1] linux-user: openat() fixes

[PATCH 1/2] linux-user: Define TARGET_O_LARGEFILE for aarch64

Posted by Shu-Chun Weng 12 months ago

In 050a1ba, when moving the macros from preprocessor-guarding to
file-based definition, TARGET_O_LARGEFILE appeared to have been
accidentally left off.

This may have correctness implication, but so far I was only confused by
strace's output.

Signed-off-by: Shu-Chun Weng <scw@google.com>
---
 linux-user/aarch64/target_fcntl.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/linux-user/aarch64/target_fcntl.h b/linux-user/aarch64/target_fcntl.h
index efdf6e5f05..55ab788a7c 100644
--- a/linux-user/aarch64/target_fcntl.h
+++ b/linux-user/aarch64/target_fcntl.h
@@ -11,6 +11,7 @@
 #define TARGET_O_DIRECTORY      040000 /* must be a directory */
 #define TARGET_O_NOFOLLOW      0100000 /* don't follow links */
 #define TARGET_O_DIRECT        0200000 /* direct disk access hint */
+#define TARGET_O_LARGEFILE     0400000
 
 #include "../generic/fcntl.h"
 #endif

Re: [PATCH 1/2] linux-user: Define TARGET_O_LARGEFILE for aarch64

Posted by Laurent Vivier 11 months, 4 weeks ago

Le 01/12/2023 à 04:21, Shu-Chun Weng a écrit :
> In 050a1ba, when moving the macros from preprocessor-guarding to
> file-based definition, TARGET_O_LARGEFILE appeared to have been
> accidentally left off.
> 
> This may have correctness implication, but so far I was only confused by
> strace's output.
> 
> Signed-off-by: Shu-Chun Weng <scw@google.com>
> ---
>   linux-user/aarch64/target_fcntl.h | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/linux-user/aarch64/target_fcntl.h b/linux-user/aarch64/target_fcntl.h
> index efdf6e5f05..55ab788a7c 100644
> --- a/linux-user/aarch64/target_fcntl.h
> +++ b/linux-user/aarch64/target_fcntl.h
> @@ -11,6 +11,7 @@
>   #define TARGET_O_DIRECTORY      040000 /* must be a directory */
>   #define TARGET_O_NOFOLLOW      0100000 /* don't follow links */
>   #define TARGET_O_DIRECT        0200000 /* direct disk access hint */
> +#define TARGET_O_LARGEFILE     0400000
>   
>   #include "../generic/fcntl.h"
>   #endif

Reviewed-by: Laurent Vivier <laurent@vivier.eu>

Re: [PATCH-for-8.2? 1/2] linux-user: Define TARGET_O_LARGEFILE for aarch64

Posted by Philippe Mathieu-Daudé 12 months ago

On 1/12/23 04:21, Shu-Chun Weng wrote:
> In 050a1ba, when moving the macros from preprocessor-guarding to
> file-based definition, TARGET_O_LARGEFILE appeared to have been
> accidentally left off.
> 
> This may have correctness implication, but so far I was only confused by
> strace's output.
> 

Fixes: 050a1ba69a ("linux-user: move arm/aarch64/m68k fcntl definitions 
to [arm|aarch64|m68k]/target_fcntl.h")

> Signed-off-by: Shu-Chun Weng <scw@google.com>
> ---
>   linux-user/aarch64/target_fcntl.h | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/linux-user/aarch64/target_fcntl.h b/linux-user/aarch64/target_fcntl.h
> index efdf6e5f05..55ab788a7c 100644
> --- a/linux-user/aarch64/target_fcntl.h
> +++ b/linux-user/aarch64/target_fcntl.h
> @@ -11,6 +11,7 @@
>   #define TARGET_O_DIRECTORY      040000 /* must be a directory */
>   #define TARGET_O_NOFOLLOW      0100000 /* don't follow links */
>   #define TARGET_O_DIRECT        0200000 /* direct disk access hint */
> +#define TARGET_O_LARGEFILE     0400000
>   
>   #include "../generic/fcntl.h"
>   #endif
>