[PATCH 0/6] Make Big QEMU Lock naming consistent

Stefan Hajnoczi posted 6 patches 12 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20231129212625.1051502-1-stefanha@redhat.com
Maintainers: Richard Henderson <richard.henderson@linaro.org>, Paolo Bonzini <pbonzini@redhat.com>, Cameron Esfahani <dirty@apple.com>, Roman Bolshakov <rbolshakov@ddn.com>, Gerd Hoffmann <kraxel@redhat.com>, "Marc-André Lureau" <marcandre.lureau@redhat.com>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Markus Armbruster <armbru@redhat.com>, Michael Roth <michael.roth@amd.com>, Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>, Stefan Hajnoczi <stefanha@redhat.com>, Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, Peter Xu <peterx@redhat.com>, Jason Wang <jasowang@redhat.com>, Eduardo Habkost <eduardo@habkost.net>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, David Woodhouse <dwmw2@infradead.org>, Paul Durrant <paul@xen.org>, Peter Maydell <peter.maydell@linaro.org>, Halil Pasic <pasic@linux.ibm.com>, Christian Borntraeger <borntraeger@linux.ibm.com>, David Hildenbrand <david@redhat.com>, Thomas Huth <thuth@redhat.com>, Jiri Slaby <jslaby@suse.cz>, Jean-Christophe Dubois <jcd@tribudubois.net>, Andrey Smirnov <andrew.smirnov@gmail.com>, Stefano Stabellini <sstabellini@kernel.org>, Anthony Perard <anthony.perard@citrix.com>, BALATON Zoltan <balaton@eik.bme.hu>, Nicholas Piggin <npiggin@gmail.com>, Daniel Henrique Barboza <danielhb413@gmail.com>, "Cédric Le Goater" <clg@kaod.org>, David Gibson <david@gibson.dropbear.id.au>, Harsh Prateek Bora <harshpb@linux.ibm.com>, Elena Ufimtseva <elena.ufimtseva@oracle.com>, Jagannathan Raman <jag.raman@oracle.com>, Eric Farman <farman@linux.ibm.com>, Ilya Leoshkevich <iii@linux.ibm.com>, Fam Zheng <fam@euphon.net>, John Snow <jsnow@redhat.com>, Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>, "Daniel P. Berrangé" <berrange@redhat.com>, Juan Quintela <quintela@redhat.com>, Fabiano Rosas <farosas@suse.de>, Leonardo Bras <leobras@redhat.com>, Eric Blake <eblake@redhat.com>, Hailiang Zhang <zhanghailiang@xfusion.com>, Hyman Huang <yong.huang@smartx.com>, "Alex Bennée" <alex.bennee@linaro.org>, Alexander Graf <agraf@csgraf.de>, Marcelo Tosatti <mtosatti@redhat.com>, Reinoud Zandijk <reinoud@netbsd.org>, Sunil Muthuswamy <sunilmut@microsoft.com>, Song Gao <gaosong@loongson.cn>, Huacai Chen <chenhuacai@kernel.org>, Aurelien Jarno <aurelien@aurel32.net>, Jiaxun Yang <jiaxun.yang@flygoat.com>, Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>, Stafford Horne <shorne@gmail.com>, Palmer Dabbelt <palmer@dabbelt.com>, Alistair Francis <alistair.francis@wdc.com>, Bin Meng <bin.meng@windriver.com>, Weiwei Li <liwei1518@gmail.com>, Liu Zhiwei <zhiwei_liu@linux.alibaba.com>, Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>, Artyom Tarasenko <atar4qemu@gmail.com>, Max Filippov <jcmvbkbc@gmail.com>, Akihiko Odaki <akihiko.odaki@daynix.com>
There is a newer version of this series
docs/devel/multi-thread-tcg.rst      |   7 +-
docs/devel/qapi-code-gen.rst         |   2 +-
docs/devel/replay.rst                |   2 +-
docs/devel/reset.rst                 |   2 +-
docs/devel/multiple-iothreads.txt    |  16 ++--
hw/display/qxl.h                     |   2 +-
include/block/aio-wait.h             |   2 +-
include/block/blockjob.h             |   6 +-
include/exec/cpu-common.h            |   2 +-
include/exec/memory.h                |   4 +-
include/exec/ramblock.h              |   2 +-
include/io/task.h                    |   2 +-
include/migration/register.h         |   8 +-
include/qemu/coroutine-core.h        |   2 +-
include/qemu/coroutine.h             |   2 +-
include/qemu/main-loop.h             |  54 ++++++------
target/arm/internals.h               |   4 +-
accel/accel-blocker.c                |  10 +--
accel/dummy-cpus.c                   |   8 +-
accel/hvf/hvf-accel-ops.c            |   4 +-
accel/kvm/kvm-accel-ops.c            |   4 +-
accel/kvm/kvm-all.c                  |  22 ++---
accel/tcg/cpu-exec.c                 |  26 +++---
accel/tcg/cputlb.c                   |  20 ++---
accel/tcg/tcg-accel-ops-icount.c     |   6 +-
accel/tcg/tcg-accel-ops-mttcg.c      |  12 +--
accel/tcg/tcg-accel-ops-rr.c         |  18 ++--
accel/tcg/tcg-accel-ops.c            |   2 +-
accel/tcg/translate-all.c            |   2 +-
cpu-common.c                         |   4 +-
dump/dump.c                          |   4 +-
hw/block/dataplane/virtio-blk.c      |   8 +-
hw/block/virtio-blk.c                |   2 +-
hw/core/cpu-common.c                 |   6 +-
hw/display/virtio-gpu.c              |   2 +-
hw/i386/intel_iommu.c                |   6 +-
hw/i386/kvm/xen_evtchn.c             |  30 +++----
hw/i386/kvm/xen_gnttab.c             |   2 +-
hw/i386/kvm/xen_overlay.c            |   2 +-
hw/i386/kvm/xen_xenstore.c           |   2 +-
hw/intc/arm_gicv3_cpuif.c            |   2 +-
hw/intc/s390_flic.c                  |  18 ++--
hw/mips/mips_int.c                   |   2 +-
hw/misc/edu.c                        |   4 +-
hw/misc/imx6_src.c                   |   2 +-
hw/misc/imx7_src.c                   |   2 +-
hw/net/xen_nic.c                     |   8 +-
hw/ppc/pegasos2.c                    |   2 +-
hw/ppc/ppc.c                         |   6 +-
hw/ppc/spapr.c                       |   2 +-
hw/ppc/spapr_events.c                |   2 +-
hw/ppc/spapr_rng.c                   |   4 +-
hw/ppc/spapr_softmmu.c               |   4 +-
hw/remote/mpqemu-link.c              |  14 ++--
hw/remote/vfio-user-obj.c            |   2 +-
hw/s390x/s390-skeys.c                |   2 +-
hw/scsi/virtio-scsi-dataplane.c      |   6 +-
migration/block-dirty-bitmap.c       |  14 ++--
migration/block.c                    |  40 ++++-----
migration/colo.c                     |  62 +++++++-------
migration/dirtyrate.c                |  12 +--
migration/migration.c                |  54 ++++++------
migration/ram.c                      |  16 ++--
net/tap.c                            |   2 +-
replay/replay-internal.c             |   2 +-
semihosting/console.c                |   8 +-
stubs/iothread-lock.c                |   6 +-
system/cpu-throttle.c                |   6 +-
system/cpus.c                        |  52 ++++++------
system/dirtylimit.c                  |   4 +-
system/memory.c                      |   2 +-
system/physmem.c                     |  14 ++--
system/runstate.c                    |   2 +-
system/watchpoint.c                  |   4 +-
target/arm/arm-powerctl.c            |  14 ++--
target/arm/helper.c                  |   6 +-
target/arm/hvf/hvf.c                 |   8 +-
target/arm/kvm.c                     |   4 +-
target/arm/kvm64.c                   |   4 +-
target/arm/ptw.c                     |   6 +-
target/arm/tcg/helper-a64.c          |   8 +-
target/arm/tcg/m_helper.c            |   6 +-
target/arm/tcg/op_helper.c           |  24 +++---
target/arm/tcg/psci.c                |   2 +-
target/hppa/int_helper.c             |   8 +-
target/i386/hvf/hvf.c                |   6 +-
target/i386/kvm/hyperv.c             |   4 +-
target/i386/kvm/kvm.c                |  28 +++----
target/i386/kvm/xen-emu.c            |  16 ++--
target/i386/nvmm/nvmm-accel-ops.c    |   6 +-
target/i386/nvmm/nvmm-all.c          |  20 ++---
target/i386/tcg/sysemu/fpu_helper.c  |   6 +-
target/i386/tcg/sysemu/misc_helper.c |   4 +-
target/i386/whpx/whpx-accel-ops.c    |   6 +-
target/i386/whpx/whpx-all.c          |  24 +++---
target/loongarch/csr_helper.c        |   4 +-
target/mips/kvm.c                    |   4 +-
target/mips/tcg/sysemu/cp0_helper.c  |   4 +-
target/openrisc/sys_helper.c         |  16 ++--
target/ppc/excp_helper.c             |  14 ++--
target/ppc/helper_regs.c             |   2 +-
target/ppc/kvm.c                     |   4 +-
target/ppc/misc_helper.c             |   8 +-
target/ppc/timebase_helper.c         |   8 +-
target/riscv/cpu_helper.c            |   4 +-
target/s390x/kvm/kvm.c               |   4 +-
target/s390x/tcg/misc_helper.c       | 118 +++++++++++++--------------
target/sparc/int32_helper.c          |   2 +-
target/sparc/int64_helper.c          |   6 +-
target/sparc/win_helper.c            |  20 ++---
target/xtensa/exc_helper.c           |   8 +-
ui/spice-core.c                      |   6 +-
util/async.c                         |   2 +-
util/main-loop.c                     |   8 +-
util/rcu.c                           |  16 ++--
audio/coreaudio.m                    |   8 +-
memory_ldst.c.inc                    |  18 ++--
target/i386/hvf/README.md            |   2 +-
ui/cocoa.m                           |  56 ++++++-------
119 files changed, 627 insertions(+), 628 deletions(-)
[PATCH 0/6] Make Big QEMU Lock naming consistent
Posted by Stefan Hajnoczi 12 months ago
The Big QEMU Lock ("BQL") has two other names: "iothread lock" and "QEMU global
mutex". The term "iothread lock" is easily confused with the unrelated --object
iothread (iothread.c).

This series updates the code and documentation to consistently use "BQL". This
makes the code easier to understand.

Stefan Hajnoczi (6):
  system/cpus: rename qemu_mutex_lock_iothread() to qemu_bql_lock()
  qemu/main-loop: rename QEMU_IOTHREAD_LOCK_GUARD to QEMU_BQL_LOCK_GUARD
  qemu/main-loop: rename qemu_cond_wait_iothread() to
    qemu_cond_wait_bql()
  system/cpus: rename qemu_global_mutex to qemu_bql
  Replace "iothread lock" with "BQL" in comments
  Rename "QEMU global mutex" to "BQL" in comments and docs

 docs/devel/multi-thread-tcg.rst      |   7 +-
 docs/devel/qapi-code-gen.rst         |   2 +-
 docs/devel/replay.rst                |   2 +-
 docs/devel/reset.rst                 |   2 +-
 docs/devel/multiple-iothreads.txt    |  16 ++--
 hw/display/qxl.h                     |   2 +-
 include/block/aio-wait.h             |   2 +-
 include/block/blockjob.h             |   6 +-
 include/exec/cpu-common.h            |   2 +-
 include/exec/memory.h                |   4 +-
 include/exec/ramblock.h              |   2 +-
 include/io/task.h                    |   2 +-
 include/migration/register.h         |   8 +-
 include/qemu/coroutine-core.h        |   2 +-
 include/qemu/coroutine.h             |   2 +-
 include/qemu/main-loop.h             |  54 ++++++------
 target/arm/internals.h               |   4 +-
 accel/accel-blocker.c                |  10 +--
 accel/dummy-cpus.c                   |   8 +-
 accel/hvf/hvf-accel-ops.c            |   4 +-
 accel/kvm/kvm-accel-ops.c            |   4 +-
 accel/kvm/kvm-all.c                  |  22 ++---
 accel/tcg/cpu-exec.c                 |  26 +++---
 accel/tcg/cputlb.c                   |  20 ++---
 accel/tcg/tcg-accel-ops-icount.c     |   6 +-
 accel/tcg/tcg-accel-ops-mttcg.c      |  12 +--
 accel/tcg/tcg-accel-ops-rr.c         |  18 ++--
 accel/tcg/tcg-accel-ops.c            |   2 +-
 accel/tcg/translate-all.c            |   2 +-
 cpu-common.c                         |   4 +-
 dump/dump.c                          |   4 +-
 hw/block/dataplane/virtio-blk.c      |   8 +-
 hw/block/virtio-blk.c                |   2 +-
 hw/core/cpu-common.c                 |   6 +-
 hw/display/virtio-gpu.c              |   2 +-
 hw/i386/intel_iommu.c                |   6 +-
 hw/i386/kvm/xen_evtchn.c             |  30 +++----
 hw/i386/kvm/xen_gnttab.c             |   2 +-
 hw/i386/kvm/xen_overlay.c            |   2 +-
 hw/i386/kvm/xen_xenstore.c           |   2 +-
 hw/intc/arm_gicv3_cpuif.c            |   2 +-
 hw/intc/s390_flic.c                  |  18 ++--
 hw/mips/mips_int.c                   |   2 +-
 hw/misc/edu.c                        |   4 +-
 hw/misc/imx6_src.c                   |   2 +-
 hw/misc/imx7_src.c                   |   2 +-
 hw/net/xen_nic.c                     |   8 +-
 hw/ppc/pegasos2.c                    |   2 +-
 hw/ppc/ppc.c                         |   6 +-
 hw/ppc/spapr.c                       |   2 +-
 hw/ppc/spapr_events.c                |   2 +-
 hw/ppc/spapr_rng.c                   |   4 +-
 hw/ppc/spapr_softmmu.c               |   4 +-
 hw/remote/mpqemu-link.c              |  14 ++--
 hw/remote/vfio-user-obj.c            |   2 +-
 hw/s390x/s390-skeys.c                |   2 +-
 hw/scsi/virtio-scsi-dataplane.c      |   6 +-
 migration/block-dirty-bitmap.c       |  14 ++--
 migration/block.c                    |  40 ++++-----
 migration/colo.c                     |  62 +++++++-------
 migration/dirtyrate.c                |  12 +--
 migration/migration.c                |  54 ++++++------
 migration/ram.c                      |  16 ++--
 net/tap.c                            |   2 +-
 replay/replay-internal.c             |   2 +-
 semihosting/console.c                |   8 +-
 stubs/iothread-lock.c                |   6 +-
 system/cpu-throttle.c                |   6 +-
 system/cpus.c                        |  52 ++++++------
 system/dirtylimit.c                  |   4 +-
 system/memory.c                      |   2 +-
 system/physmem.c                     |  14 ++--
 system/runstate.c                    |   2 +-
 system/watchpoint.c                  |   4 +-
 target/arm/arm-powerctl.c            |  14 ++--
 target/arm/helper.c                  |   6 +-
 target/arm/hvf/hvf.c                 |   8 +-
 target/arm/kvm.c                     |   4 +-
 target/arm/kvm64.c                   |   4 +-
 target/arm/ptw.c                     |   6 +-
 target/arm/tcg/helper-a64.c          |   8 +-
 target/arm/tcg/m_helper.c            |   6 +-
 target/arm/tcg/op_helper.c           |  24 +++---
 target/arm/tcg/psci.c                |   2 +-
 target/hppa/int_helper.c             |   8 +-
 target/i386/hvf/hvf.c                |   6 +-
 target/i386/kvm/hyperv.c             |   4 +-
 target/i386/kvm/kvm.c                |  28 +++----
 target/i386/kvm/xen-emu.c            |  16 ++--
 target/i386/nvmm/nvmm-accel-ops.c    |   6 +-
 target/i386/nvmm/nvmm-all.c          |  20 ++---
 target/i386/tcg/sysemu/fpu_helper.c  |   6 +-
 target/i386/tcg/sysemu/misc_helper.c |   4 +-
 target/i386/whpx/whpx-accel-ops.c    |   6 +-
 target/i386/whpx/whpx-all.c          |  24 +++---
 target/loongarch/csr_helper.c        |   4 +-
 target/mips/kvm.c                    |   4 +-
 target/mips/tcg/sysemu/cp0_helper.c  |   4 +-
 target/openrisc/sys_helper.c         |  16 ++--
 target/ppc/excp_helper.c             |  14 ++--
 target/ppc/helper_regs.c             |   2 +-
 target/ppc/kvm.c                     |   4 +-
 target/ppc/misc_helper.c             |   8 +-
 target/ppc/timebase_helper.c         |   8 +-
 target/riscv/cpu_helper.c            |   4 +-
 target/s390x/kvm/kvm.c               |   4 +-
 target/s390x/tcg/misc_helper.c       | 118 +++++++++++++--------------
 target/sparc/int32_helper.c          |   2 +-
 target/sparc/int64_helper.c          |   6 +-
 target/sparc/win_helper.c            |  20 ++---
 target/xtensa/exc_helper.c           |   8 +-
 ui/spice-core.c                      |   6 +-
 util/async.c                         |   2 +-
 util/main-loop.c                     |   8 +-
 util/rcu.c                           |  16 ++--
 audio/coreaudio.m                    |   8 +-
 memory_ldst.c.inc                    |  18 ++--
 target/i386/hvf/README.md            |   2 +-
 ui/cocoa.m                           |  56 ++++++-------
 119 files changed, 627 insertions(+), 628 deletions(-)

-- 
2.42.0