1. Patchew
  2. QEMU
  3. View series

[PATCH] tests: bios-tables-test: Rename smbios type 4 related test functions

Zhao Liu posted 1 patch 2 years, 2 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20231127160202.1037290-1-zhao1.liu@linux.intel.com
Maintainers: "Michael S. Tsirkin" <mst@redhat.com>, Igor Mammedov <imammedo@redhat.com>, Ani Sinha <anisinha@redhat.com>
tests/qtest/bios-tables-test.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
[PATCH] tests: bios-tables-test: Rename smbios type 4 related test functions
Posted by Zhao Liu 2 years, 2 months ago 
From: Zhao Liu <zhao1.liu@intel.com>

In fact, type4-count, core-count, core-count2, thread-count and
thread-count2 are tested with KVM not TCG.

Rename these test functions to reflect KVM base instead of TCG.

Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
---
 tests/qtest/bios-tables-test.c | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
index 71af5cf69fc5..9a7e459e8ffb 100644
--- a/tests/qtest/bios-tables-test.c
+++ b/tests/qtest/bios-tables-test.c
@@ -1003,7 +1003,7 @@ static void test_acpi_q35_tcg(void)
     free_test_data(&data);
 }
 
-static void test_acpi_q35_tcg_type4_count(void)
+static void test_acpi_q35_kvm_type4_count(void)
 {
     test_data data = {
         .machine = MACHINE_Q35,
@@ -1019,7 +1019,7 @@ static void test_acpi_q35_tcg_type4_count(void)
     free_test_data(&data);
 }
 
-static void test_acpi_q35_tcg_core_count(void)
+static void test_acpi_q35_kvm_core_count(void)
 {
     test_data data = {
         .machine = MACHINE_Q35,
@@ -1036,7 +1036,7 @@ static void test_acpi_q35_tcg_core_count(void)
     free_test_data(&data);
 }
 
-static void test_acpi_q35_tcg_core_count2(void)
+static void test_acpi_q35_kvm_core_count2(void)
 {
     test_data data = {
         .machine = MACHINE_Q35,
@@ -1053,7 +1053,7 @@ static void test_acpi_q35_tcg_core_count2(void)
     free_test_data(&data);
 }
 
-static void test_acpi_q35_tcg_thread_count(void)
+static void test_acpi_q35_kvm_thread_count(void)
 {
     test_data data = {
         .machine = MACHINE_Q35,
@@ -1070,7 +1070,7 @@ static void test_acpi_q35_tcg_thread_count(void)
     free_test_data(&data);
 }
 
-static void test_acpi_q35_tcg_thread_count2(void)
+static void test_acpi_q35_kvm_thread_count2(void)
 {
     test_data data = {
         .machine = MACHINE_Q35,
@@ -2250,15 +2250,15 @@ int main(int argc, char *argv[])
                 qtest_add_func("acpi/q35/kvm/xapic", test_acpi_q35_kvm_xapic);
                 qtest_add_func("acpi/q35/kvm/dmar", test_acpi_q35_kvm_dmar);
                 qtest_add_func("acpi/q35/type4-count",
-                               test_acpi_q35_tcg_type4_count);
+                               test_acpi_q35_kvm_type4_count);
                 qtest_add_func("acpi/q35/core-count",
-                               test_acpi_q35_tcg_core_count);
+                               test_acpi_q35_kvm_core_count);
                 qtest_add_func("acpi/q35/core-count2",
-                               test_acpi_q35_tcg_core_count2);
+                               test_acpi_q35_kvm_core_count2);
                 qtest_add_func("acpi/q35/thread-count",
-                               test_acpi_q35_tcg_thread_count);
+                               test_acpi_q35_kvm_thread_count);
                 qtest_add_func("acpi/q35/thread-count2",
-                               test_acpi_q35_tcg_thread_count2);
+                               test_acpi_q35_kvm_thread_count2);
             }
             if (qtest_has_device("virtio-iommu-pci")) {
                 qtest_add_func("acpi/q35/viot", test_acpi_q35_viot);
-- 
2.34.1
Re: [PATCH] tests: bios-tables-test: Rename smbios type 4 related test functions
Posted by Igor Mammedov 2 years, 2 months ago 
On Tue, 28 Nov 2023 00:02:02 +0800
Zhao Liu <zhao1.liu@linux.intel.com> wrote:

> From: Zhao Liu <zhao1.liu@intel.com>
> 
> In fact, type4-count, core-count, core-count2, thread-count and
> thread-count2 are tested with KVM not TCG.
> 
> Rename these test functions to reflect KVM base instead of TCG.
> 
> Signed-off-by: Zhao Liu <zhao1.liu@intel.com>

Reviewed-by: Igor Mammedov <imammedo@redhat.com>

> ---
>  tests/qtest/bios-tables-test.c | 20 ++++++++++----------
>  1 file changed, 10 insertions(+), 10 deletions(-)
> 
> diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
> index 71af5cf69fc5..9a7e459e8ffb 100644
> --- a/tests/qtest/bios-tables-test.c
> +++ b/tests/qtest/bios-tables-test.c
> @@ -1003,7 +1003,7 @@ static void test_acpi_q35_tcg(void)
>      free_test_data(&data);
>  }
>  
> -static void test_acpi_q35_tcg_type4_count(void)
> +static void test_acpi_q35_kvm_type4_count(void)
>  {
>      test_data data = {
>          .machine = MACHINE_Q35,
> @@ -1019,7 +1019,7 @@ static void test_acpi_q35_tcg_type4_count(void)
>      free_test_data(&data);
>  }
>  
> -static void test_acpi_q35_tcg_core_count(void)
> +static void test_acpi_q35_kvm_core_count(void)
>  {
>      test_data data = {
>          .machine = MACHINE_Q35,
> @@ -1036,7 +1036,7 @@ static void test_acpi_q35_tcg_core_count(void)
>      free_test_data(&data);
>  }
>  
> -static void test_acpi_q35_tcg_core_count2(void)
> +static void test_acpi_q35_kvm_core_count2(void)
>  {
>      test_data data = {
>          .machine = MACHINE_Q35,
> @@ -1053,7 +1053,7 @@ static void test_acpi_q35_tcg_core_count2(void)
>      free_test_data(&data);
>  }
>  
> -static void test_acpi_q35_tcg_thread_count(void)
> +static void test_acpi_q35_kvm_thread_count(void)
>  {
>      test_data data = {
>          .machine = MACHINE_Q35,
> @@ -1070,7 +1070,7 @@ static void test_acpi_q35_tcg_thread_count(void)
>      free_test_data(&data);
>  }
>  
> -static void test_acpi_q35_tcg_thread_count2(void)
> +static void test_acpi_q35_kvm_thread_count2(void)
>  {
>      test_data data = {
>          .machine = MACHINE_Q35,
> @@ -2250,15 +2250,15 @@ int main(int argc, char *argv[])
>                  qtest_add_func("acpi/q35/kvm/xapic", test_acpi_q35_kvm_xapic);
>                  qtest_add_func("acpi/q35/kvm/dmar", test_acpi_q35_kvm_dmar);
>                  qtest_add_func("acpi/q35/type4-count",
> -                               test_acpi_q35_tcg_type4_count);
> +                               test_acpi_q35_kvm_type4_count);
>                  qtest_add_func("acpi/q35/core-count",
> -                               test_acpi_q35_tcg_core_count);
> +                               test_acpi_q35_kvm_core_count);
>                  qtest_add_func("acpi/q35/core-count2",
> -                               test_acpi_q35_tcg_core_count2);
> +                               test_acpi_q35_kvm_core_count2);
>                  qtest_add_func("acpi/q35/thread-count",
> -                               test_acpi_q35_tcg_thread_count);
> +                               test_acpi_q35_kvm_thread_count);
>                  qtest_add_func("acpi/q35/thread-count2",
> -                               test_acpi_q35_tcg_thread_count2);
> +                               test_acpi_q35_kvm_thread_count2);
>              }
>              if (qtest_has_device("virtio-iommu-pci")) {
>                  qtest_add_func("acpi/q35/viot", test_acpi_q35_viot);
Re: [PATCH] tests: bios-tables-test: Rename smbios type 4 related test functions
Posted by Philippe Mathieu-Daudé 2 years, 2 months ago 
On 27/11/23 17:02, Zhao Liu wrote:
> From: Zhao Liu <zhao1.liu@intel.com>
> 
> In fact, type4-count, core-count, core-count2, thread-count and
> thread-count2 are tested with KVM not TCG.
> 
> Rename these test functions to reflect KVM base instead of TCG.
> 
> Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
> ---
>   tests/qtest/bios-tables-test.c | 20 ++++++++++----------
>   1 file changed, 10 insertions(+), 10 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.