hw/loongarch/virt: Align high memory base address with super page size

[PATCH] hw/loongarch/virt: Align high memory base address with super page size

Posted by Bibo Mao 1 year ago

With LoongArch virt machine, there is low memory space with region
0--0x10000000, and high memory space with started from 0x90000000.
High memory space is aligned with 256M, it will be better if it is
aligned with 1G, which is super page aligned for 4K page size.

Currently linux kernel and uefi bios has no limitation with high
memory base address, it is ok to set high memory base address
with 0x80000000.

Signed-off-by: Bibo Mao <maobibo@loongson.cn>
Change-Id: Iac1af728bf6fd35c9c2f4e7dbdae6e3c0fbab623
---
 include/hw/loongarch/virt.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/hw/loongarch/virt.h b/include/hw/loongarch/virt.h
index 674f4655e0..db0831b471 100644
--- a/include/hw/loongarch/virt.h
+++ b/include/hw/loongarch/virt.h
@@ -25,7 +25,7 @@
 
 #define VIRT_LOWMEM_BASE        0
 #define VIRT_LOWMEM_SIZE        0x10000000
-#define VIRT_HIGHMEM_BASE       0x90000000
+#define VIRT_HIGHMEM_BASE       0x80000000
 #define VIRT_GED_EVT_ADDR       0x100e0000
 #define VIRT_GED_MEM_ADDR       (VIRT_GED_EVT_ADDR + ACPI_GED_EVT_SEL_LEN)
 #define VIRT_GED_REG_ADDR       (VIRT_GED_MEM_ADDR + MEMORY_HOTPLUG_IO_LEN)
-- 
2.39.3

Re: [PATCH] hw/loongarch/virt: Align high memory base address with super page size

Posted by gaosong 11 months, 1 week ago

在 2023/11/27 下午12:02, Bibo Mao 写道:
> With LoongArch virt machine, there is low memory space with region
> 0--0x10000000, and high memory space with started from 0x90000000.
> High memory space is aligned with 256M, it will be better if it is
> aligned with 1G, which is super page aligned for 4K page size.
>
> Currently linux kernel and uefi bios has no limitation with high
> memory base address, it is ok to set high memory base address
> with 0x80000000.
>
> Signed-off-by: Bibo Mao <maobibo@loongson.cn>
> Change-Id: Iac1af728bf6fd35c9c2f4e7dbdae6e3c0fbab623
> ---
>   include/hw/loongarch/virt.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
Drop Change-Id.
Reviewed-by: Song Gao <gaosong@loongson.cn>

Thanks.
Song Gao
> diff --git a/include/hw/loongarch/virt.h b/include/hw/loongarch/virt.h
> index 674f4655e0..db0831b471 100644
> --- a/include/hw/loongarch/virt.h
> +++ b/include/hw/loongarch/virt.h
> @@ -25,7 +25,7 @@
>   
>   #define VIRT_LOWMEM_BASE        0
>   #define VIRT_LOWMEM_SIZE        0x10000000
> -#define VIRT_HIGHMEM_BASE       0x90000000
> +#define VIRT_HIGHMEM_BASE       0x80000000
>   #define VIRT_GED_EVT_ADDR       0x100e0000
>   #define VIRT_GED_MEM_ADDR       (VIRT_GED_EVT_ADDR + ACPI_GED_EVT_SEL_LEN)
>   #define VIRT_GED_REG_ADDR       (VIRT_GED_MEM_ADDR + MEMORY_HOTPLUG_IO_LEN)