Fix broken build for QEMU guest agent

[PATCH for-8.2] Fix broken build for QEMU guest agent

Stefan Weil via posted 1 patch 1 year ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20231125152740.584224-1-sw@weilnetz.de

Maintainers: Michael Roth <michael.roth@amd.com>, Konstantin Kostiuk <kkostiuk@redhat.com>

qga/meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH for-8.2] Fix broken build for QEMU guest agent

Posted by Stefan Weil via 1 year ago

Meson setup failed:

    qga/meson.build:148:4: ERROR: Unknown variable "project".

Fixes commit e20d68aa ("configure, meson: use command line options [...]").

Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
 qga/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/qga/meson.build b/qga/meson.build
index 940a51d55d..ff7a8496e4 100644
--- a/qga/meson.build
+++ b/qga/meson.build
@@ -146,7 +146,7 @@ if targetos == 'windows'
       libpcre = 'libpcre2'
     endif
     qga_msi_version = get_option('qemu_ga_version') == '' \
-      ? project.version() \
+      ? meson.project_version() \
       : get_option('qemu_ga_version')
     qga_msi = custom_target('QGA MSI',
                             input: files('installer/qemu-ga.wxs'),
-- 
2.39.2

Re: [PATCH for-8.2] Fix broken build for QEMU guest agent

Posted by Konstantin Kostiuk 1 year ago

Hi Stefan,

Thanks for your patch.
PULL was sent with Marc-André patch
https://patchew.org/QEMU/20231125173011.374840-1-kkostiuk@redhat.com/

Best Regards,
Konstantin Kostiuk.


On Sat, Nov 25, 2023 at 5:29 PM Stefan Weil via <qemu-devel@nongnu.org>
wrote:

> Meson setup failed:
>
>     qga/meson.build:148:4: ERROR: Unknown variable "project".
>
> Fixes commit e20d68aa ("configure, meson: use command line options [...]").
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
>  qga/meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qga/meson.build b/qga/meson.build
> index 940a51d55d..ff7a8496e4 100644
> --- a/qga/meson.build
> +++ b/qga/meson.build
> @@ -146,7 +146,7 @@ if targetos == 'windows'
>        libpcre = 'libpcre2'
>      endif
>      qga_msi_version = get_option('qemu_ga_version') == '' \
> -      ? project.version() \
> +      ? meson.project_version() \
>        : get_option('qemu_ga_version')
>      qga_msi = custom_target('QGA MSI',
>                              input: files('installer/qemu-ga.wxs'),
> --
> 2.39.2
>
>
>