[PATCH for-8.2 0/2] qdev array property fixes

Kevin Wolf posted 2 patches 1 year ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20231121173416.346610-1-kwolf@redhat.com
Maintainers: Paolo Bonzini <pbonzini@redhat.com>, "Daniel P. Berrangé" <berrange@redhat.com>, Eduardo Habkost <eduardo@habkost.net>, Markus Armbruster <armbru@redhat.com>, Michael Roth <michael.roth@amd.com>
hw/core/qdev-properties.c    | 33 ++++++++++++++++++++++++++-------
qapi/string-output-visitor.c | 24 ++++++++++++++++++++----
2 files changed, 46 insertions(+), 11 deletions(-)
[PATCH for-8.2 0/2] qdev array property fixes
Posted by Kevin Wolf 1 year ago
Kevin Wolf (2):
  qdev: Fix crash in array property getter
  string-output-visitor: Support lists for non-integer types

 hw/core/qdev-properties.c    | 33 ++++++++++++++++++++++++++-------
 qapi/string-output-visitor.c | 24 ++++++++++++++++++++----
 2 files changed, 46 insertions(+), 11 deletions(-)

-- 
2.42.0
Re: [PATCH for-8.2 0/2] qdev array property fixes
Posted by Stefan Hajnoczi 12 months ago
On Tue, 21 Nov 2023 at 12:35, Kevin Wolf <kwolf@redhat.com> wrote:
>
> Kevin Wolf (2):
>   qdev: Fix crash in array property getter
>   string-output-visitor: Support lists for non-integer types
>
>  hw/core/qdev-properties.c    | 33 ++++++++++++++++++++++++++-------
>  qapi/string-output-visitor.c | 24 ++++++++++++++++++++----
>  2 files changed, 46 insertions(+), 11 deletions(-)

Applied, thanks!

Stefan

>
> --
> 2.42.0
>
>
Re: [PATCH for-8.2 0/2] qdev array property fixes
Posted by Thomas Huth 1 year ago
On 21/11/2023 18.34, Kevin Wolf wrote:
> Kevin Wolf (2):
>    qdev: Fix crash in array property getter
>    string-output-visitor: Support lists for non-integer types
> 
>   hw/core/qdev-properties.c    | 33 ++++++++++++++++++++++++++-------
>   qapi/string-output-visitor.c | 24 ++++++++++++++++++++----
>   2 files changed, 46 insertions(+), 11 deletions(-)

Thanks, I can confirm that this series fixes the problem for me - both 
locally when compiling with CFI, and on Travis (where I observed the problem 
first):

  https://app.travis-ci.com/github/huth/qemu/jobs/613659935#L6580

Tested-by: Thomas Huth <thuth@redhat.com>