[v3] hw/usb: fix xhci port notify

[PATCH v3] hw/usb: fix xhci port notify

Posted by Nikita Ostrenkov 1 year ago

From MCF5253 Reference manual https://www.nxp.com/docs/en/reference-manual/MCF5253RM.pdf

Host mode: Port Change Detect. The controller sets this bit to a one when on any port a Connect Status occurs, a PortEnable/Disable Change occurs, an Over Current Change occurs, or the Force Port Resume bit is set as theresult of a J-K transition on the suspended port.

Signed-off-by: Nikita Ostrenkov <n.ostrenkov@gmail.com>
---
 hw/usb/hcd-xhci.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c
index 4b60114207..1b2f4ac721 100644
--- a/hw/usb/hcd-xhci.c
+++ b/hw/usb/hcd-xhci.c
@@ -2627,6 +2627,7 @@ static void xhci_port_notify(XHCIPort *port, uint32_t bits)
     if (!xhci_running(port->xhci)) {
         return;
     }
+    port->xhci->usbsts |= USBSTS_PCD;
     xhci_event(port->xhci, &ev, 0);
 }
 
-- 
2.34.1

Re: [PATCH v3] hw/usb: fix xhci port notify

Posted by Nikita Ostrenkov 11 months, 2 weeks ago

ping
https://patchew.org/QEMU/20231117173916.3658-1-n.ostrenkov@gmail.com/

пт, 17 нояб. 2023 г., 20:39 Nikita Ostrenkov <n.ostrenkov@gmail.com>:

> From MCF5253 Reference manual
> https://www.nxp.com/docs/en/reference-manual/MCF5253RM.pdf
>
> Host mode: Port Change Detect. The controller sets this bit to a one when
> on any port a Connect Status occurs, a PortEnable/Disable Change occurs, an
> Over Current Change occurs, or the Force Port Resume bit is set as
> theresult of a J-K transition on the suspended port.
>
> Signed-off-by: Nikita Ostrenkov <n.ostrenkov@gmail.com>
> ---
>  hw/usb/hcd-xhci.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c
> index 4b60114207..1b2f4ac721 100644
> --- a/hw/usb/hcd-xhci.c
> +++ b/hw/usb/hcd-xhci.c
> @@ -2627,6 +2627,7 @@ static void xhci_port_notify(XHCIPort *port,
> uint32_t bits)
>      if (!xhci_running(port->xhci)) {
>          return;
>      }
> +    port->xhci->usbsts |= USBSTS_PCD;
>      xhci_event(port->xhci, &ev, 0);
>  }
>
> --
> 2.34.1
>
>

Re: [PATCH v3] hw/usb: fix xhci port notify

Posted by Nikita Ostrenkov 10 months ago

ping
https://patchew.org/QEMU/20231117173916.3658-1-n.ostrenkov@gmail.com/

пн, 18 дек. 2023 г., 13:40 Nikita Ostrenkov <n.ostrenkov@gmail.com>:

> ping
> https://patchew.org/QEMU/20231117173916.3658-1-n.ostrenkov@gmail.com/
>
> пт, 17 нояб. 2023 г., 20:39 Nikita Ostrenkov <n.ostrenkov@gmail.com>:
>
>> From MCF5253 Reference manual
>> https://www.nxp.com/docs/en/reference-manual/MCF5253RM.pdf
>>
>> Host mode: Port Change Detect. The controller sets this bit to a one when
>> on any port a Connect Status occurs, a PortEnable/Disable Change occurs, an
>> Over Current Change occurs, or the Force Port Resume bit is set as
>> theresult of a J-K transition on the suspended port.
>>
>> Signed-off-by: Nikita Ostrenkov <n.ostrenkov@gmail.com>
>> ---
>>  hw/usb/hcd-xhci.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c
>> index 4b60114207..1b2f4ac721 100644
>> --- a/hw/usb/hcd-xhci.c
>> +++ b/hw/usb/hcd-xhci.c
>> @@ -2627,6 +2627,7 @@ static void xhci_port_notify(XHCIPort *port,
>> uint32_t bits)
>>      if (!xhci_running(port->xhci)) {
>>          return;
>>      }
>> +    port->xhci->usbsts |= USBSTS_PCD;
>>      xhci_event(port->xhci, &ev, 0);
>>  }
>>
>> --
>> 2.34.1
>>
>>

Re: [PATCH v3] hw/usb: fix xhci port notify

Posted by Nikita Ostrenkov 9 months, 2 weeks ago

(+Michael)

ping
https://patchew.org/QEMU/20231117173916.3658-1-n.ostrenkov@gmail.com/

чт, 25 янв. 2024 г. в 23:06, Nikita Ostrenkov <n.ostrenkov@gmail.com>:

> ping
> https://patchew.org/QEMU/20231117173916.3658-1-n.ostrenkov@gmail.com/
>
> пн, 18 дек. 2023 г., 13:40 Nikita Ostrenkov <n.ostrenkov@gmail.com>:
>
>> ping
>> https://patchew.org/QEMU/20231117173916.3658-1-n.ostrenkov@gmail.com/
>>
>> пт, 17 нояб. 2023 г., 20:39 Nikita Ostrenkov <n.ostrenkov@gmail.com>:
>>
>>> From MCF5253 Reference manual
>>> https://www.nxp.com/docs/en/reference-manual/MCF5253RM.pdf
>>>
>>> Host mode: Port Change Detect. The controller sets this bit to a one
>>> when on any port a Connect Status occurs, a PortEnable/Disable Change
>>> occurs, an Over Current Change occurs, or the Force Port Resume bit is set
>>> as theresult of a J-K transition on the suspended port.
>>>
>>> Signed-off-by: Nikita Ostrenkov <n.ostrenkov@gmail.com>
>>> ---
>>>  hw/usb/hcd-xhci.c | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c
>>> index 4b60114207..1b2f4ac721 100644
>>> --- a/hw/usb/hcd-xhci.c
>>> +++ b/hw/usb/hcd-xhci.c
>>> @@ -2627,6 +2627,7 @@ static void xhci_port_notify(XHCIPort *port,
>>> uint32_t bits)
>>>      if (!xhci_running(port->xhci)) {
>>>          return;
>>>      }
>>> +    port->xhci->usbsts |= USBSTS_PCD;
>>>      xhci_event(port->xhci, &ev, 0);
>>>  }
>>>
>>> --
>>> 2.34.1
>>>
>>>