[PATCH 1/4] ich9: Remove unused hotplug field from ICH9LPCPMRegs struct

Thierry Escande posted 4 patches 1 year ago
Maintainers: "Michael S. Tsirkin" <mst@redhat.com>, Igor Mammedov <imammedo@redhat.com>, Ani Sinha <anisinha@redhat.com>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
[PATCH 1/4] ich9: Remove unused hotplug field from ICH9LPCPMRegs struct
Posted by Thierry Escande 1 year ago
This patch removes the unused field use_acpi_hotplug_bridge from the
ICH9LPCPMRegs structure as it is now part of AcpiPciHpState.

Hotplug fields have been removed from piix4 state structure by commit
6536e427ce49 (pcihp: move fields enabling hotplug into AcpiPciHpState)
so do the same for ich9.

Signed-off-by: Thierry Escande <thierry.escande@vates.tech>
---
 include/hw/acpi/ich9.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/include/hw/acpi/ich9.h b/include/hw/acpi/ich9.h
index 2faf7f0cae..4bc9aa1d11 100644
--- a/include/hw/acpi/ich9.h
+++ b/include/hw/acpi/ich9.h
@@ -57,7 +57,6 @@ typedef struct ICH9LPCPMRegs {
     CPUHotplugState cpuhp_state;
 
     bool keep_pci_slot_hpc;
-    bool use_acpi_hotplug_bridge;
     AcpiPciHpState acpi_pci_hotplug;
     MemHotplugState acpi_memory_hotplug;
 
-- 
2.42.0



Thierry Escande | Vates XCP-ng Developer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech
Re: [PATCH 1/4] ich9: Remove unused hotplug field from ICH9LPCPMRegs struct
Posted by Igor Mammedov 1 year ago
On Wed, 15 Nov 2023 17:18:53 +0000
Thierry Escande <thierry.escande@vates.tech> wrote:

> This patch removes the unused field use_acpi_hotplug_bridge from the
> ICH9LPCPMRegs structure as it is now part of AcpiPciHpState.
> 
> Hotplug fields have been removed from piix4 state structure by commit
> 6536e427ce49 (pcihp: move fields enabling hotplug into AcpiPciHpState)
> so do the same for ich9.
> 
> Signed-off-by: Thierry Escande <thierry.escande@vates.tech>

Reviewed-by:Igor Mammedov <imammedo@redhat.com>

> ---
>  include/hw/acpi/ich9.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/include/hw/acpi/ich9.h b/include/hw/acpi/ich9.h
> index 2faf7f0cae..4bc9aa1d11 100644
> --- a/include/hw/acpi/ich9.h
> +++ b/include/hw/acpi/ich9.h
> @@ -57,7 +57,6 @@ typedef struct ICH9LPCPMRegs {
>      CPUHotplugState cpuhp_state;
>  
>      bool keep_pci_slot_hpc;
> -    bool use_acpi_hotplug_bridge;
>      AcpiPciHpState acpi_pci_hotplug;
>      MemHotplugState acpi_memory_hotplug;
>
Re: [PATCH 1/4] ich9: Remove unused hotplug field from ICH9LPCPMRegs struct
Posted by Philippe Mathieu-Daudé 1 year ago
On 15/11/23 18:18, Thierry Escande wrote:
> This patch removes the unused field use_acpi_hotplug_bridge from the
> ICH9LPCPMRegs structure as it is now part of AcpiPciHpState.
> 
> Hotplug fields have been removed from piix4 state structure by commit
> 6536e427ce49 (pcihp: move fields enabling hotplug into AcpiPciHpState)
> so do the same for ich9.
> 
> Signed-off-by: Thierry Escande <thierry.escande@vates.tech>
> ---
>   include/hw/acpi/ich9.h | 1 -
>   1 file changed, 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>