1. Patchew
  2. QEMU
  3. View series

[PATCH] tests/avocado/intel_iommu: Add asset hashes to avoid warnings

Thomas Huth posted 1 patch 1 year ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20231114143531.291820-1-thuth@redhat.com
Maintainers: Cleber Rosa <crosa@redhat.com>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Wainer dos Santos Moschetta <wainersm@redhat.com>, Beraldo Leal <bleal@redhat.com>
tests/avocado/intel_iommu.py | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
[PATCH] tests/avocado/intel_iommu: Add asset hashes to avoid warnings
Posted by Thomas Huth 1 year ago 
The intel_iommu test is currently succeeding with annoying warnings.
Add the proper asset hashes to avoid those.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 tests/avocado/intel_iommu.py | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/tests/avocado/intel_iommu.py b/tests/avocado/intel_iommu.py
index 474d62f6bf..77635ab56c 100644
--- a/tests/avocado/intel_iommu.py
+++ b/tests/avocado/intel_iommu.py
@@ -54,9 +54,11 @@ def common_vm_setup(self, custom_kernel=None):
             return
 
         kernel_url = self.distro.pxeboot_url + 'vmlinuz'
+        kernel_hash = '5b6f6876e1b5bda314f93893271da0d5777b1f3c'
         initrd_url = self.distro.pxeboot_url + 'initrd.img'
-        self.kernel_path = self.fetch_asset(kernel_url)
-        self.initrd_path = self.fetch_asset(initrd_url)
+        initrd_hash = 'dd0340a1b39bd28f88532babd4581c67649ec5b1'
+        self.kernel_path = self.fetch_asset(kernel_url, asset_hash=kernel_hash)
+        self.initrd_path = self.fetch_asset(initrd_url, asset_hash=initrd_hash)
 
     def run_and_check(self):
         if self.kernel_path:
-- 
2.41.0
Re: [PATCH] tests/avocado/intel_iommu: Add asset hashes to avoid warnings
Posted by Eric Auger 1 year ago 
Hi Thomas,

On 11/14/23 15:35, Thomas Huth wrote:
> The intel_iommu test is currently succeeding with annoying warnings.
nit: you may have precised the nature of the warning or quotes
> Add the proper asset hashes to avoid those.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  tests/avocado/intel_iommu.py | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/tests/avocado/intel_iommu.py b/tests/avocado/intel_iommu.py
> index 474d62f6bf..77635ab56c 100644
> --- a/tests/avocado/intel_iommu.py
> +++ b/tests/avocado/intel_iommu.py
> @@ -54,9 +54,11 @@ def common_vm_setup(self, custom_kernel=None):
>              return
>  
>          kernel_url = self.distro.pxeboot_url + 'vmlinuz'
> +        kernel_hash = '5b6f6876e1b5bda314f93893271da0d5777b1f3c'
>          initrd_url = self.distro.pxeboot_url + 'initrd.img'
> -        self.kernel_path = self.fetch_asset(kernel_url)
> -        self.initrd_path = self.fetch_asset(initrd_url)
> +        initrd_hash = 'dd0340a1b39bd28f88532babd4581c67649ec5b1'
> +        self.kernel_path = self.fetch_asset(kernel_url, asset_hash=kernel_hash)
> +        self.initrd_path = self.fetch_asset(initrd_url, asset_hash=initrd_hash)
>  
>      def run_and_check(self):
>          if self.kernel_path:
Besides,
Reviewed-by: Eric Auger <eric.auger@redhat.com>

Eric
Re: [PATCH] tests/avocado/intel_iommu: Add asset hashes to avoid warnings
Posted by Thomas Huth 1 year ago 
On 14/11/2023 21.42, Eric Auger wrote:
> Hi Thomas,
> 
> On 11/14/23 15:35, Thomas Huth wrote:
>> The intel_iommu test is currently succeeding with annoying warnings.
> nit: you may have precised the nature of the warning or quotes

The annoying warnings look like this (in the summary):

  (031/174) tests/avocado/intel_iommu.py:IntelIOMMU.test_intel_iommu: WARN: 
Test passed but there were warnings during execution. Check the log for 
details. (67.87 s)
  (032/174) tests/avocado/intel_iommu.py:IntelIOMMU.test_intel_iommu_strict: 
WARN: Test passed but there were warnings during execution. Check the log 
for details. (55.83 s)
  (033/174) 
tests/avocado/intel_iommu.py:IntelIOMMU.test_intel_iommu_strict_cm: WARN: 
Test passed but there were warnings during execution. Check the log for 
details. (56.01 s)
  (034/174) tests/avocado/intel_iommu.py:IntelIOMMU.test_intel_iommu_pt: 
WARN: Test passed but there were warnings during execution. Check the log 
for details. (54.06 s)

... not too helpful to quote them in the commit log, I guess...

>> Add the proper asset hashes to avoid those.
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> ---
>>   tests/avocado/intel_iommu.py | 6 ++++--
>>   1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/tests/avocado/intel_iommu.py b/tests/avocado/intel_iommu.py
>> index 474d62f6bf..77635ab56c 100644
>> --- a/tests/avocado/intel_iommu.py
>> +++ b/tests/avocado/intel_iommu.py
>> @@ -54,9 +54,11 @@ def common_vm_setup(self, custom_kernel=None):
>>               return
>>   
>>           kernel_url = self.distro.pxeboot_url + 'vmlinuz'
>> +        kernel_hash = '5b6f6876e1b5bda314f93893271da0d5777b1f3c'
>>           initrd_url = self.distro.pxeboot_url + 'initrd.img'
>> -        self.kernel_path = self.fetch_asset(kernel_url)
>> -        self.initrd_path = self.fetch_asset(initrd_url)
>> +        initrd_hash = 'dd0340a1b39bd28f88532babd4581c67649ec5b1'
>> +        self.kernel_path = self.fetch_asset(kernel_url, asset_hash=kernel_hash)
>> +        self.initrd_path = self.fetch_asset(initrd_url, asset_hash=initrd_hash)
>>   
>>       def run_and_check(self):
>>           if self.kernel_path:
> Besides,
> Reviewed-by: Eric Auger <eric.auger@redhat.com>

Thanks!

  Thomas
Re: [PATCH] tests/avocado/intel_iommu: Add asset hashes to avoid warnings
Posted by Eric Auger 1 year ago 
Hi Thomas,

On 11/15/23 07:20, Thomas Huth wrote:
> On 14/11/2023 21.42, Eric Auger wrote:
>> Hi Thomas,
>>
>> On 11/14/23 15:35, Thomas Huth wrote:
>>> The intel_iommu test is currently succeeding with annoying warnings.
>> nit: you may have precised the nature of the warning or quotes
>
> The annoying warnings look like this (in the summary):
>
>  (031/174) tests/avocado/intel_iommu.py:IntelIOMMU.test_intel_iommu:
> WARN: Test passed but there were warnings during execution. Check the
> log for details. (67.87 s)
>  (032/174)
> tests/avocado/intel_iommu.py:IntelIOMMU.test_intel_iommu_strict: WARN:
> Test passed but there were warnings during execution. Check the log
> for details. (55.83 s)
>  (033/174)
> tests/avocado/intel_iommu.py:IntelIOMMU.test_intel_iommu_strict_cm:
> WARN: Test passed but there were warnings during execution. Check the
> log for details. (56.01 s)
>  (034/174)
> tests/avocado/intel_iommu.py:IntelIOMMU.test_intel_iommu_pt: WARN:
> Test passed but there were warnings during execution. Check the log
> for details. (54.06 s)
>
> ... not too helpful to quote them in the commit log, I guess...
Ah OK. Not really helpful indeed ;-)

Eric
>
>>> Add the proper asset hashes to avoid those.
>>>
>>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>>> ---
>>>   tests/avocado/intel_iommu.py | 6 ++++--
>>>   1 file changed, 4 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/tests/avocado/intel_iommu.py
>>> b/tests/avocado/intel_iommu.py
>>> index 474d62f6bf..77635ab56c 100644
>>> --- a/tests/avocado/intel_iommu.py
>>> +++ b/tests/avocado/intel_iommu.py
>>> @@ -54,9 +54,11 @@ def common_vm_setup(self, custom_kernel=None):
>>>               return
>>>             kernel_url = self.distro.pxeboot_url + 'vmlinuz'
>>> +        kernel_hash = '5b6f6876e1b5bda314f93893271da0d5777b1f3c'
>>>           initrd_url = self.distro.pxeboot_url + 'initrd.img'
>>> -        self.kernel_path = self.fetch_asset(kernel_url)
>>> -        self.initrd_path = self.fetch_asset(initrd_url)
>>> +        initrd_hash = 'dd0340a1b39bd28f88532babd4581c67649ec5b1'
>>> +        self.kernel_path = self.fetch_asset(kernel_url,
>>> asset_hash=kernel_hash)
>>> +        self.initrd_path = self.fetch_asset(initrd_url,
>>> asset_hash=initrd_hash)
>>>         def run_and_check(self):
>>>           if self.kernel_path:
>> Besides,
>> Reviewed-by: Eric Auger <eric.auger@redhat.com>
>
> Thanks!
>
>  Thomas
>

Patchew 2.1-devel-b67e4c2

© 2016 - 2024 Red Hat, Inc.